June 2018 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashchips: Add Macronix MX25U51245G
by Nico Huber (Code Review) 24 Jun '18

24 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/26949 ) Change subject: flashchips: Add Macronix MX25U51245G ...................................................................... Patch Set 2: (3 comments) https://review.coreboot.org/#/c/26949/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/26949/2//COMMIT_MSG@14 PS2, Line 14: the later means I : have tested 4-byte addressing Only if you verified the result with another programmer... in theory, if flashrom did the same addressing error for reading and writing, your test would also succeed. So actually, to test it one would have to write and verify random data across the complete chip. But we never set any rules how much testing is enough, it seems. https://review.coreboot.org/#/c/26949/2/flashchips.c File flashchips.c: https://review.coreboot.org/#/c/26949/2/flashchips.c@8572 PS2, Line 8572: 512B datasheet says 8kb (4kb factory, 4kb customer) https://review.coreboot.org/#/c/26949/2/flashchips.c@8579 PS2, Line 8579: { : .eraseblocks = { {4 * 1024, 16384} }, : .block_erase = spi_block_erase_20, : }, { : .eraseblocks = { {32 * 1024, 2048} }, : .block_erase = spi_block_erase_52, : }, { : .eraseblocks = { {64 * 1024, 1024} }, : .block_erase = spi_block_erase_d8, : } Please list the native 4BA versions too: 21 5c dc -- To view, visit https://review.coreboot.org/26949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2117fc205006088967f3d97644375d10db1791f1 Gerrit-Change-Number: 26949 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Thompson <daniel.thompson(a)linaro.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sun, 24 Jun 2018 13:42:07 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add support for National Instruments USB-845x devices
by Elyes HAOUAS (Code Review) 24 Jun '18

24 Jun '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/25683 ) Change subject: Add support for National Instruments USB-845x devices ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/25683/3/flashrom.c File flashrom.c: https://review.coreboot.org/#/c/25683/3/flashrom.c@417 PS3, Line 417: { : .name = "ni845x_spi", : .type = OTHER, // choose other because NI-845x uses own USB implementation : .devs.note = "National Instruments USB-845x\n", : .init = ni845x_spi_init, : .map_flash_region = fallback_map, : .unmap_flash_region = fallback_unmap, : .delay = internal_delay, : }, Please use tabs for indentation -- To view, visit https://review.coreboot.org/25683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Gerrit-Change-Number: 25683 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Sun, 24 Jun 2018 13:34:00 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: linux_mtd: Bail out early if sysfs node doesn't exist
by build bot (Jenkins) (Code Review) 24 Jun '18

24 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26500 ) Change subject: linux_mtd: Bail out early if sysfs node doesn't exist ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1345/ : SUCCESS -- To view, visit https://review.coreboot.org/26500 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dc965eecc68cd305a989016869c688fe1a3921f Gerrit-Change-Number: 26500 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Jun 2018 11:48:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: linux_mtd: Bail out early if sysfs node doesn't exist
by Nico Huber (Code Review) 24 Jun '18

24 Jun '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/26500 ) Change subject: linux_mtd: Bail out early if sysfs node doesn't exist ...................................................................... linux_mtd: Bail out early if sysfs node doesn't exist This checks that the MTD sysfs node we will use actually exists prior to calling setup code. Although the setup code will eventually catch such an error, we need to think about the use case before printing a possibly irrelevant/confusing error message to the terminal. This patch makes it so that we only print an error message if the user specifies a non-existent MTD device. Otherwise, the failure is considered benign and we only print a debug message prior to bailing out. Change-Id: I8dc965eecc68cd305a989016869c688fe1a3921f Signed-off-by: David Hendricks <dhendricks(a)fb.com> Reviewed-on: https://review.coreboot.org/26500 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M linux_mtd.c 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/linux_mtd.c b/linux_mtd.c index e65f093..ae8bef2 100644 --- a/linux_mtd.c +++ b/linux_mtd.c @@ -376,6 +376,24 @@ } } + /* + * If user specified the MTD device number then error out if it doesn't + * appear to exist. Otherwise assume the error is benign and print a + * debug message. Bail out in either case. + */ + char sysfs_path[32]; + if (snprintf(sysfs_path, sizeof(sysfs_path), "%s/mtd%d", LINUX_MTD_SYSFS_ROOT, dev_num) < 0) + goto linux_mtd_init_exit; + + struct stat s; + if (stat(sysfs_path, &s) < 0) { + if (param) + msg_perr("%s does not exist\n", sysfs_path); + else + msg_pdbg("%s does not exist\n", sysfs_path); + goto linux_mtd_init_exit; + } + if (linux_mtd_setup(dev_num)) goto linux_mtd_init_exit; -- To view, visit https://review.coreboot.org/26500 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8dc965eecc68cd305a989016869c688fe1a3921f Gerrit-Change-Number: 26500 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: bitbang_spi: Add half-duplex optimizations
by Nico Huber (Code Review) 24 Jun '18

24 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/26947 ) Change subject: bitbang_spi: Add half-duplex optimizations ...................................................................... Patch Set 2: Code-Review+1 (2 comments) https://review.coreboot.org/#/c/26947/2/bitbang_spi.c File bitbang_spi.c: https://review.coreboot.org/#/c/26947/2/bitbang_spi.c@128 PS2, Line 128: if (i == 0) : bitbang_spi_set_sck_set_mosi(master, 0, 0); : else : bitbang_spi_set_sck(master, 0); I wouldn't expect the state of MOSI to matter. Though, I never read the SPI specification. Is this defined somewhere? https://review.coreboot.org/#/c/26947/2/bitbang_spi.c@141 PS2, Line 141: uint8_t val) Nit, we have a 112 chars line limit, so no line break needed here. -- To view, visit https://review.coreboot.org/26947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33b9f363716f651146c09113bda5fffe53b16738 Gerrit-Change-Number: 26947 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Thompson <daniel.thompson(a)linaro.org> Gerrit-Reviewer: Daniel Thompson <daniel.thompson(a)linaro.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Jun 2018 11:33:08 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: bitbang_spi: Add functions to optimize xfers
by Nico Huber (Code Review) 24 Jun '18

24 Jun '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/26946 ) Change subject: bitbang_spi: Add functions to optimize xfers ...................................................................... Patch Set 2: Code-Review+1 (2 comments) As this changes the timing, I would like some confirmation that it doesn't break nicintel_spi (the only bitbang master that sets .half_period). I would expect it to work fine, though, and assume that the delay is not needed for it anyway. https://review.coreboot.org/#/c/26946/2/bitbang_spi.c File bitbang_spi.c: https://review.coreboot.org/#/c/26946/2/bitbang_spi.c@114 PS2, Line 114: bitbang_spi_set_sck_set_mosi(master, 0, 0); Shouldn't we start with CLK = 1 now? https://review.coreboot.org/#/c/26946/2/bitbang_spi.c@157 PS2, Line 157: bitbang_spi_set_sck(master, 0); Wouldn't be needed if we assume CLK = 1 between commands. -- To view, visit https://review.coreboot.org/26946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3430a9df34844cdfa82e109456be788eaa1789a Gerrit-Change-Number: 26946 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Thompson <daniel.thompson(a)linaro.org> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Jun 2018 11:26:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add support for National Instruments USB-845x devices
by build bot (Jenkins) (Code Review) 24 Jun '18

24 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25683 ) Change subject: Add support for National Instruments USB-845x devices ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1344/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1111/ : SUCCESS -- To view, visit https://review.coreboot.org/25683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Gerrit-Change-Number: 25683 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Sun, 24 Jun 2018 10:06:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add support for National Instruments USB-845x devices
by Márton Miklós (Code Review) 24 Jun '18

24 Jun '18

Márton Miklós has uploaded a new patch set (#3) to the change originally created by David Hendricks. ( https://review.coreboot.org/25683 ) Change subject: Add support for National Instruments USB-845x devices ...................................................................... Add support for National Instruments USB-845x devices Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Signed-off-by: Miklós Márton <martonmiklosqdev(a)gmail.com> --- M Makefile M flashrom.8.tmpl M flashrom.c A ni845x_spi.c M programmer.h 5 files changed, 643 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/25683/3 -- To view, visit https://review.coreboot.org/25683 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549 Gerrit-Change-Number: 25683 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com>

1 0

Change in flashrom[master]: Fix mingw detection on Windows 7 (NT-6.1)
by build bot (Jenkins) (Code Review) 23 Jun '18

23 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23865 ) Change subject: Fix mingw detection on Windows 7 (NT-6.1) ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1343/ : SUCCESS -- To view, visit https://review.coreboot.org/23865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a Gerrit-Change-Number: 23865 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com> Gerrit-Comment-Date: Sat, 23 Jun 2018 19:42:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Fix mingw detection on Windows 7 (NT-6.1)
by Nico Huber (Code Review) 23 Jun '18

23 Jun '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/23865 ) Change subject: Fix mingw detection on Windows 7 (NT-6.1) ...................................................................... Fix mingw detection on Windows 7 (NT-6.1) Hopefully also for other non-XP Windows build environments. Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a Signed-off-by: Miklós Márton <martonmiklosqdev(a)gmail.com> Reviewed-on: https://review.coreboot.org/23865 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M Makefile M util/ich_descriptors_tool/Makefile 2 files changed, 12 insertions(+), 8 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/Makefile b/Makefile index 943d88d..746d8d6 100644 --- a/Makefile +++ b/Makefile @@ -93,10 +93,11 @@ # HOST_OS is only used to work around local toolchain issues. HOST_OS ?= $(shell uname) -ifeq ($(HOST_OS), MINGW32_NT-5.1) +ifeq ($(findstring MINGW, $(HOST_OS)), MINGW) # Explicitly set CC = gcc on MinGW, otherwise: "cc: command not found". CC = gcc endif + ifneq ($(HOST_OS), SunOS) STRIP_ARGS = -s endif diff --git a/util/ich_descriptors_tool/Makefile b/util/ich_descriptors_tool/Makefile index d1b5eae..c32e30b 100644 --- a/util/ich_descriptors_tool/Makefile +++ b/util/ich_descriptors_tool/Makefile @@ -22,6 +22,16 @@ # completely ignored by gnumake. CFLAGS ?= -Os -Wall -Wshadow +HOST_OS ?= $(shell uname) +ifeq ($(findstring MINGW, $(HOST_OS)), MINGW) +# Explicitly set CC = gcc on MinGW, otherwise: "cc: command not found". +CC = gcc +EXEC_SUFFIX := .exe +# Some functions provided by Microsoft do not work as described in C99 specifications. This macro fixes that +# for MinGW. See http://sourceforge.net/p/mingw-w64/wiki2/printf%20and%20scanf%20family/ */ +FLASHROM_CFLAGS += -D__USE_MINGW_ANSI_STDIO=1 +endif + override TARGET_OS := $(shell $(CC) $(CPPFLAGS) -E $(SHAREDSRCDIR)/os.h | grep -v '^\#' | grep '"' | \ cut -f 2 -d'"') @@ -31,13 +41,6 @@ CFLAGS += -Wno-format endif -ifeq ($(TARGET_OS), MinGW) -EXEC_SUFFIX := .exe -# Some functions provided by Microsoft do not work as described in C99 specifications. This macro fixes that -# for MinGW. See http://sourceforge.net/p/mingw-w64/wiki2/printf%20and%20scanf%20family/ */ -FLASHROM_CFLAGS += -D__USE_MINGW_ANSI_STDIO=1 -endif - ifeq ($(WARNERROR), yes) CFLAGS += -Werror endif -- To view, visit https://review.coreboot.org/23865 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a Gerrit-Change-Number: 23865 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2018