June 2018 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Add support for AT25DF021A
by David Hendricks (Code Review) June 6, 2018

June 6, 2018

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26856 to look at the new patch set (#3). Change subject: Add support for AT25DF021A ...................................................................... Add support for AT25DF021A This is the low-voltage version of the AT25DF021. Tested with FT2232H Mini Module Change-Id: If4990e6856c8b77567ef4218459cf754b9c6bc57 Signed-off-by: Steffen Mauch <steffen.mauch(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/56/26856/3 -- To view, visit https://review.coreboot.org/26856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If4990e6856c8b77567ef4218459cf754b9c6bc57 Gerrit-Change-Number: 26856 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Add support for AT25DF021A
by build bot (Jenkins) (Code Review) June 6, 2018

June 6, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26856 ) Change subject: Add support for AT25DF021A ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1319/ : SUCCESS -- To view, visit https://review.coreboot.org/26856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4990e6856c8b77567ef4218459cf754b9c6bc57 Gerrit-Change-Number: 26856 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Jun 2018 05:01:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add support for AT25DF021A
by David Hendricks (Code Review) June 6, 2018

June 6, 2018

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26856 to look at the new patch set (#2). Change subject: Add support for AT25DF021A ...................................................................... Add support for AT25DF021A This is the low-voltage version of the AT25DF021. Tested with FT2232H Mini Module Change-Id: If4990e6856c8b77567ef4218459cf754b9c6bc57 Signed-off-by: Steffen Mauch <steffen.mauch(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/56/26856/2 -- To view, visit https://review.coreboot.org/26856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If4990e6856c8b77567ef4218459cf754b9c6bc57 Gerrit-Change-Number: 26856 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: added support for Adesto, formerly ATMEL, AT25DF021A flash device; te...
by David Hendricks (Code Review) June 5, 2018

June 5, 2018

David Hendricks has posted comments on this change. ( https://review.coreboot.org/26856 ) Change subject: added support for Adesto, formerly ATMEL, AT25DF021A flash device; tested with FT2232H Mini Module ...................................................................... Patch Set 1: Code-Review-1 Need to fix the title. -- To view, visit https://review.coreboot.org/26856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4990e6856c8b77567ef4218459cf754b9c6bc57 Gerrit-Change-Number: 26856 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 05:06:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: added support for Adesto, formerly ATMEL, AT25DF021A flash device; te...
by build bot (Jenkins) (Code Review) June 5, 2018

June 5, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26856 ) Change subject: added support for Adesto, formerly ATMEL, AT25DF021A flash device; tested with FT2232H Mini Module ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1318/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1091/ : SUCCESS -- To view, visit https://review.coreboot.org/26856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4990e6856c8b77567ef4218459cf754b9c6bc57 Gerrit-Change-Number: 26856 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 05:06:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: added support for Adesto, formerly ATMEL, AT25DF021A flash device; te...
by David Hendricks (Code Review) June 5, 2018

June 5, 2018

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/26856 Change subject: added support for Adesto, formerly ATMEL, AT25DF021A flash device; tested with FT2232H Mini Module ...................................................................... added support for Adesto, formerly ATMEL, AT25DF021A flash device; tested with FT2232H Mini Module Change-Id: If4990e6856c8b77567ef4218459cf754b9c6bc57 Signed-off-by: Steffen Mauch <steffen.mauch(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/56/26856/1 diff --git a/flashchips.c b/flashchips.c index 9898fa7..17cb1b4 100644 --- a/flashchips.c +++ b/flashchips.c @@ -1519,6 +1519,45 @@ { .vendor = "Atmel", + .name = "AT25DF021A", + .bustype = BUS_SPI, + .manufacture_id = ATMEL_ID, + .model_id = ATMEL_AT25DF021A, + .total_size = 256, + .page_size = 256, + /* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 64} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 8} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 4} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {256 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {256 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_at25df, + .unlock = spi_disable_blockprotect_at2x_global_unprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {1650, 3600}, + }, + + { + .vendor = "Atmel", .name = "AT25DF041A", .bustype = BUS_SPI, .manufacture_id = ATMEL_ID, diff --git a/flashchips.h b/flashchips.h index dfbda5d..5dedb38 100644 --- a/flashchips.h +++ b/flashchips.h @@ -128,6 +128,7 @@ #define ATMEL_ID 0x1F /* Atmel (now used by Adesto) */ #define ATMEL_AT25DF021 0x4300 +#define ATMEL_AT25DF021A 0x4301 #define ATMEL_AT25DF041A 0x4401 #define ATMEL_AT25DF081 0x4502 /* EDI 0x00. AT25DL081 has same ID + EDI 0x0100 */ #define ATMEL_AT25DF081A 0x4501 /* Yes, 81A has a lower number than 81 */ -- To view, visit https://review.coreboot.org/26856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If4990e6856c8b77567ef4218459cf754b9c6bc57 Gerrit-Change-Number: 26856 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[master]: chipset_enable: Add PCI IDs for discrete Kaby Lake PCHs
by build bot (Jenkins) (Code Review) June 4, 2018

June 4, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26232 ) Change subject: chipset_enable: Add PCI IDs for discrete Kaby Lake PCHs ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1317/ : SUCCESS -- To view, visit https://review.coreboot.org/26232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida545d69ec998a5d3ae4dc88e76adbb13952bceb Gerrit-Change-Number: 26232 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 10:29:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: chipset_enable: Add PCI IDs for discrete Kaby Lake PCHs
by Nico Huber (Code Review) June 4, 2018

June 4, 2018

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/26232 ) Change subject: chipset_enable: Add PCI IDs for discrete Kaby Lake PCHs ...................................................................... chipset_enable: Add PCI IDs for discrete Kaby Lake PCHs The Kaby Lake "200 Series" PCHs [1,2] share the register layout of their Skylake "100 Series" siblings. [1] Intel® 200 Series (including X299) and Intel® Z370 Series Chipset Families Platform Controller Hub (PCH) Datasheet - Volume 1 of 2 Revision 003 Document Number 335192 [2] Intel® 200 Series (including X299) Chipset Family Platform Controller Hub (PCH) Datasheet - Volume 2 of 2 Revision 003 Document Number 335193 Change-Id: Ida545d69ec998a5d3ae4dc88e76adbb13952bceb Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/26232 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> --- M chipset_enable.c 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved diff --git a/chipset_enable.c b/chipset_enable.c index 15b760b..5c874f5 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1945,6 +1945,13 @@ {0x8086, 0xa245, NT, "Intel", "C627 Series Chipset Supersku", enable_flash_c620}, {0x8086, 0xa246, NT, "Intel", "C628 Series Chipset Supersku", enable_flash_c620}, {0x8086, 0xa247, NT, "Intel", "C620 Series Chipset Supersku", enable_flash_c620}, + {0x8086, 0xa2c4, NT, "Intel", "H270", enable_flash_pch100}, + {0x8086, 0xa2c5, NT, "Intel", "Z270", enable_flash_pch100}, + {0x8086, 0xa2c6, NT, "Intel", "Q270", enable_flash_pch100}, + {0x8086, 0xa2c7, NT, "Intel", "Q250", enable_flash_pch100}, + {0x8086, 0xa2c8, NT, "Intel", "B250", enable_flash_pch100}, + {0x8086, 0xa2c9, NT, "Intel", "Z370", enable_flash_pch100}, + {0x8086, 0xa2d2, NT, "Intel", "X299", enable_flash_pch100}, #endif {0}, }; -- To view, visit https://review.coreboot.org/26232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ida545d69ec998a5d3ae4dc88e76adbb13952bceb Gerrit-Change-Number: 26232 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Add support for the AT25SF081
by build bot (Jenkins) (Code Review) June 4, 2018

June 4, 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26779 ) Change subject: Add support for the AT25SF081 ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1316/ : SUCCESS -- To view, visit https://review.coreboot.org/26779 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a3d900462ad9e7a3b34575d7c98acc7c2df0445 Gerrit-Change-Number: 26779 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 09:54:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add support for the AT25SF081
by Nico Huber (Code Review) June 4, 2018

June 4, 2018

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/26779 ) Change subject: Add support for the AT25SF081 ...................................................................... Add support for the AT25SF081 Change-Id: I1a3d900462ad9e7a3b34575d7c98acc7c2df0445 Signed-off-by: Evan Jensen <evan.p.jensen(a)gmail.com> Reviewed-on: https://review.coreboot.org/26779 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> --- M flashchips.c M flashchips.h 2 files changed, 40 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 8eda608..9898fa7 100644 --- a/flashchips.c +++ b/flashchips.c @@ -2211,6 +2211,44 @@ { .vendor = "Atmel", + .name = "AT25SF081", + .bustype = BUS_SPI, + .manufacture_id = ATMEL_ID, + .model_id = ATMEL_AT25SF081, + .total_size = 1024, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 256} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 32} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 16} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2300, 3600}, + }, + + { + .vendor = "Atmel", .name = "AT25SF161", .bustype = BUS_SPI, .manufacture_id = ATMEL_ID, diff --git a/flashchips.h b/flashchips.h index f00be3b..dfbda5d 100644 --- a/flashchips.h +++ b/flashchips.h @@ -147,13 +147,14 @@ #define ATMEL_AT25FS010 0x6601 #define ATMEL_AT25FS040 0x6604 #define ATMEL_AT25SF041 0x8401 +#define ATMEL_AT25SF081 0x8501 +#define ATMEL_AT25SF161 0x8601 #define ATMEL_AT26DF041 0x4400 #define ATMEL_AT26DF081 0x4500 /* guessed, no datasheet available */ #define ATMEL_AT26DF081A 0x4501 #define ATMEL_AT26DF161 0x4600 #define ATMEL_AT26DF161A 0x4601 #define ATMEL_AT26DF321 0x4700 /* Same as 25DF321 */ -#define ATMEL_AT25SF161 0x8601 #define ATMEL_AT26F004 0x0400 #define ATMEL_AT29LV512 0x3D #define ATMEL_AT29LV010A 0x35 /* Same as AT29BV010A, the latter works down to 2.7V */ -- To view, visit https://review.coreboot.org/26779 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1a3d900462ad9e7a3b34575d7c98acc7c2df0445 Gerrit-Change-Number: 26779 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0