February 2018 - flashrom-gerrit

Change in flashrom[master]: [RFC]Don't make layoutfile and --ifd mutually exclusive
by Arthur Heymans (Code Review) 09 Feb '18

09 Feb '18

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23678 to look at the new patch set (#3). Change subject: [RFC]Don't make layoutfile and --ifd mutually exclusive ...................................................................... [RFC]Don't make layoutfile and --ifd mutually exclusive Simply append the --ifd entries to the entries found in the layout file. When there are multiple entries with the same name the first one encountered will be used. If an entry occurs in the layoutfile and is generated the ifd the one in the layoutfile will take precedence. Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M cli_classic.c M flash.h M layout.c 3 files changed, 33 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/23678/3 -- To view, visit https://review.coreboot.org/23678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13 Gerrit-Change-Number: 23678 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Add support for the ENE Embedded Debug Interface EDI and KB9012 EC
by Nico Huber (Code Review) 09 Feb '18

09 Feb '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23259 ) Change subject: Add support for the ENE Embedded Debug Interface EDI and KB9012 EC ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/23259 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8b2eb2feeef5c337d725d15ebf994a299897854 Gerrit-Change-Number: 23259 Gerrit-PatchSet: 10 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 23:42:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: [RFC]Don't make layoutfile and --ifd mutually exclusive
by build bot (Jenkins) (Code Review) 09 Feb '18

09 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23678 ) Change subject: [RFC]Don't make layoutfile and --ifd mutually exclusive ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1123/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/947/ : SUCCESS -- To view, visit https://review.coreboot.org/23678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13 Gerrit-Change-Number: 23678 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 23:41:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: [RFC]Don't make layoutfile and --ifd mutually exclusive
by Arthur Heymans (Code Review) 09 Feb '18

09 Feb '18

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23678 to look at the new patch set (#2). Change subject: [RFC]Don't make layoutfile and --ifd mutually exclusive ...................................................................... [RFC]Don't make layoutfile and --ifd mutually exclusive Simply append the --ifd entries to the entries found in the layout file. When there are multiple entries with the same name the first one encountered will be used. If an entry occurs in the layoutfile and is generated the ifd the one in the layoutfile will take precedence. Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M cli_classic.c M flash.h M layout.c 3 files changed, 32 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/23678/2 -- To view, visit https://review.coreboot.org/23678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13 Gerrit-Change-Number: 23678 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: edi: Add dummy read to ensure proper detection of ENE chips
by Nico Huber (Code Review) 09 Feb '18

09 Feb '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23260 ) Change subject: edi: Add dummy read to ensure proper detection of ENE chips ...................................................................... Patch Set 7: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/23260/7/edi.c File edi.c: https://review.coreboot.org/#/c/23260/7/edi.c@492 PS7, Line 492: ' spurious ' ? Missing full-stop. -- To view, visit https://review.coreboot.org/23260 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69ee71674649cd8ba4fc635f889cb39a1cd204b9 Gerrit-Change-Number: 23260 Gerrit-PatchSet: 7 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 23:38:06 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: [WIP]Add support to get layout from a binary fmap file
by build bot (Jenkins) (Code Review) 09 Feb '18

09 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23203 ) Change subject: [WIP]Add support to get layout from a binary fmap file ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1122/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/946/ : SUCCESS -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 23:18:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: [WIP]Add support to get layout from a binary fmap file
by Arthur Heymans (Code Review) 09 Feb '18

09 Feb '18

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23203 to look at the new patch set (#5). Change subject: [WIP]Add support to get layout from a binary fmap file ...................................................................... [WIP]Add support to get layout from a binary fmap file This is mutually exclusive with using a layoutfile or fetching the layout from ifd. Does not work since stack is smashed when parsing fmap buffer. Is dynamic allocation of buffer containing fmap binary really needed? Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Makefile M cli_classic.c M flashrom.8.tmpl A fmap.c A fmap.h M layout.c 6 files changed, 182 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/23203/5 -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: [RFC]Don't make layoutfile and --ifd mutually exclusive
by Nico Huber (Code Review) 09 Feb '18

09 Feb '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23678 ) Change subject: [RFC]Don't make layoutfile and --ifd mutually exclusive ...................................................................... Patch Set 1: (3 comments) Long story short, you'd have to find a way without changing the interface of flashrom_layout_read_from_ifd() or redesign the way layouts are handled in the library interface. https://review.coreboot.org/#/c/23678/1/cli_classic.c File cli_classic.c: https://review.coreboot.org/#/c/23678/1/cli_classic.c@a393 PS1, Line 393: I guess, I left it up here so we can bail out early without probing for the flash chip. https://review.coreboot.org/#/c/23678/1/libflashrom.c File libflashrom.c: https://review.coreboot.org/#/c/23678/1/libflashrom.c@316 PS1, Line 316: gets set ... https://review.coreboot.org/#/c/23678/1/libflashrom.c@377 PS1, Line 377: num_entries++ Overflow check? I guess it's impossible without knowing that `*layout` points to the global layout. You could, ofc, assume that, remove the `layout` parameter and remove this function from the library interface because it could only be used in- ternally. -- To view, visit https://review.coreboot.org/23678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13 Gerrit-Change-Number: 23678 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 23:15:01 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add support for the ENE Embedded Debug Interface EDI and KB9012 EC
by Mike Banon (Code Review) 09 Feb '18

09 Feb '18

Mike Banon has posted comments on this change. ( https://review.coreboot.org/23259 ) Change subject: Add support for the ENE Embedded Debug Interface EDI and KB9012 EC ...................................................................... Patch Set 10: > > You need all three commits (23258, 23259, 23262) on a single > branch. > IMO, easiest way is to check this one out (which will include 23258 > as its parent) and rebase on 23262. > > git fetch ssh://Nico@review.coreboot.org:29418/flashrom > refs/changes/59/23259/8 && git checkout FETCH_HEAD > git fetch ssh://Nico@review.coreboot.org:29418/flashrom > refs/changes/62/23262/5 && git rebase FETCH_HEAD > git push ... > Thank you very much for your help! After a few tries I got the last command correctly ("git push origin HEAD:refs/for/master") and now it builds OK :) > > > Also its' a bit unclear to > > me, what did you mean by "add and use another class" for this > > commit. Please could you clarify? > > I meant you should extend the enum added by 23262 (e.g. add > SPI_EDI) and set `.spi_cmd_set = SPI_EDI,` in the flashchips.c > entry. > Completed -- To view, visit https://review.coreboot.org/23259 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8b2eb2feeef5c337d725d15ebf994a299897854 Gerrit-Change-Number: 23259 Gerrit-PatchSet: 10 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 23:00:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: [RFC]Don't make layoutfile and --ifd mutually exclusive
by build bot (Jenkins) (Code Review) 09 Feb '18

09 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23678 ) Change subject: [RFC]Don't make layoutfile and --ifd mutually exclusive ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1121/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/945/ : SUCCESS -- To view, visit https://review.coreboot.org/23678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13 Gerrit-Change-Number: 23678 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 22:59:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit February 2018