February 2018 - flashrom-gerrit

Change in flashrom[master]: edi: Add dummy read to ensure proper detection of ENE chips
by Mike Banon (Code Review) 10 Feb '18

10 Feb '18

Mike Banon has posted comments on this change. ( https://review.coreboot.org/23260 ) Change subject: edi: Add dummy read to ensure proper detection of ENE chips ...................................................................... Patch Set 8: (1 comment) https://review.coreboot.org/#/c/23260/7/edi.c File edi.c: https://review.coreboot.org/#/c/23260/7/edi.c@492 PS7, Line 492: > spurious ' ? […] Fixed -- To view, visit https://review.coreboot.org/23260 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69ee71674649cd8ba4fc635f889cb39a1cd204b9 Gerrit-Change-Number: 23260 Gerrit-PatchSet: 8 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 09:10:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: edi: Add dummy read to ensure proper detection of ENE chips
by build bot (Jenkins) (Code Review) 10 Feb '18

10 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23260 ) Change subject: edi: Add dummy read to ensure proper detection of ENE chips ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1127/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/951/ : SUCCESS -- To view, visit https://review.coreboot.org/23260 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69ee71674649cd8ba4fc635f889cb39a1cd204b9 Gerrit-Change-Number: 23260 Gerrit-PatchSet: 8 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 09:10:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: edi: Add dummy read to ensure proper detection of ENE chips
by Mike Banon (Code Review) 10 Feb '18

10 Feb '18

Hello Paul Kocialkowski, Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23260 to look at the new patch set (#8). Change subject: edi: Add dummy read to ensure proper detection of ENE chips ...................................................................... edi: Add dummy read to ensure proper detection of ENE chips ENE chips enable EDI by detecting a clock frequency between 1 MHz and 8 MHz. In many cases, the chip won't be able to both detect the clock signal and serve the associated request at the same time. Thus, a dummy read has to be added to ensure that EDI is enabled and operational starting from the next request. Change-Id: I69ee71674649cd8ba4fc635f889cb39a1cd204b9 Signed-off-by: Mike Banon <mikebdp2(a)gmail.com> Signed-off-by: Paul Kocialkowski <contact(a)paulk.fr> --- M edi.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/60/23260/8 -- To view, visit https://review.coreboot.org/23260 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I69ee71674649cd8ba4fc635f889cb39a1cd204b9 Gerrit-Change-Number: 23260 Gerrit-PatchSet: 8 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: [RFC]Don't make layoutfile and --ifd mutually exclusive
by Arthur Heymans (Code Review) 10 Feb '18

10 Feb '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23678 ) Change subject: [RFC]Don't make layoutfile and --ifd mutually exclusive ...................................................................... Patch Set 5: (1 comment) > (5 comments) > > Hmmm, I'll sleep over it. Don't like the possibility to specify > a conflicting layout file by accident without noticing. This is already a problem if 2 homonymous but different entries exist in a layout file... https://review.coreboot.org/#/c/23678/1/libflashrom.c File libflashrom.c: https://review.coreboot.org/#/c/23678/1/libflashrom.c@377 PS1, Line 377: > Overflow check? I guess it's impossible without knowing that […] Using an append function like in 23353 could do it? -- To view, visit https://review.coreboot.org/23678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13 Gerrit-Change-Number: 23678 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 10 Feb 2018 00:00:35 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: [RFC]Don't make layoutfile and --ifd mutually exclusive
by Nico Huber (Code Review) 09 Feb '18

09 Feb '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23678 ) Change subject: [RFC]Don't make layoutfile and --ifd mutually exclusive ...................................................................... Patch Set 5: (5 comments) Hmmm, I'll sleep over it. Don't like the possibility to specify a conflicting layout file by accident without noticing. https://review.coreboot.org/#/c/23678/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/23678/2//COMMIT_MSG@14 PS2, Line 14: the one in the layoutfile will take : precedence don't like it... https://review.coreboot.org/#/c/23678/2/cli_classic.c File cli_classic.c: https://review.coreboot.org/#/c/23678/2/cli_classic.c@541 PS2, Line 541: if (process_include_args(layout)) { Unrelated: Can somebdoy initialize it to 1 please ;) https://review.coreboot.org/#/c/23678/2/layout.c File layout.c: https://review.coreboot.org/#/c/23678/2/layout.c@100 PS2, Line 100: int flashrom_get_layout_from_ifd(struct flashctx *fill_flash) Nit, flashrom_ prefix was introduced for the library interface, not needed here. https://review.coreboot.org/#/c/23678/2/layout.c@108 PS2, Line 108: if (layout.num_entries >= MAX_ROMLAYOUT) { Still needs an overflow check. https://review.coreboot.org/#/c/23678/5/layout.c File layout.c: https://review.coreboot.org/#/c/23678/5/layout.c@112 PS5, Line 112: } Would probably look nicer before the loop. if (...->num_entries + ...->num_entries > MAX_ROMLAYOUT) -- To view, visit https://review.coreboot.org/23678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13 Gerrit-Change-Number: 23678 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 23:55:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: [RFC]Don't make layoutfile and --ifd mutually exclusive
by build bot (Jenkins) (Code Review) 09 Feb '18

09 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23678 ) Change subject: [RFC]Don't make layoutfile and --ifd mutually exclusive ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1126/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/950/ : SUCCESS -- To view, visit https://review.coreboot.org/23678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13 Gerrit-Change-Number: 23678 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 23:50:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: [RFC]Don't make layoutfile and --ifd mutually exclusive
by Arthur Heymans (Code Review) 09 Feb '18

09 Feb '18

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23678 to look at the new patch set (#5). Change subject: [RFC]Don't make layoutfile and --ifd mutually exclusive ...................................................................... [RFC]Don't make layoutfile and --ifd mutually exclusive Simply append the --ifd entries to the entries found in the layout file. When there are multiple entries with the same name the first one encountered will be used. If an entry occurs in the layoutfile and is generated the ifd the one in the layoutfile will take precedence. Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M cli_classic.c M flash.h M layout.c 3 files changed, 39 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/23678/5 -- To view, visit https://review.coreboot.org/23678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13 Gerrit-Change-Number: 23678 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: [RFC]Don't make layoutfile and --ifd mutually exclusive
by build bot (Jenkins) (Code Review) 09 Feb '18

09 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23678 ) Change subject: [RFC]Don't make layoutfile and --ifd mutually exclusive ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/949/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/1125/ : SUCCESS -- To view, visit https://review.coreboot.org/23678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13 Gerrit-Change-Number: 23678 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 23:48:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: [RFC]Don't make layoutfile and --ifd mutually exclusive
by Arthur Heymans (Code Review) 09 Feb '18

09 Feb '18

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23678 to look at the new patch set (#4). Change subject: [RFC]Don't make layoutfile and --ifd mutually exclusive ...................................................................... [RFC]Don't make layoutfile and --ifd mutually exclusive Simply append the --ifd entries to the entries found in the layout file. When there are multiple entries with the same name the first one encountered will be used. If an entry occurs in the layoutfile and is generated the ifd the one in the layoutfile will take precedence. Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M cli_classic.c M flash.h M layout.c 3 files changed, 38 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/23678/4 -- To view, visit https://review.coreboot.org/23678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13 Gerrit-Change-Number: 23678 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: [RFC]Don't make layoutfile and --ifd mutually exclusive
by build bot (Jenkins) (Code Review) 09 Feb '18

09 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23678 ) Change subject: [RFC]Don't make layoutfile and --ifd mutually exclusive ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1124/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/948/ : SUCCESS -- To view, visit https://review.coreboot.org/23678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8602196e56e8903a4a22f8070a97f39628e0cc13 Gerrit-Change-Number: 23678 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 09 Feb 2018 23:44:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit February 2018