June 2017 - flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: Enable continuous SPI reads
by Urja Rannikko (Code Review) 17 Jun '17

17 Jun '17

Hello Stefan Tauner, David Hendricks, Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/20223 to look at the new patch set (#4). Change subject: Enable continuous SPI reads ...................................................................... Enable continuous SPI reads Previous unnecessary page-by-page reading is repurposed to read by big naturally aligned areas (now chip size limited to 16MB for future-proofing of 4 byte addressed multi-die chips) and serprog hack for continuous reads is removed. Change-Id: Iadf909c9216578b1c5dacd4c4991bb436e32edc9 Signed-off-by: Urja Rannikko <urjaman(a)gmail.com> --- M serprog.c M spi25.c 2 files changed, 15 insertions(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/20223/4 -- To view, visit https://review.coreboot.org/20223 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iadf909c9216578b1c5dacd4c4991bb436e32edc9 Gerrit-Change-Number: 20223 Gerrit-PatchSet: 4 Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: fixup of "Kill doit()"
by Urja Rannikko (Code Review) 17 Jun '17

17 Jun '17

Urja Rannikko has posted comments on this change. ( https://review.coreboot.org/20250 ) Change subject: fixup of "Kill doit()" ...................................................................... Patch Set 1: Okay so this is my attempt at following the developer guidelines for fixups, but on gerrit. The commit-msg hook doesnt give a Change-Id if the name has "fixup!" in it, which seems like that was meant for avoiding pushing fixes that were supposed to be rebased locally, whereas we were (supposed to, atleast i think) do these rebases from staging to stable, so thats why the slightly differently named topic. -- To view, visit https://review.coreboot.org/20250 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Id9e715f09ef934bc36221b3e72c578ae96e0a3af Gerrit-Change-Number: 20250 Gerrit-PatchSet: 1 Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Jun 2017 08:40:45 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: fixup of "Kill doit()"
by build bot (Jenkins) (Code Review) 17 Jun '17

17 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20250 ) Change subject: fixup of "Kill doit()" ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/378/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/388/ : SUCCESS -- To view, visit https://review.coreboot.org/20250 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Id9e715f09ef934bc36221b3e72c578ae96e0a3af Gerrit-Change-Number: 20250 Gerrit-PatchSet: 1 Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Jun 2017 08:35:35 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: fixup of "Kill doit()"
by Urja Rannikko (Code Review) 17 Jun '17

17 Jun '17

Urja Rannikko has uploaded this change for review. ( https://review.coreboot.org/20250 Change subject: fixup of "Kill doit()" ...................................................................... fixup of "Kill doit()" Fix building with CONFIG_INTERNAL=no because force_boardmismatch doesnt exist when internal is not enabled. Change-Id: Id9e715f09ef934bc36221b3e72c578ae96e0a3af Signed-off-by: Urja Rannikko <urjaman(a)gmail.com> --- M cli_classic.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/50/20250/1 diff --git a/cli_classic.c b/cli_classic.c index 0a09cfd..4c3db4d 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -553,7 +553,9 @@ flashrom_layout_set(fill_flash, layout); flashrom_flag_set(fill_flash, FLASHROM_FLAG_FORCE, !!force); +#if CONFIG_INTERNAL == 1 flashrom_flag_set(fill_flash, FLASHROM_FLAG_FORCE_BOARDMISMATCH, !!force_boardmismatch); +#endif flashrom_flag_set(fill_flash, FLASHROM_FLAG_VERIFY_AFTER_WRITE, !dont_verify_it); flashrom_flag_set(fill_flash, FLASHROM_FLAG_VERIFY_WHOLE_CHIP, !dont_verify_all); -- To view, visit https://review.coreboot.org/20250 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: Id9e715f09ef934bc36221b3e72c578ae96e0a3af Gerrit-Change-Number: 20250 Gerrit-PatchSet: 1 Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com>

1 0

Change in flashrom[staging]: ich_descriptors: Pretty print an assumed chipset
by Arthur Heymans (Code Review) 17 Jun '17

17 Jun '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/20247 ) Change subject: ich_descriptors: Pretty print an assumed chipset ...................................................................... Patch Set 1: Code-Review+1 Correctly reports ICH9 on thinkpad X200. -- To view, visit https://review.coreboot.org/20247 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Id28cb3abc45c6e7f4c4accfc019579c7448c45d7 Gerrit-Change-Number: 20247 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Jun 2017 07:07:42 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: ich_descriptors: Fix more odd +1s
by Nico Huber (Code Review) 17 Jun '17

17 Jun '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/19044 ) Change subject: ich_descriptors: Fix more odd +1s ...................................................................... Patch Set 3: (3 comments) https://review.coreboot.org/#/c/19044/3/ich_descriptors.c File ich_descriptors.c: https://review.coreboot.org/#/c/19044/3/ich_descriptors.c@a620 PS3, Line 620: > Just realized that I killed this whitespace by accident. Done https://review.coreboot.org/#/c/19044/3/ich_descriptors.c@619 PS3, Line 619: + 1 > This seems off, too. Done https://review.coreboot.org/#/c/19044/3/ich_descriptors.c@619 PS3, Line 619: sizeof(desc->north.STRPs) / 4 > Isn't it just ARRAY_SIZE()? Done -- To view, visit https://review.coreboot.org/19044 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ifa5455c999e90ff9121aed29f542d71ac9ca2b1c Gerrit-Change-Number: 19044 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Jun 2017 01:19:54 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: ich_descriptors: Update for Intel Skylake
by build bot (Jenkins) (Code Review) 17 Jun '17

17 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18973 ) Change subject: ich_descriptors: Update for Intel Skylake ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/376/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/384/ : SUCCESS -- To view, visit https://review.coreboot.org/18973 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Idd60a857d1ecffcb2e437af21134d9de44dcceb8 Gerrit-Change-Number: 18973 Gerrit-PatchSet: 10 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Jun 2017 01:10:10 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: chipset_enable: Set 100 series chipsets to NT
by build bot (Jenkins) (Code Review) 17 Jun '17

17 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19047 ) Change subject: chipset_enable: Set 100 series chipsets to NT ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/375/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/385/ : SUCCESS -- To view, visit https://review.coreboot.org/19047 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I9376a0c180b7e73751fbd3c8c37b693d358cbfb8 Gerrit-Change-Number: 19047 Gerrit-PatchSet: 6 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Jun 2017 01:10:09 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: ich_descriptors: Pretty print an assumed chipset
by build bot (Jenkins) (Code Review) 17 Jun '17

17 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20247 ) Change subject: ich_descriptors: Pretty print an assumed chipset ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/377/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/387/ : SUCCESS -- To view, visit https://review.coreboot.org/20247 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Id28cb3abc45c6e7f4c4accfc019579c7448c45d7 Gerrit-Change-Number: 20247 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Jun 2017 01:10:08 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: ich_descriptors: Add function to guess chipset version
by build bot (Jenkins) (Code Review) 17 Jun '17

17 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20246 ) Change subject: ich_descriptors: Add function to guess chipset version ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/374/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/386/ : SUCCESS -- To view, visit https://review.coreboot.org/20246 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ie1736663dc33801b19d3e695c072c61a6c6345a2 Gerrit-Change-Number: 20246 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 17 Jun 2017 01:10:06 +0000 Gerrit-HasComments: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit June 2017