December 2017 - flashrom-gerrit

Change in flashrom[staging]: Prepare for a single branch on gerrit
by Stefan Reinauer (Code Review) 07 Dec '17

07 Dec '17

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/22330 ) Change subject: Prepare for a single branch on gerrit ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/22330 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I13aa478edd200ce85da86962e4f94f7ac446b05f Gerrit-Change-Number: 22330 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 19:27:59 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: flashchips: Add MX25L6473F
by David Hendricks (Code Review) 07 Dec '17

07 Dec '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22759 ) Change subject: flashchips: Add MX25L6473F ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/22759 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibea956e48e10fda91930b65b3bf3b3ae4ad13f63 Gerrit-Change-Number: 22759 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 15:54:03 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: flashchips: Add MX25L6473F
by build bot (Jenkins) (Code Review) 06 Dec '17

06 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22759 ) Change subject: flashchips: Add MX25L6473F ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/798/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/911/ : SUCCESS -- To view, visit https://review.coreboot.org/22759 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibea956e48e10fda91930b65b3bf3b3ae4ad13f63 Gerrit-Change-Number: 22759 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Dec 2017 20:05:08 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: flashchips: Add MX25L6473F
by Nico Huber (Code Review) 06 Dec '17

06 Dec '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/22759 Change subject: flashchips: Add MX25L6473F ...................................................................... flashchips: Add MX25L6473F Just another chip sharing the same ID. Tested by somebody on IRC. Change-Id: Ibea956e48e10fda91930b65b3bf3b3ae4ad13f63 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/59/22759/1 diff --git a/flashchips.c b/flashchips.c index a1ad445..a33b37e 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7929,7 +7929,7 @@ { .vendor = "Macronix", - .name = "MX25L6436E/MX25L6445E/MX25L6465E/MX25L6473E", + .name = "MX25L6436E/MX25L6445E/MX25L6465E/MX25L6473E/MX25L6473F", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID, .model_id = MACRONIX_MX25L6405, -- To view, visit https://review.coreboot.org/22759 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibea956e48e10fda91930b65b3bf3b3ae4ad13f63 Gerrit-Change-Number: 22759 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: do not stop probing for flashchips after map_flash() failed
by David Hendricks (Code Review) 04 Dec '17

04 Dec '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22685 ) Change subject: do not stop probing for flashchips after map_flash() failed ...................................................................... Patch Set 1: Code-Review+1 This is a pull request from https://github.com/flashrom/flashrom/pull/25 -- To view, visit https://review.coreboot.org/22685 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaecfb6d30a5152c8c4b5d2804efacac85fc615f9 Gerrit-Change-Number: 22685 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Dec 2017 00:38:24 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: do not stop probing for flashchips after map_flash() failed
by build bot (Jenkins) (Code Review) 04 Dec '17

04 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22685 ) Change subject: do not stop probing for flashchips after map_flash() failed ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/797/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/910/ : SUCCESS -- To view, visit https://review.coreboot.org/22685 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaecfb6d30a5152c8c4b5d2804efacac85fc615f9 Gerrit-Change-Number: 22685 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Dec 2017 00:37:01 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: do not stop probing for flashchips after map_flash() failed
by David Hendricks (Code Review) 04 Dec '17

04 Dec '17

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/22685 Change subject: do not stop probing for flashchips after map_flash() failed ...................................................................... do not stop probing for flashchips after map_flash() failed Instead, continue probing the next chip. This fixes the problem that flashrom aborts probing for flashchips if one big flashchip (e.g. 32M/64M) can't be mapped because of activated CONFIG_STRICT_DEVMEM kernel option. Change-Id: Iaecfb6d30a5152c8c4b5d2804efacac85fc615f9 Signed-off-by: Martin Schiller <ms(a)dev.tdt.de> --- M flashrom.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/85/22685/1 diff --git a/flashrom.c b/flashrom.c index 4fe1843..12d7390 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1224,7 +1224,7 @@ flash->mst = mst; if (map_flash(flash) != 0) - return -1; + goto notfound; /* We handle a forced match like a real match, we just avoid probing. Note that probe_flash() * is only called with force=1 after normal probing failed. -- To view, visit https://review.coreboot.org/22685 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iaecfb6d30a5152c8c4b5d2804efacac85fc615f9 Gerrit-Change-Number: 22685 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[master]: internal: Fix warnings about unused constants
by Patrick Rudolph (Code Review) 03 Dec '17

03 Dec '17

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/22669 ) Change subject: internal: Fix warnings about unused constants ...................................................................... Patch Set 1: Code-Review+2 Tested on raspberry pi. It now compiles without error. -- To view, visit https://review.coreboot.org/22669 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3b6d7c0c2fadc4faeab971673bfadb1a6d25919 Gerrit-Change-Number: 22669 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 03 Dec 2017 14:35:58 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: internal: Only build on x86 and mipsel
by Patrick Rudolph (Code Review) 03 Dec '17

03 Dec '17

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/22671 ) Change subject: internal: Only build on x86 and mipsel ...................................................................... Patch Set 1: Code-Review+2 Tested on raspberry pi. It now compiles without error. -- To view, visit https://review.coreboot.org/22671 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I672ddab0415df3baa49ff39a1c9db1b41d8143a4 Gerrit-Change-Number: 22671 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 03 Dec 2017 14:33:58 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: internal: Only build on x86 and mipsel
by David Hendricks (Code Review) 02 Dec '17

02 Dec '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22671 ) Change subject: internal: Only build on x86 and mipsel ...................................................................... Patch Set 1: Code-Review+2 I like the clean-up that this accomplishes, so LGTM. Bikeshed: We may want to revisit the name or meaning of "internal" to not exclude ARM and other architectures. The naming is sort of confusing when considering linux_spi and (soon) linux_mtd which also control an internal programmer interface. -- To view, visit https://review.coreboot.org/22671 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I672ddab0415df3baa49ff39a1c9db1b41d8143a4 Gerrit-Change-Number: 22671 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Dec 2017 20:00:42 +0000 Gerrit-HasComments: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit December 2017