December 2017 - flashrom-gerrit

Change in flashrom[master]: spi25: Revise decision when to enter/exit 4BA mode
by Stefan Reinauer (Code Review) 24 Dec '17

24 Dec '17

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/22422 ) Change subject: spi25: Revise decision when to enter/exit 4BA mode ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/22422 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I877fe817f801fc54bd0ee2ce4e3ead324cbb3673 Gerrit-Change-Number: 22422 Gerrit-PatchSet: 5 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Dec 2017 05:25:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: spi_master: Introduce SPI_MASTER_4BA feature flag
by Stefan Reinauer (Code Review) 24 Dec '17

24 Dec '17

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/22421 ) Change subject: spi_master: Introduce SPI_MASTER_4BA feature flag ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/22421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife66e3fc49b9716f9c99cad957095b528135ec2c Gerrit-Change-Number: 22421 Gerrit-PatchSet: 6 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Dec 2017 05:25:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: spi25: Enable native 4BA read and write using feature bits
by Stefan Reinauer (Code Review) 24 Dec '17

24 Dec '17

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/22385 ) Change subject: spi25: Enable native 4BA read and write using feature bits ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/22385 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f6817ca198bf923671a7aa67e956e5477d71848 Gerrit-Change-Number: 22385 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Dec 2017 05:25:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: spi25: Integrate 4BA support
by Stefan Reinauer (Code Review) 24 Dec '17

24 Dec '17

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/22384 ) Change subject: spi25: Integrate 4BA support ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/22384 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I644600beaab9a571b97b67f7516abe571d3460c1 Gerrit-Change-Number: 22384 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Dec 2017 05:24:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: [WIP] git-hooks: Fix install script for various git versions
by build bot (Jenkins) (Code Review) 22 Dec '17

22 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22971 ) Change subject: [WIP] git-hooks: Fix install script for various git versions ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/949/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/819/ : SUCCESS -- To view, visit https://review.coreboot.org/22971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ee8d4d54db48f7207fe8abf895c7fbba7685ad2 Gerrit-Change-Number: 22971 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Dec 2017 01:13:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: [WIP] git-hooks: Fix install script for various git versions
by Nico Huber (Code Review) 22 Dec '17

22 Dec '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/22971 Change subject: [WIP] git-hooks: Fix install script for various git versions ...................................................................... [WIP] git-hooks: Fix install script for various git versions Change-Id: I7ee8d4d54db48f7207fe8abf895c7fbba7685ad2 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M util/git-hooks/install.sh 1 file changed, 15 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/71/22971/1 diff --git a/util/git-hooks/install.sh b/util/git-hooks/install.sh index d557c2f..44ccc94 100755 --- a/util/git-hooks/install.sh +++ b/util/git-hooks/install.sh @@ -3,10 +3,23 @@ root=$(git rev-parse --show-cdup 2>/dev/null) || \ { echo "Not under git control. Cannot install git hooks." >&2 ; exit 0 ; } -dst="${root}"$(git rev-parse --git-path hooks/) src=util/git-hooks/ # relative to root hooks=$(cd "${root}${src}" && git ls-files -c | grep -Ev 'install.sh|wrapper.sh') +if [ $(git rev-parse --git-path 2>/dev/null) = "--git-path" ]; then + # very old git, we have to guess + dst="${root}.git/hooks/" + rel="../../" +elif [ $(cd "${root}${src}" && git rev-parse --git-path .) = \ + $(cd "${root}" && git rev-parse --git-path .) ]; then + # broken --git-path + dst="${root}"$(git rev-parse --git-path hooks/) + rel=$(git rev-parse --prefix $(git rev-parse --git-path hooks/) --show-cdup) +else + dst=$(git rev-parse --git-path hooks/) + rel=$(git rev-parse --prefix "${dst}" --show-cdup) +fi + for h in $hooks; do # Test if hook is not already installed, i.e. doesn't point at the wrapper if [ ! "${dst}$h" -ef "${root}${src}wrapper.sh" ]; then @@ -14,7 +27,6 @@ if [ -e "${dst}$h" ]; then mv "${dst}$h" "${dst}$h.local" fi - ln -s "$(git rev-parse --prefix $(git rev-parse --git-path hooks/) --show-cdup)${src}wrapper.sh" \ - "${dst}$h" + ln -s "${rel}${src}wrapper.sh" "${dst}$h" fi done -- To view, visit https://review.coreboot.org/22971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7ee8d4d54db48f7207fe8abf895c7fbba7685ad2 Gerrit-Change-Number: 22971 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[1.0.x]: spi: Define _XOPEN_SOURCE to get ffs() from strings.h
by build bot (Jenkins) (Code Review) 21 Dec '17

21 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22951 ) Change subject: spi: Define _XOPEN_SOURCE to get ffs() from strings.h ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/flashrom-customrules/948/ : SUCCESS -- To view, visit https://review.coreboot.org/22951 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-MessageType: comment Gerrit-Change-Id: I92b69300a302c4491e234666ac371027571801c9 Gerrit-Change-Number: 22951 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Dec 2017 10:59:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[1.0.x]: spi: Define _XOPEN_SOURCE to get ffs() from strings.h
by Nico Huber (Code Review) 21 Dec '17

21 Dec '17

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/22951 ) Change subject: spi: Define _XOPEN_SOURCE to get ffs() from strings.h ...................................................................... spi: Define _XOPEN_SOURCE to get ffs() from strings.h Fixes build with Musl libc. Change-Id: I92b69300a302c4491e234666ac371027571801c9 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/22951 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> --- M spi.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve David Hendricks: Looks good to me, approved diff --git a/spi.c b/spi.c index 894f73f..c306ac3 100644 --- a/spi.c +++ b/spi.c @@ -22,6 +22,8 @@ * Contains the generic SPI framework */ +#define _XOPEN_SOURCE 700 /* for ffs() */ + #include <strings.h> #include <string.h> #include "flash.h" -- To view, visit https://review.coreboot.org/22951 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-MessageType: merged Gerrit-Change-Id: I92b69300a302c4491e234666ac371027571801c9 Gerrit-Change-Number: 22951 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[1.0.x]: spi: Define _XOPEN_SOURCE to get ffs() from strings.h
by David Hendricks (Code Review) 21 Dec '17

21 Dec '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22951 ) Change subject: spi: Define _XOPEN_SOURCE to get ffs() from strings.h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/22951 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-MessageType: comment Gerrit-Change-Id: I92b69300a302c4491e234666ac371027571801c9 Gerrit-Change-Number: 22951 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Dec 2017 06:22:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[1.0.x]: spi: Define _XOPEN_SOURCE to get ffs() from strings.h
by Paul Menzel (Code Review) 20 Dec '17

20 Dec '17

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/22951 ) Change subject: spi: Define _XOPEN_SOURCE to get ffs() from strings.h ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/22951 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-MessageType: comment Gerrit-Change-Id: I92b69300a302c4491e234666ac371027571801c9 Gerrit-Change-Number: 22951 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 20 Dec 2017 05:13:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit December 2017