October 2017 - flashrom-gerrit

Change in flashrom[staging]: fixup! Convert flashrom to git
by David Hendricks (Code Review) 01 Oct '17

01 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21827 ) Change subject: fixup! Convert flashrom to git ...................................................................... Patch Set 1: Code-Review-1 (2 comments) A couple of nits, otherwise LGTM. https://review.coreboot.org/#/c/21827/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/21827/1//COMMIT_MSG@7 PS1, Line 7: fixup! Convert flashrom to git Same comment as before - This isn't really a fixup, it's just changing something that already exists and works fine. https://review.coreboot.org/#/c/21827/1//COMMIT_MSG@13 PS1, Line 13: ith with -- To view, visit https://review.coreboot.org/21827 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Iedc9df4c033a70447b8b1b65c83764c769b02c3f Gerrit-Change-Number: 21827 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 21:43:08 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[refs/meta/config]: +/-2 for stefanct, exclusive tag pushes for flashrom devs
by build bot (Jenkins) (Code Review) 01 Oct '17

01 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21835 ) Change subject: +/-2 for stefanct, exclusive tag pushes for flashrom devs ...................................................................... Patch Set 2: Build Failed https://qa.coreboot.org/job/flashrom-customrules/633/ : FAILURE https://qa.coreboot.org/job/flashrom_gerrit/578/ : FAILURE -- To view, visit https://review.coreboot.org/21835 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: comment Gerrit-Change-Id: Ib0e0fbeab6227876b5d54351ee32b0e4c3649a11 Gerrit-Change-Number: 21835 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 21:42:11 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[refs/meta/config]: +/-2 for stefanct, exclusive tag pushes for flashrom devs
by Stefan Tauner (Code Review) 01 Oct '17

01 Oct '17

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21835 to look at the new patch set (#2). Change subject: +/-2 for stefanct, exclusive tag pushes for flashrom devs ...................................................................... +/-2 for stefanct, exclusive tag pushes for flashrom devs Change-Id: Ib0e0fbeab6227876b5d54351ee32b0e4c3649a11 --- M project.config 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/35/21835/2 -- To view, visit https://review.coreboot.org/21835 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib0e0fbeab6227876b5d54351ee32b0e4c3649a11 Gerrit-Change-Number: 21835 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: fixup! Convert flashrom to git
by David Hendricks (Code Review) 01 Oct '17

01 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21826 ) Change subject: fixup! Convert flashrom to git ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/21826/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/21826/1//COMMIT_MSG@7 PS1, Line 7: fixup! Convert flashrom to git This isn't really a fixup. It's just a slight modification to something that already exists and works fine. -- To view, visit https://review.coreboot.org/21826 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ie57b20dc014ba44ded5783bdb432eb7d0e0e28ad Gerrit-Change-Number: 21826 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 21:40:07 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: fixup! Convert flashrom to git
by build bot (Jenkins) (Code Review) 01 Oct '17

01 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21837 ) Change subject: fixup! Convert flashrom to git ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom-customrules/632/ : FAILURE https://qa.coreboot.org/job/flashrom_gerrit/577/ : SUCCESS -- To view, visit https://review.coreboot.org/21837 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I2f84d9db2ec3247f313573c5fcd8b9b758ab9d96 Gerrit-Change-Number: 21837 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 20:41:17 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: fixup! Convert flashrom to git
by Stefan Tauner (Code Review) 01 Oct '17

01 Oct '17

Stefan Tauner has uploaded this change for review. ( https://review.coreboot.org/21837 Change subject: fixup! Convert flashrom to git ...................................................................... fixup! Convert flashrom to git - Change shortcut for getrevision's --url function from U to u. There is no reason for it to be a capital letter, is there? Change-Id: I2f84d9db2ec3247f313573c5fcd8b9b758ab9d96 --- M util/getrevision.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/37/21837/1 diff --git a/util/getrevision.sh b/util/getrevision.sh index cdd9b73..d92991d 100755 --- a/util/getrevision.sh +++ b/util/getrevision.sh @@ -159,7 +159,7 @@ test if path is under version control at all -r or --revision return unique revision information - -U or --url + -u or --url URL associated with the latest commit -d or --date date of most recent modification @@ -187,7 +187,7 @@ -h|--help) action=show_help; shift;; - -U|--url) + -u|--url) check_action $1 action=scm_url shift;; -- To view, visit https://review.coreboot.org/21837 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: I2f84d9db2ec3247f313573c5fcd8b9b758ab9d96 Gerrit-Change-Number: 21837 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at>

1 0

Change in flashrom[staging]: fixup! Convert flashrom to git
by build bot (Jenkins) (Code Review) 01 Oct '17

01 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21836 ) Change subject: fixup! Convert flashrom to git ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom-customrules/631/ : FAILURE https://qa.coreboot.org/job/flashrom_gerrit/576/ : SUCCESS -- To view, visit https://review.coreboot.org/21836 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Iac3bf11fbd55cfa034ef8af04ef90fe57182ee2b Gerrit-Change-Number: 21836 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 20:11:33 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: fixup! Convert flashrom to git
by Stefan Tauner (Code Review) 01 Oct '17

01 Oct '17

Stefan Tauner has uploaded this change for review. ( https://review.coreboot.org/21836 Change subject: fixup! Convert flashrom to git ...................................................................... fixup! Convert flashrom to git without the upcache there is no "offline" version (yet). Change-Id: Iac3bf11fbd55cfa034ef8af04ef90fe57182ee2b --- M Makefile 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/36/21836/1 diff --git a/Makefile b/Makefile index 4484fc8..5eb9c9e 100644 --- a/Makefile +++ b/Makefile @@ -533,10 +533,6 @@ VERSION ?= $(shell ./util/getrevision.sh --revision) MAN_DATE ?= $(shell ./util/getrevision.sh --date $(PROGRAM).8.tmpl 2>/dev/null) -# VERSION equals "offline" if online access is required but the respective git config variable is not set yet. -ifeq ($(VERSION),offline) - $(error Aborting) -endif SCMDEF := -D'FLASHROM_VERSION="$(VERSION)"' # No spaces in release names unless set explicitly -- To view, visit https://review.coreboot.org/21836 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: Iac3bf11fbd55cfa034ef8af04ef90fe57182ee2b Gerrit-Change-Number: 21836 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at>

1 0

Change in flashrom[staging]: fixup! Convert flashrom to git
by David Hendricks (Code Review) 01 Oct '17

01 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21826 ) Change subject: fixup! Convert flashrom to git ...................................................................... Patch Set 1: Code-Review+2 I'm not 100% sold on the name change since the purpose of the file is to provide info in lieu of VCS availability, so it sounds kind of contradictory. Maybe "Makefile.metadata"? I don't have a particularly strong opinion about this, though. -- To view, visit https://review.coreboot.org/21826 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ie57b20dc014ba44ded5783bdb432eb7d0e0e28ad Gerrit-Change-Number: 21826 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 19:41:14 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: fixup! Convert flashrom to git
by Stefan Tauner (Code Review) 01 Oct '17

01 Oct '17

Stefan Tauner has posted comments on this change. ( https://review.coreboot.org/21824 ) Change subject: fixup! Convert flashrom to git ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/21824 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I9d0fe93291de81b4d303589fd01565f429a61e9a Gerrit-Change-Number: 21824 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 19:38:40 +0000 Gerrit-HasComments: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2017