October 2017 - flashrom-gerrit

Change in flashrom[staging]: fixup! Convert flashrom to git
by David Hendricks (Code Review) 01 Oct '17

01 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21830 ) Change subject: fixup! Convert flashrom to git ...................................................................... Patch Set 1: Code-Review+1 commit message doesn't really matter in this case -- To view, visit https://review.coreboot.org/21830 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I0c66f2508cc754cf9219211a06d6f305a32c422d Gerrit-Change-Number: 21830 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 23:22:26 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: fixup! Convert flashrom to git
by David Hendricks (Code Review) 01 Oct '17

01 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21829 ) Change subject: fixup! Convert flashrom to git ...................................................................... Patch Set 1: Code-Review+1 commit message doesn't really matter in this case -- To view, visit https://review.coreboot.org/21829 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I6689ac24077b3981b471ed69de7cc3ef79d435b1 Gerrit-Change-Number: 21829 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 23:21:38 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: fixup! Convert flashrom to git
by David Hendricks (Code Review) 01 Oct '17

01 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21827 ) Change subject: fixup! Convert flashrom to git ...................................................................... Patch Set 1: Code-Review+1 Commit message will supposedly be squashed out of existence. -- To view, visit https://review.coreboot.org/21827 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Iedc9df4c033a70447b8b1b65c83764c769b02c3f Gerrit-Change-Number: 21827 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 23:20:13 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: fixup! Convert flashrom to git
by David Hendricks (Code Review) 01 Oct '17

01 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21837 ) Change subject: fixup! Convert flashrom to git ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/21837/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/21837/1//COMMIT_MSG@10 PS1, Line 10: There is no reason for it to be a capital letter, is there? There was a (now obsolete) -u/--upstream function. I don't see a particular reason to change this, but I also don't have a strong opinion here. -- To view, visit https://review.coreboot.org/21837 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I2f84d9db2ec3247f313573c5fcd8b9b758ab9d96 Gerrit-Change-Number: 21837 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 23:14:07 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: fixup! Convert flashrom to git
by David Hendricks (Code Review) 01 Oct '17

01 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21832 ) Change subject: fixup! Convert flashrom to git ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21832 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I2f2d7ae58dcd7d3e55959e18fe664df10bc3cc41 Gerrit-Change-Number: 21832 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 22:49:10 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: dediprog: Reimplement target chip option
by Stefan Tauner (Code Review) 01 Oct '17

01 Oct '17

Stefan Tauner has posted comments on this change. ( https://review.coreboot.org/21780 ) Change subject: dediprog: Reimplement target chip option ...................................................................... Patch Set 1: The commit message needs improvement. It is unclear why this patch is needed: because the target/chipselect was broken since r1896 aka 557eb4f. -- To view, visit https://review.coreboot.org/21780 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: I94576967e2892e08295daa829caabace5a367fa0 Gerrit-Change-Number: 21780 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 22:45:39 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: fixup! Convert flashrom to git
by David Hendricks (Code Review) 01 Oct '17

01 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21831 ) Change subject: fixup! Convert flashrom to git ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21831 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I0e931fbb5902d2714d5399c1d1bfac0de35523bb Gerrit-Change-Number: 21831 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 22:27:28 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: fixup! Convert flashrom to git
by David Hendricks (Code Review) 01 Oct '17

01 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21830 ) Change subject: fixup! Convert flashrom to git ...................................................................... Patch Set 1: Code-Review-1 (2 comments) Mostly looks good, aside from a couple small issues with the commit message. As I mentioned in a previous patch, I don't like the long comments. But that's an issue we can resolve another time. https://review.coreboot.org/#/c/21830/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/21830/1//COMMIT_MSG@7 PS1, Line 7: fixup! Convert flashrom to git Not a fixup. https://review.coreboot.org/#/c/21830/1//COMMIT_MSG@10 PS1, Line 10: expend expand? -- To view, visit https://review.coreboot.org/21830 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I0c66f2508cc754cf9219211a06d6f305a32c422d Gerrit-Change-Number: 21830 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 22:02:23 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: fixup! Convert flashrom to git
by David Hendricks (Code Review) 01 Oct '17

01 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21829 ) Change subject: fixup! Convert flashrom to git ...................................................................... Patch Set 1: Code-Review-1 (1 comment) LGTM, aside from the commit message. https://review.coreboot.org/#/c/21829/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/21829/1//COMMIT_MSG@7 PS1, Line 7: fixup! Convert flashrom to git Not a fixup. -- To view, visit https://review.coreboot.org/21829 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I6689ac24077b3981b471ed69de7cc3ef79d435b1 Gerrit-Change-Number: 21829 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 21:54:52 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: fixup! Convert flashrom to git
by David Hendricks (Code Review) 01 Oct '17

01 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/21828 ) Change subject: fixup! Convert flashrom to git ...................................................................... Patch Set 1: Code-Review+2 (1 comment) LGTM with trivial fix to commit message. https://review.coreboot.org/#/c/21828/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/21828/1//COMMIT_MSG@9 PS1, Line 9: a add -- To view, visit https://review.coreboot.org/21828 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ia60186f783067ba084439a8ef701dc8f4c0072f0 Gerrit-Change-Number: 21828 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 21:48:42 +0000 Gerrit-HasComments: Yes

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit October 2017