flashrom

flashrom@flashrom.org

5 participants
9161 discussions

Gigabyte GA-6VXE7 revision 3.0
by Nicholas Adrian 03 Nov '10

03 Nov '10

Your paste can be seen at http://paste.flashrom.org/view.php?id=174 Your upload can be seen at http://paste.flashrom.org/view.php?id=175 This is to verify that erase is working on this board.

1 0

ASRock ALiveXFire-eSATA2 rev 3.0
by Kjell Braden 02 Nov '10

02 Nov '10

Hi, I've got a new ASRock AliveXFire-eSATA2 rev 3.0 board. Chip/chipset are detected fine but erasing doesn't seem to work. Most relevant parts of the logs: Detection: **** snip **** Found chipset "AMD SB600", enabling flash write... OK. This chipset supports the following protocols: LPC,FWH. Found chip "Winbond W39V040(F)C" (512 KB, LPC) at physical address 0xfff80000. === This flash part has status UNTESTED for operations: PROBE READ ERASE WRITE **** snip **** Read/Verify works fine. Erase: **** snip **** Erasing flash chip... Looking at blockwise erase function 0... trying... 0x000000-0x00ffff, ERASE FAILED at 0x00007408! Expected=0xff, Read=0x48, failed byte count from 0x00000000-0x0000ffff: 0x891b ERASE FAILED! Looking at blockwise erase function 1... trying... 0x000000-0x07ffff, ERASE FAILED at 0x00007408! Expected=0xff, Read=0x48, failed byte count from 0x00000000-0x0007ffff: 0x679cd ERASE FAILED! Looking at blockwise erase function 2... not defined. Looking for another erase function. Looking at blockwise erase function 3... not defined. Looking for another erase function. Looking at blockwise erase function 4... not defined. Looking for another erase function. Looking at blockwise erase function 5... not defined. Looking for another erase function. FAILED! **** snip **** Verify succeeds afterwards, the board is still perfectly fine. Let me know if you need any more information or testing. Regards, Kjell

1 0

Re: [flashrom] [v2] DediProg: support for firmware version 5.1.5
by Patrick Georgi 02 Nov '10

02 Nov '10

Hi, the above mentioned patch by Mathias Krause (http://patchwork.coreboot.org/patch/2178/) looks good. I didn't test it, but it's a good improvement over the original, relatively static code to test the device's firmware version. So, Acked-by: Patrick Georgi <patrick(a)georgi-clan.de> Regards, Patrick

1 0

PSA (Public Service Announcement): Please test partial writes.
by David Hendricks 02 Nov '10

02 Nov '10

Hello everyone, Carl-Daniel recently posted what will likely be the final patch in the "Real partial writes" thread. The patch has many benefits, but also carries some risk. There's a fair amount of core logic being changed and we'd really appreciate any/all testing and code reviews. If you're feeling up for it, please head over to http://patchwork.coreboot.org/project/flashrom/list/ and grab the latest "Real partial writes" patch! We now have test script in the util/ directory that you may use to automatically test partial writes. Simple usage is as easy as building flashrom with the patch, cd'ing to the util/ directory, and running the flashrom_partial_write_test.sh script. The patch should go in soon, so it's important to find any show stoppers. Heck, even after the patch goes in it would be great for folks to run the script and let us know if anything looks suspicious. Thanks, and sorry for the PSA spam! -- David Hendricks (dhendrix) Systems Software Engineer, Google Inc.

1 0

[PATCH] Change image building in layout code
by Carl-Daniel Hailfinger 02 Nov '10

02 Nov '10

Change semantics of image building in the layout code. If a layout file was specified, all regions not mentioned in the layout file were taken from the new image instead of being preserved. If regions overlap, the non-included regions won. New behaviour: If a layout file is specified, only the regions explicitly requested for inclusion will be taken from the new image. If regions overlap, the included regions win. The following alternatives exist: - Warn if regions overlap - Warn if a layout file does not cover the whole chip Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-layout_exclude_unspecified_regions/layout.c =================================================================== --- flashrom-layout_exclude_unspecified_regions/layout.c (revision 1217) +++ flashrom-layout_exclude_unspecified_regions/layout.c (working copy) @@ -22,6 +22,7 @@ #include <stdlib.h> #include <string.h> #include <ctype.h> +#include <limits.h> #include "flash.h" #include "programmer.h" @@ -205,33 +206,62 @@ return -1; } -int handle_romentries(struct flashchip *flash, uint8_t *oldcontents, uint8_t *newcontents) +int find_next_included_romentry(unsigned int start) { int i; + unsigned int best_start = INT_MAX; + int best_entry = -1; - // This function does not save flash write cycles. - // - // Also it does not cope with overlapping rom layout - // sections. - // example: - // 00000000:00008fff gfxrom - // 00009000:0003ffff normal - // 00040000:0007ffff fallback - // 00000000:0007ffff all - // - // If you'd specify -i all the included flag of all other - // sections is still 0, so no changes will be made to the - // flash. Same thing if you specify -i normal -i all only - // normal will be updated and the rest will be kept. - + /* First come, first serve for overlapping regions. */ for (i = 0; i < romimages; i++) { - if (rom_entries[i].included) + if (!rom_entries[i].included) continue; + /* Already past the current entry? */ + if (start > rom_entries[i].end) + continue; + /* Inside the current entry? */ + if (start >= rom_entries[i].start) + return i; + /* Entry begins after start. */ + if (best_start > rom_entries[i].start) { + best_start = rom_entries[i].start; + best_entry = i; + } + } + return best_entry; +} - memcpy(newcontents + rom_entries[i].start, - oldcontents + rom_entries[i].start, - rom_entries[i].end - rom_entries[i].start + 1); +int handle_romentries(struct flashchip *flash, uint8_t *oldcontents, uint8_t *newcontents) +{ + unsigned int start = 0; + int entry; + unsigned int size = flash->total_size * 1024; + + /* If no layout file was specified or the layout file was empty, assume + * that the user wants to flash the complete new image. + */ + if (!romimages) + return 0; + /* Non-included romentries are ignored. + * The union of all included romentries is used from the new image. + */ + while (start < size) { + entry = find_next_included_romentry(start); + /* No more romentries for remaining region? */ + if (entry < 0) { + memcpy(newcontents + start, oldcontents + start, + size - start); + break; + } + if (rom_entries[entry].start > start) + memcpy(newcontents + start, oldcontents + start, + rom_entries[entry].start - start); + /* Skip to location after current romentry. */ + start = rom_entries[entry].end + 1; + /* Catch overflow. */ + if (!start) + break; } - + return 0; } -- http://www.hailfinger.org/

2 2

[commit] r1223 - trunk
by repository service 02 Nov '10

02 Nov '10

Author: hailfinger Date: Tue Nov 2 04:12:51 2010 New Revision: 1223 URL: http://flashrom.org/trac/flashrom/changeset/1223 Log: Change semantics of image building in the layout code. If a layout file was specified, all regions not mentioned in the layout file were taken from the new image instead of being preserved. If regions overlap, the non-included regions won. New behaviour: If a layout file is specified, only the regions explicitly requested for inclusion will be taken from the new image. If regions overlap, the included regions win. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: David Hendricks <dhendrix(a)google.com> Modified: trunk/layout.c Modified: trunk/layout.c ============================================================================== --- trunk/layout.c Tue Nov 2 04:03:38 2010 (r1222) +++ trunk/layout.c Tue Nov 2 04:12:51 2010 (r1223) @@ -22,6 +22,7 @@ #include <stdlib.h> #include <string.h> #include <ctype.h> +#include <limits.h> #include "flash.h" #include "programmer.h" @@ -205,33 +206,62 @@ return -1; } -int handle_romentries(struct flashchip *flash, uint8_t *oldcontents, uint8_t *newcontents) +int find_next_included_romentry(unsigned int start) { int i; + unsigned int best_start = UINT_MAX; + int best_entry = -1; - // This function does not save flash write cycles. - // - // Also it does not cope with overlapping rom layout - // sections. - // example: - // 00000000:00008fff gfxrom - // 00009000:0003ffff normal - // 00040000:0007ffff fallback - // 00000000:0007ffff all - // - // If you'd specify -i all the included flag of all other - // sections is still 0, so no changes will be made to the - // flash. Same thing if you specify -i normal -i all only - // normal will be updated and the rest will be kept. - + /* First come, first serve for overlapping regions. */ for (i = 0; i < romimages; i++) { - if (rom_entries[i].included) + if (!rom_entries[i].included) continue; - - memcpy(newcontents + rom_entries[i].start, - oldcontents + rom_entries[i].start, - rom_entries[i].end - rom_entries[i].start + 1); + /* Already past the current entry? */ + if (start > rom_entries[i].end) + continue; + /* Inside the current entry? */ + if (start >= rom_entries[i].start) + return i; + /* Entry begins after start. */ + if (best_start > rom_entries[i].start) { + best_start = rom_entries[i].start; + best_entry = i; + } } + return best_entry; +} + +int handle_romentries(struct flashchip *flash, uint8_t *oldcontents, uint8_t *newcontents) +{ + unsigned int start = 0; + int entry; + unsigned int size = flash->total_size * 1024; + /* If no layout file was specified or the layout file was empty, assume + * that the user wants to flash the complete new image. + */ + if (!romimages) + return 0; + /* Non-included romentries are ignored. + * The union of all included romentries is used from the new image. + */ + while (start < size) { + entry = find_next_included_romentry(start); + /* No more romentries for remaining region? */ + if (entry < 0) { + memcpy(newcontents + start, oldcontents + start, + size - start); + break; + } + if (rom_entries[entry].start > start) + memcpy(newcontents + start, oldcontents + start, + rom_entries[entry].start - start); + /* Skip to location after current romentry. */ + start = rom_entries[entry].end + 1; + /* Catch overflow. */ + if (!start) + break; + } + return 0; }

1 0

[patch] print test status in partial write test script
by David Hendricks 02 Nov '10

02 Nov '10

We were a bit too aggressive in trimming superfluous print messages earlier on. This patch adds a line of output for each iteration of the while loops in the test. The intention is to give the user something useful to indicate test progress without just printing a ton of debug spew. Maybe a future patch can redirect more verbose info to a log file. The output looks like this:: localhost ~ # FLASHROM="./flashrom" sh flashrom_partial_write_test.sh testing flashrom binary: ./flashrom Running test in /tmp/tmp.4xPejwaADU ffh pattern written in ff_4k.bin 00h pattern written in 00_4k.bin Reading BIOS image Original image saved as bios.bin aligned region 0 test: passed ... aligned region 15 test: passed unaligned region 0 test: passed ... unaligned region 15 test: passed Result: PASSED restoring original bios image using system's flashrom test files remain in /tmp/tmp.4xPejwaADU Signed-off-by: David Hendricks <dhendrix(a)google.com> -- David Hendricks (dhendrix) Systems Software Engineer, Google Inc.

2 3

[commit] r1222 - trunk/util
by repository service 02 Nov '10

02 Nov '10

Author: hailfinger Date: Tue Nov 2 04:03:38 2010 New Revision: 1222 URL: http://flashrom.org/trac/flashrom/changeset/1222 Log: Add a line of output for each iteration of the torture test. This serves as a sort of progress indicator. The output looks like this:: localhost ~ # FLASHROM="./flashrom" sh flashrom_partial_write_test.sh testing flashrom binary: ./flashrom Running test in /tmp/tmp.4xPejwaADU ffh pattern written in ff_4k.bin 00h pattern written in 00_4k.bin Reading BIOS image Original image saved as bios.bin aligned region 0 test: passed ... aligned region 15 test: passed unaligned region 0 test: passed ... unaligned region 15 test: passed Result: PASSED restoring original bios image using system's flashrom test files remain in /tmp/tmp.4xPejwaADU Signed-off-by: David Hendricks <dhendrix(a)google.com> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/util/flashrom_partial_write_test.sh Modified: trunk/util/flashrom_partial_write_test.sh ============================================================================== --- trunk/util/flashrom_partial_write_test.sh Tue Nov 2 01:16:27 2010 (r1221) +++ trunk/util/flashrom_partial_write_test.sh Tue Nov 2 04:03:38 2010 (r1222) @@ -92,6 +92,12 @@ # $1: exit code do_exit() { + if [ ${1} -eq ${EXIT_FAILURE} ] ; then + echo "Result: FAILED" + else + echo "Result: PASSED" + fi + echo "restoring original bios image using system's flashrom" flashrom ${FLASHROM_PARAM} -w "$BIOS" echo "test files remain in ${TMPDIR}" @@ -159,14 +165,14 @@ cp "$BIOS" "$TESTFILE" i=0 while [ $i -lt $NUM_REGIONS ] ; do + echo -n "aligned region ${i} test: " offset=$((${i} * 8192)) dd if=${ZERO_4K} of=${TESTFILE} bs=1 conv=notrunc seek=${offset} 2> /dev/null dd if=${FF_4K} of=${TESTFILE} bs=1 conv=notrunc seek=$((${offset} + 4096)) 2> /dev/null ./flashrom ${FLASHROM_PARAM} -l layout_4k_aligned.txt -i 00_${i} -i ff_${i} -w "$TESTFILE" > /dev/null if [ "$?" != "0" ] ; then - echo "partial flash failed on iteration ${i}" - echo "Result: FAIL" + echo "failed to flash region" do_exit "$EXIT_FAILURE" fi @@ -175,13 +181,13 @@ flashrom ${FLASHROM_PARAM} -r difftest.bin > /dev/null diff -q difftest.bin "$TESTFILE" if [ "$?" != "0" ] ; then - echo "diff test failed on iteration ${i}" - echo "Result: FAIL" + echo "failed diff test" do_exit "$EXIT_FAILURE" fi rm -f difftest.bin i=$((${i} + 1)) + echo "passed" done # Make a layout - 4K regions on 4.5K boundaries. This will help find problems @@ -245,11 +251,13 @@ " > layout_unaligned.txt # reset the test file and ROM to the original state -flashrom ${FLASHROM_PARAM} -w "$BIOS" +flashrom ${FLASHROM_PARAM} -w "$BIOS" > /dev/null cp "$BIOS" "$TESTFILE" i=0 while [ $i -lt $NUM_REGIONS ] ; do + echo -n "unaligned region ${i} test: " + offset=$(($((${i} * 8192)) + 2048)) # Protect against too long write writelen=4096 @@ -264,8 +272,7 @@ ./flashrom ${FLASHROM_PARAM} -l layout_unaligned.txt -i 00_${i} -i ff_${i} -w "$TESTFILE" > /dev/null if [ "$?" != "0" ] ; then - echo "partial flash failed on iteration ${i}" - echo "Result: FAIL" + echo "failed to flash region" do_exit "$EXIT_FAILURE" fi @@ -274,14 +281,13 @@ flashrom ${FLASHROM_PARAM} -r difftest.bin > /dev/null diff -q difftest.bin "$TESTFILE" if [ "$?" != "0" ] ; then - echo "diff test failed on iteration ${i}" - echo "Result: FAIL" + echo "failed diff test" do_exit "$EXIT_FAILURE" fi rm -f difftest.bin i=$((${i} + 1)) + echo "passed" done -echo "Result: PASS" do_exit "$EXIT_SUCCESS"

1 0

[PATCH] Torture script fixes
by Carl-Daniel Hailfinger 02 Nov '10

02 Nov '10

Use mktemp unconditionally for security reasons. Avoid non-portable seq. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-torturescript_portability/util/flashrom_partial_write_test.sh =================================================================== --- flashrom-torturescript_portability/util/flashrom_partial_write_test.sh (Revision 1219) +++ flashrom-torturescript_portability/util/flashrom_partial_write_test.sh (Arbeitskopie) @@ -34,8 +34,12 @@ echo "testing flashrom binary: ${FLASHROM}" OLDDIR=$(pwd) -if [ -z "$TMPDIR" ]; then - TMPDIR=$(mktemp -d) # test data location + +# test data location +TMPDIR=$(mktemp -d -t flashrom_test.XXXXXXXXXX) +if [ "$?" != "0" ] ; then + echo "Could not create temporary directory" + exit $EXIT_FAILURE fi ZERO_4K="00_4k.bin" @@ -65,8 +69,10 @@ # Make 4k worth of 0xff bytes echo "begin 640 $FF_4K" > "$FF_4K_TEXT" -for i in `seq 0 90` ; do +i=0 +while [ $i -le 90 ] ; do echo "M____________________________________________________________" >> "$FF_4K_TEXT" + i=$((${i} + 1)) done echo "!_P``" >> "$FF_4K_TEXT" echo "\`" >> "$FF_4K_TEXT" -- http://www.hailfinger.org/

4 5

[commit] r1221 - trunk/util
by repository service 02 Nov '10

02 Nov '10

Author: hailfinger Date: Tue Nov 2 01:16:27 2010 New Revision: 1221 URL: http://flashrom.org/trac/flashrom/changeset/1221 Log: Use mktemp unconditionally for security reasons. Avoid non-portable seq. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Idwer Vollering <vidwer(a)gmail.com> Modified: trunk/util/flashrom_partial_write_test.sh Modified: trunk/util/flashrom_partial_write_test.sh ============================================================================== --- trunk/util/flashrom_partial_write_test.sh Mon Nov 1 23:07:04 2010 (r1220) +++ trunk/util/flashrom_partial_write_test.sh Tue Nov 2 01:16:27 2010 (r1221) @@ -34,8 +34,12 @@ echo "testing flashrom binary: ${FLASHROM}" OLDDIR=$(pwd) -if [ -z "$TMPDIR" ]; then - TMPDIR=$(mktemp -d) # test data location + +# test data location +TMPDIR=$(mktemp -d -t flashrom_test.XXXXXXXXXX) +if [ "$?" != "0" ] ; then + echo "Could not create temporary directory" + exit $EXIT_FAILURE fi ZERO_4K="00_4k.bin" @@ -65,8 +69,10 @@ # Make 4k worth of 0xff bytes echo "begin 640 $FF_4K" > "$FF_4K_TEXT" -for i in `seq 0 90` ; do +i=0 +while [ $i -le 90 ] ; do echo "M____________________________________________________________" >> "$FF_4K_TEXT" + i=$((${i} + 1)) done echo "!_P``" >> "$FF_4K_TEXT" echo "\`" >> "$FF_4K_TEXT"

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom