flashrom

flashrom@flashrom.org

5 participants
9186 discussions

It is hard to report a bug....
by Sven Anders 20 Jun '11

20 Jun '11

Hi, first I want to thank you for your great work. I would like to use flashrom, to try coreboot. But I have trouble to use flashrom with a "Dell Optiplex" mainboard: -- snip -- flashrom -r flash-file flashrom v0.9.2-r1141 on Linux 2.6.32-5-amd64 (x86_64), built with libpci 3.1.7, GCC 4.4.5 20100728 (prerelease), little endian flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OK. No coreboot table found. Found chipset "Intel ICH8/ICH8R", enabling flash write... tried to set 0xdc to 0x3 on ICH8/ICH8R failed (WARNING ONLY) WARNING: SPI Configuration Lockdown activated. FAILED! This chipset supports the following protocols: FWH,SPI. Found chip "Spansion S25FL008A" (1024 KB, SPI) at physical address 0xfff00000. ich_spi_send_command: Internal command size error for opcode 0xab, got writecnt=4, want =1 Reading flash... Read operation failed! FAILED. -- snap -- I have used the flashrom version from debian squeeze. So I thought: "I should use a newer version" . But when I try to download it from: http://www.flashrom.org/Downloads I have got a page with an error: "Status Code: 404" So I try to open a bug on: http://www.flashrom.org/trac/flashrom/newticket I have spend realy time to put in the right text, but when I pressed "Create Ticket" the Web Page said somethink like, it would be junk and will be discarded, so I have done this work for nothing. So I hope, someone will fix this 3 reported bugs: * Problem with flashrom on a Dell Optiplex * Not working download link. * Not working Issue Tracker (if it should not be used by users, the link to report bugs should be hidden for them) Best Regards Sven Anders

3 8

[PATCH] revamp the warning of failing to set BIOS write enable in enable_flash_ich
by Stefan Tauner 20 Jun '11

20 Jun '11

- introduce a new variable 'wanted' that is used instead of 'new' - use 'new' for the actual value contained in BIOS_CNTL after we tried to write it - rephrase the warning which now also includes the old and new values besides the wanted one Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> --- chipset_enable.c | 14 ++++++++------ 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/chipset_enable.c b/chipset_enable.c index 0c77f07..c36da4f 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -250,7 +250,7 @@ static int enable_flash_piix4(struct pci_dev *dev, const char *name) static int enable_flash_ich(struct pci_dev *dev, const char *name, int bios_cntl) { - uint8_t old, new; + uint8_t old, new, wanted; /* * Note: the ICH0-ICH5 BIOS_CNTL register is actually 16 bit wide, but @@ -274,14 +274,16 @@ static int enable_flash_ich(struct pci_dev *dev, const char *name, msg_pinfo("WARNING: BIOS region SMM protection is enabled!\n"); } - new = old | 1; - if (new == old) + wanted = old | 1; + if (wanted == old) return 0; - rpci_write_byte(dev, bios_cntl, new); + rpci_write_byte(dev, bios_cntl, wanted); - if (pci_read_byte(dev, bios_cntl) != new) { - msg_pinfo("tried to set 0x%x to 0x%x on %s failed (WARNING ONLY)\n", bios_cntl, new, name); + if ((new = pci_read_byte(dev, bios_cntl)) != wanted) { + msg_pinfo("WARNING: Setting 0x%x from 0x%x to 0x%x on %s " + "failed. New value is 0x%x.\n", + bios_cntl, old, wanted, name, new); return -1; } -- 1.7.1

1 0

Success report : WRITE for W29C020
by Pete Batard 19 Jun '11

19 Jun '11

Hi, Was advised to send a write report for this chip, so I tested all possible operations, using a W29C020-12 on a Freetech P6F91i motherboard, and everything works brilliantly. Logs attached. By the way, even if this is a very old board, I'll just point out that if you ever want to convert a 1Mb BIOS P6F91i to a 2Mb BIOS one, you just need to place a jumper between pins 2 and 3 of JP1 to have the extra address line (being mindful that pin 1 of that jumper is 12V and must be left alone). Regards, /Pete

2 3

[PATCH] Remove sharplhf00l04.c
by Michael Karcher 19 Jun '11

19 Jun '11

The currently unreferenced function in sharplhf00l04.c does a standard FWH block protection reset (writes 0 to the protection register) and a standard FWH block erase. The locking blocks of the FWH block lock cover 128KB areas, and thats the only thing page_size is used for in the functions referenced in the LHF00L04 entry. Finally, this adds a comment that there are non-volatile (flash memory) lock bits for 8 sectors in the last 64KB. They are write-only and clearable at once. Readback seems unsupported. Signed-off-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> --- Makefile | 2 +- flashchips.c | 5 ++- sharplhf00l04.c | 58 ------------------------------------------------------- 3 files changed, 4 insertions(+), 61 deletions(-) delete mode 100644 sharplhf00l04.c diff --git a/Makefile b/Makefile index 6e6e2de..470d944 100644 --- a/Makefile +++ b/Makefile @@ -119,7 +119,7 @@ endif CHIP_OBJS = jedec.o stm50flw0x0x.o w39.o w29ee011.o \ sst28sf040.o m29f400bt.o 82802ab.o pm49fl00x.o \ - sst49lfxxxc.o sst_fwhub.o flashchips.o spi.o spi25.o sharplhf00l04.o \ + sst49lfxxxc.o sst_fwhub.o flashchips.o spi.o spi25.o \ a25.o at25.o LIB_OBJS = layout.o diff --git a/flashchips.c b/flashchips.c index 865ba2f..4514985 100644 --- a/flashchips.c +++ b/flashchips.c @@ -5151,7 +5151,7 @@ const struct flashchip flashchips[] = { .manufacture_id = SHARP_ID, .model_id = SHARP_LHF00L04, .total_size = 1024, - .page_size = 64 * 1024, + .page_size = 128 * 1024, .feature_bits = FEATURE_EITHER_RESET | FEATURE_REGISTERMAP, .tested = TEST_UNTESTED, .probe = probe_82802ab, @@ -5171,7 +5171,8 @@ const struct flashchip flashchips[] = { .block_erase = NULL, /* 30 D0, only in A/A mux mode */ }, }, - .unlock = unlock_82802ab, + .unlock = unlock_82802ab, /* additionally, there are write-only non-volatile + boot block protection bits per 8K sector*/ .write = write_82802ab, .read = read_memmapped, .voltage = {3000, 3600}, diff --git a/sharplhf00l04.c b/sharplhf00l04.c deleted file mode 100644 index f21950a..0000000 --- a/sharplhf00l04.c +++ /dev/null @@ -1,58 +0,0 @@ -/* - * This file is part of the flashrom project. - * - * Copyright (C) 2000 Silicon Integrated System Corporation - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA - */ - -#include "flash.h" -#include "chipdrivers.h" - -/* FIXME: The datasheet is unclear whether we should use toggle_ready_jedec - * or wait_82802ab. - * FIXME: This file is unused. - */ - -int erase_lhf00l04_block(struct flashchip *flash, unsigned int blockaddr, unsigned int blocklen) -{ - chipaddr bios = flash->virtual_memory + blockaddr; - chipaddr wrprotect = flash->virtual_registers + blockaddr + 2; - uint8_t status; - - // clear status register - chip_writeb(0x50, bios); - status = wait_82802ab(flash); - print_status_82802ab(status); - // clear write protect - msg_cspew("write protect is at 0x%lx\n", (wrprotect)); - msg_cspew("write protect is 0x%x\n", chip_readb(wrprotect)); - chip_writeb(0, wrprotect); - msg_cspew("write protect is 0x%x\n", chip_readb(wrprotect)); - - // now start it - chip_writeb(0x20, bios); - chip_writeb(0xd0, bios); - programmer_delay(10); - // now let's see what the register is - status = wait_82802ab(flash); - print_status_82802ab(status); - - if (check_erased_range(flash, blockaddr, blocklen)) { - msg_cerr("ERASE FAILED!\n"); - return -1; - } - return 0; -} -- 1.7.5.3

1 0

[PATCH] Flush stdout after each message
by Ed Swierk 19 Jun '11

19 Jun '11

Currently messages like "Writing flash chip..." that don't end with a newline are buffered until the operation is complete, unless the particular write function generates status output in the meantime. Flushing stdout after each message ensures that the message appears immediately. Signed-off-by: Ed Swierk <eswierk(a)aristanetworks.com> --- Index: flashrom-0.9.2-r1057/cli_output.c =================================================================== --- flashrom-0.9.2-r1057.orig/cli_output.c +++ flashrom-0.9.2-r1057/cli_output.c @@ -47,5 +47,6 @@ int print(int type, const char *fmt, ... va_start(ap, fmt); ret = vfprintf(output_type, fmt, ap); va_end(ap); + fflush(output_type); return ret; }

4 4

[PATCH] Support for K7S41GX.
by Paweł Różański 19 Jun '11

19 Jun '11

Hello. During discussion on IRC channel found out, that K7S41GX uses the same bios chip and the same super I/O chip as K7S41. Tested reading, writing and verification, all worked fine. Signed-off-by: Pawel Rozanski <rozie(a)poczta.onet.pl> BTW for K7S41 match string is "^K7S41 $", probably should be "^K7S41$", but cannot test it. Regards, Pawel Rozanski

2 2

Re: [flashrom] [PATCH] Print FWH chip status only if something is wrong
by Stefan Tauner 19 Jun '11

19 Jun '11

On Sun, 19 Jun 2011 22:49:15 +0200 Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> wrote: > This is especially important for the SST FWH compatible chips with 4K sector > size, where status printing for that small size was omitted up to r1347. > > Signed-off-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> > --- > - print_status_82802ab(status); > + if (status != 0x80) /* Ready, no error bits */ > + print_status_82802ab(status); for my mind the comments are inverted. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

[PATCH 1/2] Various fixes for building as a payload.
by Tadas Slotkus 19 Jun '11

19 Jun '11

Signed-off-by: Tadas Slotkus <devtadas(a)gmail.com> --- Makefile | 7 ++++++- cli_classic.c | 6 +++++- flash.h | 6 +++++- flashrom.c | 6 ++++++ layout.c | 6 ++++-- nicintel.c | 2 ++ sst49lfxxxc.c | 3 +-- 7 files changed, 29 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index 6e6e2de..fbfbd2f 100644 --- a/Makefile +++ b/Makefile @@ -37,6 +37,9 @@ ifeq ($(WARNERROR), yes) CFLAGS += -Werror endif +# Uncomment this if you want to build for libpayload +# OS_ARCH = libpayload + # FIXME We have to differentiate between host and target arch. OS_ARCH ?= $(shell uname) ifneq ($(OS_ARCH), SunOS) @@ -85,7 +88,7 @@ endif endif ifeq ($(OS_ARCH), libpayload) -CC:=CC=i386-elf-gcc lpgcc +CC:=../libpayload/install/libpayload/bin/lpgcc AR:=i386-elf-ar RANLIB:=i386-elf-ranlib CPPFLAGS += -DSTANDALONE @@ -361,7 +364,9 @@ ifeq ($(OS_ARCH), DOS) # FIXME There needs to be a better way to do this LIBS += ../libpci/lib/libpci.a else +ifneq ($(OS_ARCH), libpayload) LIBS += -lpci +endif ifeq ($(OS_ARCH), OpenBSD) # For (i386|amd64)_iopl(2). LIBS += -l$(shell uname -m) diff --git a/cli_classic.c b/cli_classic.c index d1b4686..f102433 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -22,8 +22,10 @@ */ #include <stdio.h> +#ifndef __LIBPAYLOAD__ #include <fcntl.h> #include <sys/stat.h> +#endif #include <string.h> #include <stdlib.h> #include <getopt.h> @@ -150,12 +152,14 @@ int cli_classic(int argc, char *argv[]) if (selfcheck()) exit(1); +#ifndef __LIBPAYLOAD__ setbuf(stdout, NULL); +#endif /* FIXME: Delay all operation_specified checks until after command * line parsing to allow --help overriding everything else. */ while ((opt = getopt_long(argc, argv, optstring, - long_options, &option_index)) != EOF) { + long_options, &option_index)) != -1) { switch (opt) { case 'r': if (++operation_specified > 1) { diff --git a/flash.h b/flash.h index 3247700..2d7457e 100644 --- a/flash.h +++ b/flash.h @@ -32,7 +32,11 @@ #undef min #undef max #endif - +#ifdef __LIBPAYLOAD__ +#undef __linux__ +#define fprintf(stream, ...) printf(__VA_ARGS__) +#define vfprintf(output_type, fmt, ap) vprintf(fmt, ap) +#endif #define ERROR_PTR ((void*)-1) /* Error codes */ diff --git a/flashrom.c b/flashrom.c index e9e6a77..b145037 100644 --- a/flashrom.c +++ b/flashrom.c @@ -26,6 +26,8 @@ #ifndef __LIBPAYLOAD__ #include <fcntl.h> #include <sys/stat.h> +#else +#include <libpayload.h> #endif #include <string.h> #include <stdlib.h> @@ -1234,6 +1236,7 @@ int verify_flash(struct flashchip *flash, uint8_t *buf) int read_buf_from_file(unsigned char *buf, unsigned long size, char *filename) { +#ifndef __LIBPAYLOAD__ unsigned long numbytes; FILE *image; struct stat image_stat; @@ -1262,11 +1265,13 @@ int read_buf_from_file(unsigned char *buf, unsigned long size, char *filename) "wanted %ld!\n", numbytes, size); return 1; } +#endif return 0; } int write_buf_to_file(unsigned char *buf, unsigned long size, char *filename) { +#ifndef __LIBPAYLOAD__ unsigned long numbytes; FILE *image; @@ -1286,6 +1291,7 @@ int write_buf_to_file(unsigned char *buf, unsigned long size, char *filename) filename); return 1; } +#endif return 0; } diff --git a/layout.c b/layout.c index d719a05..c5a0245 100644 --- a/layout.c +++ b/layout.c @@ -136,9 +136,9 @@ int show_id(uint8_t *bios, int size, int force) } #endif -#ifndef __LIBPAYLOAD__ int read_romlayout(char *name) { +#ifndef __LIBPAYLOAD__ FILE *romlayout; char tempstr[256]; int i; @@ -191,8 +191,10 @@ int read_romlayout(char *name) fclose(romlayout); return 0; -} +#else + return -1; #endif +} int find_romentry(char *name) { diff --git a/nicintel.c b/nicintel.c index 3d53ec8..b88597a 100644 --- a/nicintel.c +++ b/nicintel.c @@ -23,6 +23,8 @@ #include "flash.h" #include "programmer.h" +#define PCI_VENDOR_ID_INTEL 0x8086 + uint8_t *nicintel_bar; uint8_t *nicintel_control_bar; diff --git a/sst49lfxxxc.c b/sst49lfxxxc.c index 046b9f3..5299c6e 100644 --- a/sst49lfxxxc.c +++ b/sst49lfxxxc.c @@ -61,13 +61,12 @@ int unlock_49lfxxxc(struct flashchip *flash) int erase_sector_49lfxxxc(struct flashchip *flash, unsigned int address, unsigned int sector_size) { - uint8_t status; chipaddr bios = flash->virtual_memory; chip_writeb(0x30, bios); chip_writeb(0xD0, bios + address); - status = wait_82802ab(flash); + wait_82802ab(flash); if (check_erased_range(flash, address, sector_size)) { msg_cerr("ERASE FAILED!\n"); -- 1.7.0.4

3 4

Re: [flashrom] [PATCH] Don't ignore wait_82802ab() return value
by Stefan Reinauer 19 Jun '11

19 Jun '11

On 5/14/10 3:06 PM, Michael Karcher wrote: > Am Freitag, den 14.05.2010, 14:48 +0200 schrieb Stefan Reinauer: > >> On 4/16/10 6:21 PM, Stefan Reinauer wrote: >> >>> Look at the return value of wait_82802ab() >>> Index: sst49lfxxxc.c >>> =================================================================== >>> --- sst49lfxxxc.c (revision 993) >>> +++ sst49lfxxxc.c (working copy) >>> @@ -84,6 +84,7 @@ >>> chip_writeb(0xD0, bios + address); >>> >>> status = wait_82802ab(bios); >>> + print_status_82802ab(status); >>> > [...] > basically a good idea, but printing one status dump per erased block > seems a bit excessive, even in verbose mode, as there are some chips > with 4K sector size. Could you limit status printing to "status != > 0x80", as this is "ready, no error bits"? > That's what the 82802ab and sharp lhf00l04 do, too. So if you think the behavior should be changed, you should change it in all three places. Stefan

4 4

[patch] successfully testing ST M25P128
by Cristian Măgherușan-Stanciu 19 Jun '11

19 Jun '11

Hello, I just got this new chip soldered thanks to Peter Stuge, and here's a test run result. Found chip "ST M25P128" (16384 kB, SPI) at physical address 0xff000000. Erasing and writing flash chip... Done. Verifying flash... VERIFIED. The patch to mark it as verified in the flashrom source code is listed below. This is Signed-off-by: Cristian Măgherușan-Stanciu <cristi.magherusan(a)gmail.com> Index: flashchips.c =================================================================== --- flashchips.c (revision 1345) +++ flashchips.c (working copy) @@ -6705,7 +6705,7 @@ .model_id = ST_M25P128, .total_size = 16384, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers =

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom