flashrom

flashrom@flashrom.org

5 participants
9161 discussions

[PATCH] Support for K7S41GX.
by Paweł Różański 20 Jun '11

20 Jun '11

Hello. During discussion on IRC channel found out, that K7S41GX uses the same bios chip and the same super I/O chip as K7S41. Tested reading, writing and verification, all worked fine. Signed-off-by: Pawel Rozanski <rozie(a)poczta.onet.pl> BTW for K7S41 match string is "^K7S41 $", probably should be "^K7S41$", but cannot test it. Regards, Pawel Rozanski

2 2

Re: [flashrom] [PATCH] Print FWH chip status only if something is wrong
by Stefan Tauner 20 Jun '11

20 Jun '11

On Sun, 19 Jun 2011 22:49:15 +0200 Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> wrote: > This is especially important for the SST FWH compatible chips with 4K sector > size, where status printing for that small size was omitted up to r1347. > > Signed-off-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> > --- > - print_status_82802ab(status); > + if (status != 0x80) /* Ready, no error bits */ > + print_status_82802ab(status); for my mind the comments are inverted. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

[PATCH 1/2] Various fixes for building as a payload.
by Tadas Slotkus 19 Jun '11

19 Jun '11

Signed-off-by: Tadas Slotkus <devtadas(a)gmail.com> --- Makefile | 7 ++++++- cli_classic.c | 6 +++++- flash.h | 6 +++++- flashrom.c | 6 ++++++ layout.c | 6 ++++-- nicintel.c | 2 ++ sst49lfxxxc.c | 3 +-- 7 files changed, 29 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index 6e6e2de..fbfbd2f 100644 --- a/Makefile +++ b/Makefile @@ -37,6 +37,9 @@ ifeq ($(WARNERROR), yes) CFLAGS += -Werror endif +# Uncomment this if you want to build for libpayload +# OS_ARCH = libpayload + # FIXME We have to differentiate between host and target arch. OS_ARCH ?= $(shell uname) ifneq ($(OS_ARCH), SunOS) @@ -85,7 +88,7 @@ endif endif ifeq ($(OS_ARCH), libpayload) -CC:=CC=i386-elf-gcc lpgcc +CC:=../libpayload/install/libpayload/bin/lpgcc AR:=i386-elf-ar RANLIB:=i386-elf-ranlib CPPFLAGS += -DSTANDALONE @@ -361,7 +364,9 @@ ifeq ($(OS_ARCH), DOS) # FIXME There needs to be a better way to do this LIBS += ../libpci/lib/libpci.a else +ifneq ($(OS_ARCH), libpayload) LIBS += -lpci +endif ifeq ($(OS_ARCH), OpenBSD) # For (i386|amd64)_iopl(2). LIBS += -l$(shell uname -m) diff --git a/cli_classic.c b/cli_classic.c index d1b4686..f102433 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -22,8 +22,10 @@ */ #include <stdio.h> +#ifndef __LIBPAYLOAD__ #include <fcntl.h> #include <sys/stat.h> +#endif #include <string.h> #include <stdlib.h> #include <getopt.h> @@ -150,12 +152,14 @@ int cli_classic(int argc, char *argv[]) if (selfcheck()) exit(1); +#ifndef __LIBPAYLOAD__ setbuf(stdout, NULL); +#endif /* FIXME: Delay all operation_specified checks until after command * line parsing to allow --help overriding everything else. */ while ((opt = getopt_long(argc, argv, optstring, - long_options, &option_index)) != EOF) { + long_options, &option_index)) != -1) { switch (opt) { case 'r': if (++operation_specified > 1) { diff --git a/flash.h b/flash.h index 3247700..2d7457e 100644 --- a/flash.h +++ b/flash.h @@ -32,7 +32,11 @@ #undef min #undef max #endif - +#ifdef __LIBPAYLOAD__ +#undef __linux__ +#define fprintf(stream, ...) printf(__VA_ARGS__) +#define vfprintf(output_type, fmt, ap) vprintf(fmt, ap) +#endif #define ERROR_PTR ((void*)-1) /* Error codes */ diff --git a/flashrom.c b/flashrom.c index e9e6a77..b145037 100644 --- a/flashrom.c +++ b/flashrom.c @@ -26,6 +26,8 @@ #ifndef __LIBPAYLOAD__ #include <fcntl.h> #include <sys/stat.h> +#else +#include <libpayload.h> #endif #include <string.h> #include <stdlib.h> @@ -1234,6 +1236,7 @@ int verify_flash(struct flashchip *flash, uint8_t *buf) int read_buf_from_file(unsigned char *buf, unsigned long size, char *filename) { +#ifndef __LIBPAYLOAD__ unsigned long numbytes; FILE *image; struct stat image_stat; @@ -1262,11 +1265,13 @@ int read_buf_from_file(unsigned char *buf, unsigned long size, char *filename) "wanted %ld!\n", numbytes, size); return 1; } +#endif return 0; } int write_buf_to_file(unsigned char *buf, unsigned long size, char *filename) { +#ifndef __LIBPAYLOAD__ unsigned long numbytes; FILE *image; @@ -1286,6 +1291,7 @@ int write_buf_to_file(unsigned char *buf, unsigned long size, char *filename) filename); return 1; } +#endif return 0; } diff --git a/layout.c b/layout.c index d719a05..c5a0245 100644 --- a/layout.c +++ b/layout.c @@ -136,9 +136,9 @@ int show_id(uint8_t *bios, int size, int force) } #endif -#ifndef __LIBPAYLOAD__ int read_romlayout(char *name) { +#ifndef __LIBPAYLOAD__ FILE *romlayout; char tempstr[256]; int i; @@ -191,8 +191,10 @@ int read_romlayout(char *name) fclose(romlayout); return 0; -} +#else + return -1; #endif +} int find_romentry(char *name) { diff --git a/nicintel.c b/nicintel.c index 3d53ec8..b88597a 100644 --- a/nicintel.c +++ b/nicintel.c @@ -23,6 +23,8 @@ #include "flash.h" #include "programmer.h" +#define PCI_VENDOR_ID_INTEL 0x8086 + uint8_t *nicintel_bar; uint8_t *nicintel_control_bar; diff --git a/sst49lfxxxc.c b/sst49lfxxxc.c index 046b9f3..5299c6e 100644 --- a/sst49lfxxxc.c +++ b/sst49lfxxxc.c @@ -61,13 +61,12 @@ int unlock_49lfxxxc(struct flashchip *flash) int erase_sector_49lfxxxc(struct flashchip *flash, unsigned int address, unsigned int sector_size) { - uint8_t status; chipaddr bios = flash->virtual_memory; chip_writeb(0x30, bios); chip_writeb(0xD0, bios + address); - status = wait_82802ab(flash); + wait_82802ab(flash); if (check_erased_range(flash, address, sector_size)) { msg_cerr("ERASE FAILED!\n"); -- 1.7.0.4

3 4

Re: [flashrom] [PATCH] Don't ignore wait_82802ab() return value
by Stefan Reinauer 19 Jun '11

19 Jun '11

On 5/14/10 3:06 PM, Michael Karcher wrote: > Am Freitag, den 14.05.2010, 14:48 +0200 schrieb Stefan Reinauer: > >> On 4/16/10 6:21 PM, Stefan Reinauer wrote: >> >>> Look at the return value of wait_82802ab() >>> Index: sst49lfxxxc.c >>> =================================================================== >>> --- sst49lfxxxc.c (revision 993) >>> +++ sst49lfxxxc.c (working copy) >>> @@ -84,6 +84,7 @@ >>> chip_writeb(0xD0, bios + address); >>> >>> status = wait_82802ab(bios); >>> + print_status_82802ab(status); >>> > [...] > basically a good idea, but printing one status dump per erased block > seems a bit excessive, even in verbose mode, as there are some chips > with 4K sector size. Could you limit status printing to "status != > 0x80", as this is "ready, no error bits"? > That's what the 82802ab and sharp lhf00l04 do, too. So if you think the behavior should be changed, you should change it in all three places. Stefan

4 4

[patch] successfully testing ST M25P128
by Cristian Măgherușan-Stanciu 19 Jun '11

19 Jun '11

Hello, I just got this new chip soldered thanks to Peter Stuge, and here's a test run result. Found chip "ST M25P128" (16384 kB, SPI) at physical address 0xff000000. Erasing and writing flash chip... Done. Verifying flash... VERIFIED. The patch to mark it as verified in the flashrom source code is listed below. This is Signed-off-by: Cristian Măgherușan-Stanciu <cristi.magherusan(a)gmail.com> Index: flashchips.c =================================================================== --- flashchips.c (revision 1345) +++ flashchips.c (working copy) @@ -6705,7 +6705,7 @@ .model_id = ST_M25P128, .total_size = 16384, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers =

2 1

[PATCH] flashchips.c: Typo. s/don't/doesn't/
by Paul Menzel 19 Jun '11

19 Jun '11

Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- flashchips.c | 52 ++++++++++++++++++++++++++-------------------------- 1 files changed, 26 insertions(+), 26 deletions(-) diff --git a/flashchips.c b/flashchips.c index a82c373..70a4ff1 100644 --- a/flashchips.c +++ b/flashchips.c @@ -155,7 +155,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_ADDR_2AA | FEATURE_SHORT_RESET, .tested = TEST_UNTESTED, .probe = probe_jedec, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (am29f040b.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (am29f040b.c) */ .block_erasers = { { @@ -181,7 +181,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_ADDR_2AA | FEATURE_SHORT_RESET, .tested = TEST_UNTESTED, .probe = probe_jedec, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (am29f040b.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (am29f040b.c) */ .block_erasers = { { @@ -233,7 +233,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_ADDR_2AA | FEATURE_SHORT_RESET, .tested = TEST_UNTESTED, .probe = probe_jedec, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (am29f040b.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (am29f040b.c) */ .block_erasers = { { @@ -259,7 +259,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_ADDR_2AA | FEATURE_SHORT_RESET, .tested = TEST_UNTESTED, .probe = probe_jedec, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (am29f040b.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (am29f040b.c) */ .block_erasers = { { @@ -1230,7 +1230,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_ADDR_2AA | FEATURE_SHORT_RESET, .tested = TEST_UNTESTED, .probe = probe_jedec, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (mx29f002.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (mx29f002.c) */ .block_erasers = { { @@ -1261,7 +1261,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_ADDR_2AA | FEATURE_SHORT_RESET, .tested = TEST_OK_PRW, .probe = probe_jedec, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (mx29f002.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (mx29f002.c) */ .block_erasers = { { @@ -1292,7 +1292,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_ADDR_2AA | FEATURE_SHORT_RESET, .tested = TEST_UNTESTED, .probe = probe_jedec, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (am29f040b.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (am29f040b.c) */ .block_erasers = { { @@ -2280,7 +2280,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_ADDR_SHIFTED | FEATURE_EITHER_RESET, .tested = TEST_UNTESTED, .probe = probe_m29f400bt, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (m29f400bt.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (m29f400bt.c) */ .block_erasers = { { @@ -2311,7 +2311,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_ADDR_SHIFTED | FEATURE_EITHER_RESET, .tested = TEST_UNTESTED, .probe = probe_m29f400bt, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (m29f400bt.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (m29f400bt.c) */ .block_erasers = { { @@ -2931,7 +2931,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_ADDR_2AA | FEATURE_SHORT_RESET, .tested = TEST_UNTESTED, .probe = probe_jedec, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (mx29f002.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (mx29f002.c) */ .block_erasers = { { @@ -2963,7 +2963,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_ADDR_2AA | FEATURE_SHORT_RESET, .tested = TEST_UNTESTED, .probe = probe_jedec, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (mx29f002.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (mx29f002.c) */ .block_erasers = { { @@ -2995,7 +2995,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_ADDR_2AA | FEATURE_SHORT_RESET, .tested = TEST_UNTESTED, .probe = probe_jedec, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (mx29f002.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (mx29f002.c) */ .block_erasers = { { @@ -3026,7 +3026,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_ADDR_2AA | FEATURE_SHORT_RESET, .tested = TEST_OK_PRW, .probe = probe_jedec, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (mx29f002.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (mx29f002.c) */ .block_erasers = { { @@ -3057,7 +3057,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_ADDR_2AA | FEATURE_SHORT_RESET, .tested = TEST_UNTESTED, .probe = probe_jedec, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (mx29f002.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (mx29f002.c) */ .block_erasers = { { @@ -3917,7 +3917,7 @@ struct flashchip flashchips[] = { .feature_bits = 0, .tested = TEST_UNTESTED, .probe = probe_82802ab, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (sst28sf040.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (sst28sf040.c) */ .block_erasers = { { @@ -4368,7 +4368,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_UNTESTED, .probe = probe_82802ab, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (sst49lfxxxc.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (sst49lfxxxc.c) */ .block_erasers = { { @@ -4431,7 +4431,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_UNTESTED, .probe = probe_82802ab, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (sst49lfxxxc.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (sst49lfxxxc.c) */ .block_erasers = { { @@ -4463,7 +4463,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_OK_PRW, .probe = probe_82802ab, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (sst49lfxxxc.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (sst49lfxxxc.c) */ .block_erasers = { { @@ -4640,7 +4640,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_OK_PRW, .probe = probe_82802ab, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (sst49lfxxxc.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (sst49lfxxxc.c) */ .block_erasers = { { @@ -5040,7 +5040,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_ADDR_2AA | FEATURE_EITHER_RESET, .tested = TEST_UNTESTED, .probe = probe_jedec, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (am29f040b.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (am29f040b.c) */ .block_erasers = { { @@ -5067,7 +5067,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_ADDR_SHIFTED | FEATURE_EITHER_RESET, .tested = TEST_UNTESTED, .probe = probe_m29f400bt, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (m29f400bt.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (m29f400bt.c) */ .block_erasers = { { @@ -5313,7 +5313,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_UNTESTED, .probe = probe_82802ab, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (sst49lfxxxc.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (sst49lfxxxc.c) */ .block_erasers = { { @@ -5345,7 +5345,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_UNTESTED, .probe = probe_82802ab, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (82802ab.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (82802ab.c) */ .block_erasers = { { @@ -5372,7 +5372,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_OK_PR, .probe = probe_82802ab, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (82802ab.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (82802ab.c) */ .block_erasers = { { @@ -5399,7 +5399,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_OK_PR, .probe = probe_82802ab, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (82802ab.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (82802ab.c) */ .block_erasers = { { @@ -6010,7 +6010,7 @@ struct flashchip flashchips[] = { .feature_bits = FEATURE_LONG_RESET, .tested = TEST_OK_PRW, .probe = probe_w29ee011, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (w29ee011.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (w29ee011.c) */ .block_erasers = { { -- 1.7.1

3 3

[commit] r1349 - trunk
by repository service 19 Jun '11

19 Jun '11

Author: uwe Date: Sun Jun 19 19:27:57 2011 New Revision: 1349 URL: http://flashrom.org/trac/flashrom/changeset/1349 Log: Currently messages like "Writing flash chip..." that don't end with a newline are buffered until the operation is complete, unless the particular write function generates status output in the meantime. Flushing stdout after each message ensures that the message appears immediately. Signed-off-by: Ed Swierk <eswierk(a)aristanetworks.com> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/cli_output.c Modified: trunk/cli_output.c ============================================================================== --- trunk/cli_output.c Sun Jun 19 19:23:55 2011 (r1348) +++ trunk/cli_output.c Sun Jun 19 19:27:57 2011 (r1349) @@ -47,5 +47,6 @@ va_start(ap, fmt); ret = vfprintf(output_type, fmt, ap); va_end(ap); + fflush(output_type); return ret; }

1 0

[commit] r1348 - trunk
by repository service 19 Jun '11

19 Jun '11

Author: uwe Date: Sun Jun 19 19:23:55 2011 New Revision: 1348 URL: http://flashrom.org/trac/flashrom/changeset/1348 Log: flashchips.c: Fix typo: s/don't/doesn't/. Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/flashchips.c Modified: trunk/flashchips.c ============================================================================== --- trunk/flashchips.c Sun Jun 19 19:09:49 2011 (r1347) +++ trunk/flashchips.c Sun Jun 19 19:23:55 2011 (r1348) @@ -3360,7 +3360,7 @@ .feature_bits = FEATURE_ADDR_SHIFTED | FEATURE_EITHER_RESET, .tested = TEST_UNTESTED, .probe = probe_m29f400bt, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (m29f400bt.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (m29f400bt.c) */ .block_erasers = { { @@ -3392,7 +3392,7 @@ .feature_bits = FEATURE_ADDR_SHIFTED | FEATURE_EITHER_RESET, .tested = TEST_UNTESTED, .probe = probe_m29f400bt, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (m29f400bt.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (m29f400bt.c) */ .block_erasers = { { @@ -5622,7 +5622,7 @@ .feature_bits = 0, .tested = TEST_UNTESTED, .probe = probe_82802ab, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (sst28sf040.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (sst28sf040.c) */ .block_erasers = { { @@ -6091,7 +6091,7 @@ .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_UNTESTED, .probe = probe_82802ab, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (sst49lfxxxc.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (sst49lfxxxc.c) */ .block_erasers = { { @@ -6156,7 +6156,7 @@ .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_UNTESTED, .probe = probe_82802ab, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (sst49lfxxxc.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (sst49lfxxxc.c) */ .block_erasers = { { @@ -6189,7 +6189,7 @@ .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_OK_PR, .probe = probe_82802ab, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (sst49lfxxxc.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (sst49lfxxxc.c) */ .block_erasers = { { @@ -6373,7 +6373,7 @@ .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_OK_PRE, .probe = probe_82802ab, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (sst49lfxxxc.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (sst49lfxxxc.c) */ .block_erasers = { { @@ -6946,7 +6946,7 @@ .feature_bits = FEATURE_ADDR_SHIFTED | FEATURE_EITHER_RESET, .tested = TEST_UNTESTED, .probe = probe_m29f400bt, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (m29f400bt.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (m29f400bt.c) */ .block_erasers = { { @@ -7188,7 +7188,7 @@ .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_UNTESTED, .probe = probe_82802ab, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (sst49lfxxxc.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (sst49lfxxxc.c) */ .block_erasers = { { @@ -7218,7 +7218,7 @@ .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_UNTESTED, .probe = probe_82802ab, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (82802ab.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (82802ab.c) */ .block_erasers = { { @@ -7243,7 +7243,7 @@ .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_OK_PR, .probe = probe_82802ab, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (82802ab.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (82802ab.c) */ .block_erasers = { { @@ -7268,7 +7268,7 @@ .feature_bits = FEATURE_REGISTERMAP, .tested = TEST_OK_PREW, .probe = probe_82802ab, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (82802ab.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (82802ab.c) */ .block_erasers = { { @@ -8091,7 +8091,7 @@ .feature_bits = FEATURE_LONG_RESET, .tested = TEST_OK_PRE, .probe = probe_w29ee011, - .probe_timing = TIMING_IGNORED, /* routine don't use probe_timing (w29ee011.c) */ + .probe_timing = TIMING_IGNORED, /* routine doesn't use probe_timing (w29ee011.c) */ .block_erasers = { {

1 0

[commit] r1347 - trunk
by repository service 19 Jun '11

19 Jun '11

Author: uwe Date: Sun Jun 19 19:09:49 2011 New Revision: 1347 URL: http://flashrom.org/trac/flashrom/changeset/1347 Log: Look at the return value of wait_82802ab(). Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/sst49lfxxxc.c Modified: trunk/sst49lfxxxc.c ============================================================================== --- trunk/sst49lfxxxc.c Sun Jun 19 18:52:48 2011 (r1346) +++ trunk/sst49lfxxxc.c Sun Jun 19 19:09:49 2011 (r1347) @@ -68,6 +68,7 @@ chip_writeb(0xD0, bios + address); status = wait_82802ab(flash); + print_status_82802ab(status); if (check_erased_range(flash, address, sector_size)) { msg_cerr("ERASE FAILED!\n");

1 0

[commit] r1346 - trunk
by repository service 19 Jun '11

19 Jun '11

Author: uwe Date: Sun Jun 19 18:52:48 2011 New Revision: 1346 URL: http://flashrom.org/trac/flashrom/changeset/1346 Log: Add ASRock K7S41GX board-enable. Tested reading, writing and verification, all worked fine. Signed-off-by: Pawel Rozanski <rozie(a)poczta.onet.pl> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/board_enable.c trunk/print.c Modified: trunk/board_enable.c ============================================================================== --- trunk/board_enable.c Sun Jun 19 00:56:14 2011 (r1345) +++ trunk/board_enable.c Sun Jun 19 18:52:48 2011 (r1346) @@ -391,6 +391,7 @@ * - MSI MS-6561 (745 Ultra): SiS 745 + W83697HF * - MSI MS-6787 (P4MAM-V/P4MAM-L): VIA P4M266 + VT8235 * - ASRock K7S41: SiS 741 + SiS 963 + W83697HF + * - ASRock K7S41GX: SiS 741GX + SiS 963L + W83697HF */ static int w836xx_memw_enable_2e(void) { @@ -1980,6 +1981,7 @@ {0x1022, 0x2090, 0, 0, 0x1022, 0x2080, 0, 0, NULL, "artecgroup", "dbe62", P3, "Artec Group", "DBE62", 0, OK, board_artecgroup_dbe6x}, {0x8086, 0x277c, 0xa0a0, 0x060b, 0x8086, 0x27da, 0xa0a0, 0x060b, NULL, NULL, NULL, P3, "AOpen", "i975Xa-YDG", 0, OK, board_aopen_i975xa_ydg}, {0x1039, 0x0741, 0x1849, 0x0741, 0x1039, 0x5513, 0x1849, 0x5513, "^K7S41 $", NULL, NULL, P3, "ASRock", "K7S41", 0, OK, w836xx_memw_enable_2e}, + {0x1039, 0x0741, 0x1849, 0x0741, 0x1039, 0x5513, 0x1849, 0x5513, "^K7S41GX$", NULL, NULL, P3, "ASRock", "K7S41GX", 0, OK, w836xx_memw_enable_2e}, {0x8086, 0x24D4, 0x1849, 0x24D0, 0x8086, 0x24D5, 0x1849, 0x9739, NULL, NULL, NULL, P3, "ASRock", "P4i65GV", 0, OK, intel_ich_gpio23_raise}, {0x8086, 0x2570, 0x1849, 0x2570, 0x8086, 0x24d3, 0x1849, 0x24d0, NULL, NULL, NULL, P3, "ASRock", "775i65G", 0, OK, intel_ich_gpio23_raise}, {0x1106, 0x3189, 0x1043, 0x807F, 0x1106, 0x3065, 0x1043, 0x80ED, NULL, NULL, NULL, P3, "ASUS", "A7V600-X", 0, OK, it8712f_gpio3_1_raise}, Modified: trunk/print.c ============================================================================== --- trunk/print.c Sun Jun 19 00:56:14 2011 (r1345) +++ trunk/print.c Sun Jun 19 18:52:48 2011 (r1346) @@ -400,6 +400,7 @@ B("ASRock", "A770CrossFire", 1, "http://www.asrock.com/mb/overview.asp?Model=A770CrossFire&s=AM2%%2b", NULL), B("ASRock", "ALiveNF6G-DVI", 1, "http://www.asrock.com/mb/overview.asp?Model=ALiveNF6G-DVI", NULL), B("ASRock", "K7S41", 1, "http://www.asrock.com/mb/overview.asp?Model=K7S41", NULL), + B("ASRock", "K7S41GX", 1, "http://www.asrock.com/mb/overview.asp?Model=K7S41GX", NULL), B("ASRock", "K7VT4A+", 0, "http://www.asrock.com/mb/overview.asp?Model=K7VT4A%%2b&s=", "No chip found, probably due to flash translation. http://www.flashrom.org/pipermail/flashrom/2009-August/000393.html"), B("ASRock", "K8S8X", 1, "http://www.asrock.com/mb/overview.asp?Model=K8S8X", NULL), B("ASRock", "M3A790GXH/128M", 1, "http://www.asrock.com/MB/overview.asp?Model=M3A790GXH/128M", NULL),

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom