Author: stefanct
Date: Mon Jun 2 02:45:57 2014
New Revision: 1816
URL: http://flashrom.org/trac/flashrom/changeset/1816
Log:
print_wiki.c: refine header and include a legend explaining the test state representation.
Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at>
Acked-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at>
Modified:
trunk/print_wiki.c
Modified: trunk/print_wiki.c
==============================================================================
--- trunk/print_wiki.c Mon Jun 2 02:34:58 2014 (r1815)
+++ trunk/print_wiki.c Mon Jun 2 02:45:57 2014 (r1816)
@@ -29,11 +29,33 @@
static const char wiki_header[] = "= Supported devices =\n\n\
<div style=\"margin-top:0.5em; padding:0.5em 0.5em 0.5em 0.5em; \
-background-color:#eeeeee; text-align:right; border:1px solid #aabbcc;\">\
+background-color:#eeeeee; text-align:left; border:1px solid #aabbcc;\">\
<small>\n\
-Please do '''not''' edit these tables in the wiki directly, they are \
-generated by pasting '''flashrom -z''' output.<br />\
-'''Last update:''' %s(generated by flashrom %s)\n</small></div>\n";
+'''Last update:''' %s(generated by flashrom %s)<br />\n\
+The tables below are generated from flashrom's source by copying the output of '''flashrom -z'''.<br /><br />\n\
+A short explanation of the cells representing the support state follows:<br />\n\
+{| border=\"0\" valign=\"top\"\n\
+! style=\"text-align:left;\" |\n\
+! style=\"text-align:left;\" |\n\
+|-\n\
+|{{OK}}\n\
+| The feature was '''tested and should work''' in general unless there is a bug in flashrom or another component in \
+the system prohibits some functionality.\n\
+|-\n\
+|{{Dep}}\n\
+| '''Configuration-dependent'''. The feature was tested and should work in general but there are common \
+configurations that drastically limit flashrom's capabilities or make it completely stop working.\n\
+|-\n\
+|{{?3}}\n\
+| The feature is '''untested''' but believed to be working.\n\
+|-\n\
+|{{NA}}\n\
+| The feature is '''not applicable''' in this configuration (e.g. write operations on ROM chips).\n\
+|-\n\
+|{{No}}\n\
+| The feature is '''known to not work'''. Don't bother testing (nor reporting. Patches welcome! ;).\n\
+|}\n\
+</small></div>\n";
static const char th_start[] = "| valign=\"top\"|\n\n\
{| border=\"0\" style=\"font-size: smaller\" valign=\"top\"\n\
Am 30.05.2014 05:15 schrieb Stefan Tauner:
> Mark all ME-enabled Intel chipsets as DEP, alter print.c accordingly
> (print_wiki.c was already prepared).
>
> Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at>
Thanks for your patch!
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net>
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
Am 30.05.2014 00:52 schrieb Stefan Tauner:
> This code exists thanks to food for thought from Urja Rannikko.
>
> Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at>
Interesting, to say the least. The default parameter only applies if -p
is not specified at all, so there are no unexpected side effects. The
only complaint I have (except the question "who would want to use that")
is that you can run
make CONFIG_DEFAULT_PROGRAMMER_ARGS="foobar"
without having to specify CONFIG_DEFAULT_PROGRAMMER as well.
CONFIG_DEFAULT_PROGRAMMER_ARGS won't have any effect in that case during
runtime, but that might surprise someone who specified it.
Hm. Maybe I should really ask who would want to use that... it's
obviously not a feature distributions would use, although it seems some
of them use CONFIG_DEFAULT_PROGRAMMER to keep the behavoir unchanged
compared to previous releases.
Not opposed to it, but not really convinced either.
Regards,
Carl-Daniel
> diff --git a/Makefile b/Makefile
> index 346d46a..998979d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -52,6 +52,11 @@ DOSLIBS_BASE ?= ..
> # evaluated below, namely those that enable/disable the various programmers).
> # Compilation will fail for unspecified values.
> CONFIG_DEFAULT_PROGRAMMER ?= PROGRAMMER_INVALID
> +# The following adds a default parameter for the default programmer set above (only).
> +CONFIG_DEFAULT_PROGRAMMER_ARGS ?= ''
> +# Example: compiling with
> +# make CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_SERPROG CONFIG_DEFAULT_PROGRAMMER_ARGS="dev=/dev/ttyUSB0:1500000"
> +# would make executing './flashrom' (almost) equivialent to './flashrom -p serprog:dev=/dev/ttyUSB0:1500000'.
>
> # If your compiler spits out excessive warnings, run make WARNERROR=no
> # You shouldn't have to change this flag.
> @@ -471,6 +476,7 @@ CONFIG_INTERNAL_DMI ?= yes
> # Depending on the CONFIG_* variables set and verified above we set compiler flags and parameters below.
>
> FEATURE_CFLAGS += -D'CONFIG_DEFAULT_PROGRAMMER=$(CONFIG_DEFAULT_PROGRAMMER)'
> +FEATURE_CFLAGS += -D'CONFIG_DEFAULT_PROGRAMMER_ARGS="$(CONFIG_DEFAULT_PROGRAMMER_ARGS)"'
>
> ifeq ($(CONFIG_INTERNAL), yes)
> FEATURE_CFLAGS += -D'CONFIG_INTERNAL=1'
> diff --git a/cli_classic.c b/cli_classic.c
> index a32d55b..fc1b9ba 100644
> --- a/cli_classic.c
> +++ b/cli_classic.c
> @@ -396,8 +396,10 @@ int main(int argc, char *argv[])
> if (prog == PROGRAMMER_INVALID) {
> if (CONFIG_DEFAULT_PROGRAMMER != PROGRAMMER_INVALID) {
> prog = CONFIG_DEFAULT_PROGRAMMER;
> - msg_pinfo("Using default programmer \"%s\".\n",
> - programmer_table[CONFIG_DEFAULT_PROGRAMMER].name);
> + /* We need to strdup here because we free(pparam) unconditionally later. */
> + pparam = strdup(CONFIG_DEFAULT_PROGRAMMER_ARGS);
> + msg_pinfo("Using default programmer \"%s\" with arguments \"%s\".\n",
> + programmer_table[CONFIG_DEFAULT_PROGRAMMER].name, pparam);
> } else {
> msg_perr("Please select a programmer with the --programmer parameter.\n"
> "Previously this was not necessary because there was a default set.\n"
--
http://www.hailfinger.org/
Author: stefanct
Date: Mon Jun 2 02:12:23 2014
New Revision: 1814
URL: http://flashrom.org/trac/flashrom/changeset/1814
Log:
Add default arguments for the default programmer (only).
This code exists thanks to food for thought from Urja Rannikko.
Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net>
Modified:
trunk/Makefile
trunk/cli_classic.c
Modified: trunk/Makefile
==============================================================================
--- trunk/Makefile Mon Jun 2 01:49:03 2014 (r1813)
+++ trunk/Makefile Mon Jun 2 02:12:23 2014 (r1814)
@@ -52,6 +52,11 @@
# evaluated below, namely those that enable/disable the various programmers).
# Compilation will fail for unspecified values.
CONFIG_DEFAULT_PROGRAMMER ?= PROGRAMMER_INVALID
+# The following adds a default parameter for the default programmer set above (only).
+CONFIG_DEFAULT_PROGRAMMER_ARGS ?= ''
+# Example: compiling with
+# make CONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_SERPROG CONFIG_DEFAULT_PROGRAMMER_ARGS="dev=/dev/ttyUSB0:1500000"
+# would make executing './flashrom' (almost) equivialent to './flashrom -p serprog:dev=/dev/ttyUSB0:1500000'.
# If your compiler spits out excessive warnings, run make WARNERROR=no
# You shouldn't have to change this flag.
@@ -487,6 +492,7 @@
# Depending on the CONFIG_* variables set and verified above we set compiler flags and parameters below.
FEATURE_CFLAGS += -D'CONFIG_DEFAULT_PROGRAMMER=$(CONFIG_DEFAULT_PROGRAMMER)'
+FEATURE_CFLAGS += -D'CONFIG_DEFAULT_PROGRAMMER_ARGS="$(CONFIG_DEFAULT_PROGRAMMER_ARGS)"'
ifeq ($(CONFIG_INTERNAL), yes)
FEATURE_CFLAGS += -D'CONFIG_INTERNAL=1'
Modified: trunk/cli_classic.c
==============================================================================
--- trunk/cli_classic.c Mon Jun 2 01:49:03 2014 (r1813)
+++ trunk/cli_classic.c Mon Jun 2 02:12:23 2014 (r1814)
@@ -396,8 +396,10 @@
if (prog == PROGRAMMER_INVALID) {
if (CONFIG_DEFAULT_PROGRAMMER != PROGRAMMER_INVALID) {
prog = CONFIG_DEFAULT_PROGRAMMER;
- msg_pinfo("Using default programmer \"%s\".\n",
- programmer_table[CONFIG_DEFAULT_PROGRAMMER].name);
+ /* We need to strdup here because we free(pparam) unconditionally later. */
+ pparam = strdup(CONFIG_DEFAULT_PROGRAMMER_ARGS);
+ msg_pinfo("Using default programmer \"%s\" with arguments \"%s\".\n",
+ programmer_table[CONFIG_DEFAULT_PROGRAMMER].name, pparam);
} else {
msg_perr("Please select a programmer with the --programmer parameter.\n"
"Previously this was not necessary because there was a default set.\n"
Am 02.06.2014 00:43 schrieb Stefan Tauner:
> Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at>
Thanks for your patch.
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net>
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
Am 02.06.2014 00:43 schrieb Stefan Tauner:
> This PCI PATA controller can use 3V parallel flash up to 128 kB.
>
> My card was identified as:
> PCI 1283:8212, subsystem 1283:0001.
>
> and labelled as:
> Innovision Multimedia LTD.
> EIO ATA133 RAID
> (DM-8401 Ver A)
>
> This particular card did not require setting of any GPIO signals to
> enable flash writing. My card has Pm39LV512 in PLCC32 package without
> socket.
>
> Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
> Signed-off-by: Stefan Tauner <stefan.tauner(a)alumni.tuwien.ac.at>
Looks good, thanks for your patch!
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net>
Regards,
Carl-Daniel
--
http://www.hailfinger.org/