flashrom July 2011

flashrom@flashrom.org

50 participants
275 discussions

flashrom virtual machine policy?
by Bernd Blaauw 26 Jul '11

26 Jul '11

What's the Flashrom project's stance on virtualisation/emulation combined with using Flashrom? I've only got some experience with VMware Workstation and not much else with others, but how should a FlashROM that's being run in an emulator react? * Programming a BIOS in a VM seems rather impossible as you can't reach hardware, and BIOS is made up of a file on host system that you haven't got access to. * Erasing same issue. * Reading might be considered possible, but doesn't play nicely along with detecting chipsets etc. Anyway for VMware Workstation 7.1 (x64 on Windows 7 Ultimate x64), and flashrom revision 1322 (latest of Idwer's (auto?-)compiled DOS/DJGGP (or openwatcom, I don't know..) binaries: Short version (the empty line is a missing DMIDECOD.EXE): flashrom v0.9.3-r1322 on FreeDOS 7 (i686), built with libpci 3.1.5, GCC 4.3.2, little endian flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OK. Found chipset "Intel PIIX4/4E/4M", enabling flash write... tried to set 0x4e to 0x2d4 on PIIX4/4E/4M failed (WARNING ONLY) FAILED! This chipset supports the following protocols: Parallel. No EEPROM/flash device found. Note: flashrom can never write if the flash chip isn't found automatically. Long/verbose version: flashrom v0.9.3-r1322 on FreeDOS 7 (i686), built with libpci 3.1.5, GCC 4.3.2, little endian flashrom is free software, get the source code at http://www.flashrom.org Calibrating delay loop... OS timer resolution is 60000 usecs, 2384M loops per second, 10 myus = 0 us, 100 myus = 0 us, 1000 myus = 0 us, 10000 myus = 0 us, 240000 myus = 280000 us, OK. Initializing internal programmer No coreboot table found. DMI string system-manufacturer: "" DMI string system-product-name: "" DMI string system-version: "" DMI string baseboard-manufacturer: "" DMI string baseboard-product-name: "" DMI string baseboard-version: "" DMI string chassis-type: "" Found chipset "Intel PIIX4/4E/4M", enabling flash write... chipset PCI ID is 8086:7110, tried to set 0x4e to 0x2d4 on PIIX4/4E/4M failed (WARNING ONLY) FAILED! This chipset supports the following protocols: Parallel. Probing for AMD Am29F010A/B, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for AMD Am29F002(N)BB, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for AMD Am29F002(N)BT, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for AMD Am29F016D, 2048 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for AMD Am29F040B, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for AMD Am29F080B, 1024 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for AMD Am29LV001BB, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for AMD Am29LV001BT, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for AMD Am29LV002BB, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for AMD Am29LV002BT, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for AMD Am29LV004BB, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for AMD Am29LV004BT, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for AMD Am29LV008BB, 1024 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for AMD Am29LV008BT, 1024 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for AMD Am29LV040B, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for AMD Am29LV081B, 1024 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for AMIC A25L05PT, 64 kB: skipped. Probing for AMIC A25L05PU, 64 kB: skipped. Probing for AMIC A25L10PT, 128 kB: skipped. Probing for AMIC A25L10PU, 128 kB: skipped. Probing for AMIC A25L20PT, 256 kB: skipped. Probing for AMIC A25L20PU, 256 kB: skipped. Probing for AMIC A25L40PT, 512 kB: skipped. Probing for AMIC A25L40PU, 512 kB: skipped. Probing for AMIC A25L80P, 1024 kB: skipped. Probing for AMIC A25L16PT, 2048 kB: skipped. Probing for AMIC A25L16PU, 2048 kB: skipped. Probing for AMIC A25L512, 64 kB: skipped. Probing for AMIC A25L010, 128 kB: skipped. Probing for AMIC A25L020, 256 kB: skipped. Probing for AMIC A25L040, 512 kB: skipped. Probing for AMIC A25L080, 1024 kB: skipped. Probing for AMIC A25L016, 2048 kB: skipped. Probing for AMIC A25L032, 4096 kB: skipped. Probing for AMIC A25LQ032, 4096 kB: skipped. Probing for AMIC A29002B, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for AMIC A29002T, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for AMIC A29040B, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for AMIC A49LF040A, 512 kB: skipped. Probing for Atmel AT25DF021, 256 kB: skipped. Probing for Atmel AT25DF041A, 512 kB: skipped. Probing for Atmel AT25DF081, 1024 kB: skipped. Probing for Atmel AT25DF081A, 1024 kB: skipped. Probing for Atmel AT25DF161, 2048 kB: skipped. Probing for Atmel AT25DF321, 4096 kB: skipped. Probing for Atmel AT25DF321A, 4096 kB: skipped. Probing for Atmel AT25DF641, 8192 kB: skipped. Probing for Atmel AT25DQ161, 2048 kB: skipped. Probing for Atmel AT25F512B, 64 kB: skipped. Probing for Atmel AT25FS010, 128 kB: skipped. Probing for Atmel AT25FS040, 512 kB: skipped. Probing for Atmel AT26DF041, 512 kB: skipped. Probing for Atmel AT26DF081A, 1024 kB: skipped. Probing for Atmel AT26DF161, 2048 kB: skipped. Probing for Atmel AT26DF161A, 2048 kB: skipped. Probing for Atmel AT26F004, 512 kB: skipped. Probing for Atmel AT29C512, 64 kB: probe_jedec_common: id1 0xca, id2 0x2e, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Atmel AT29C010A, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for Atmel AT29C020, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Atmel AT29C040A, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Atmel AT45CS1282, 16896 kB: skipped. Probing for Atmel AT45DB011D, 128 kB: skipped. Probing for Atmel AT45DB021D, 256 kB: skipped. Probing for Atmel AT45DB041D, 512 kB: skipped. Probing for Atmel AT45DB081D, 1024 kB: skipped. Probing for Atmel AT45DB161D, 2048 kB: skipped. Probing for Atmel AT45DB321C, 4224 kB: skipped. Probing for Atmel AT45DB321D, 4096 kB: skipped. Probing for Atmel AT45DB642D, 8192 kB: skipped. Probing for Atmel AT49BV512, 64 kB: probe_jedec_common: id1 0xca, id2 0x2e, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Atmel AT49F020, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Atmel AT49F002(N), 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Atmel AT49F002(N)T, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Bright BM29F040, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for EMST F49B002UA, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for EMST F25L008A, 1024 kB: skipped. Probing for Eon EN25B05, 64 kB: skipped. Probing for Eon EN25B05T, 64 kB: skipped. Probing for Eon EN25B10, 128 kB: skipped. Probing for Eon EN25B10T, 128 kB: skipped. Probing for Eon EN25B20, 256 kB: skipped. Probing for Eon EN25B20T, 256 kB: skipped. Probing for Eon EN25B40, 512 kB: skipped. Probing for Eon EN25B40T, 512 kB: skipped. Probing for Eon EN25B80, 1024 kB: skipped. Probing for Eon EN25B80T, 1024 kB: skipped. Probing for Eon EN25B16, 2048 kB: skipped. Probing for Eon EN25B16T, 2048 kB: skipped. Probing for Eon EN25B32, 4096 kB: skipped. Probing for Eon EN25B32T, 4096 kB: skipped. Probing for Eon EN25B64, 8192 kB: skipped. Probing for Eon EN25B64T, 8192 kB: skipped. Probing for Eon EN25D16, 2048 kB: skipped. Probing for Eon EN25F05, 64 kB: skipped. Probing for Eon EN25F10, 128 kB: skipped. Probing for Eon EN25F20, 256 kB: skipped. Probing for Eon EN25F40, 512 kB: skipped. Probing for Eon EN25F80, 1024 kB: skipped. Probing for Eon EN25F16, 2048 kB: skipped. Probing for Eon EN25F32, 4096 kB: skipped. Probing for Eon EN29F010, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for Eon EN29F002(A)(N)B, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Eon EN29F002(A)(N)T, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Fujitsu MBM29F004BC, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Fujitsu MBM29F004TC, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Fujitsu MBM29F400BC, 512 kB: probe_m29f400bt: id1 0xff, id2 0xff Probing for Fujitsu MBM29F400TC, 512 kB: probe_m29f400bt: id1 0xff, id2 0xff Probing for Hyundai HY29F002T, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Hyundai HY29F002B, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Hyundai HY29F040A, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Intel 28F001BN/BX-B, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for Intel 28F001BN/BX-T, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for Intel 28F002BC/BL/BV/BX-T, 256 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Intel 28F008S3/S5/SC, 512 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Intel 28F004B5/BE/BV/BX-B, 512 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Intel 28F004B5/BE/BV/BX-T, 512 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Intel 28F400BV/BX/CE/CV-B, 512 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Intel 28F400BV/BX/CE/CV-T, 512 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Intel 82802AB, 512 kB: skipped. Probing for Intel 82802AC, 1024 kB: skipped. Probing for Macronix MX25L512, 64 kB: skipped. Probing for Macronix MX25L1005, 128 kB: skipped. Probing for Macronix MX25L2005, 256 kB: skipped. Probing for Macronix MX25L4005, 512 kB: skipped. Probing for Macronix MX25L8005, 1024 kB: skipped. Probing for Macronix MX25L1605, 2048 kB: skipped. Probing for Macronix MX25L1635D, 2048 kB: skipped. Probing for Macronix MX25L1635E, 2048 kB: skipped. Probing for Macronix MX25L3205, 4096 kB: skipped. Probing for Macronix MX25L3235D, 4096 kB: skipped. Probing for Macronix MX25L6405, 8192 kB: skipped. Probing for Macronix MX25L12805, 16384 kB: skipped. Probing for Macronix MX29F001B, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for Macronix MX29F001T, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for Macronix MX29F002B, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Macronix MX29F002T, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Macronix MX29F040, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Macronix MX29LV040, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for MoselVitelic V29C51000B, 64 kB: probe_jedec_common: id1 0xca, id2 0x2e, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for MoselVitelic V29C51000T, 64 kB: probe_jedec_common: id1 0xca, id2 0x2e, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for MoselVitelic V29C51400B, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for MoselVitelic V29C51400T, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for MoselVitelic V29LC51000, 64 kB: probe_jedec_common: id1 0xca, id2 0x2e, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for MoselVitelic V29LC51001, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for MoselVitelic V29LC51002, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Numonyx M25PE10, 128 kB: skipped. Probing for Numonyx M25PE20, 256 kB: skipped. Probing for Numonyx M25PE40, 512 kB: skipped. Probing for Numonyx M25PE80, 1024 kB: skipped. Probing for Numonyx M25PE16, 2048 kB: skipped. Probing for PMC Pm25LV010, 128 kB: skipped. Probing for PMC Pm25LV016B, 2048 kB: skipped. Probing for PMC Pm25LV020, 256 kB: skipped. Probing for PMC Pm25LV040, 512 kB: skipped. Probing for PMC Pm25LV080B, 1024 kB: skipped. Probing for PMC Pm25LV512, 64 kB: skipped. Probing for PMC Pm29F002T, 256 kB: Chip lacks correct probe timing information, using default 10mS/40uS. probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for PMC Pm29F002B, 256 kB: Chip lacks correct probe timing information, using default 10mS/40uS. probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for PMC Pm39LV010, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for PMC Pm39LV020, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for PMC Pm39LV040, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for PMC Pm49FL002, 256 kB: skipped. Probing for PMC Pm49FL004, 512 kB: skipped. Probing for Sanyo LF25FW203A, 2048 kB: skipped. Probing for Sharp LHF00L04, 1024 kB: skipped. Probing for Spansion S25FL004A, 512 kB: skipped. Probing for Spansion S25FL008A, 1024 kB: skipped. Probing for Spansion S25FL016A, 2048 kB: skipped. Probing for Spansion S25FL032A, 4096 kB: skipped. Probing for Spansion S25FL064A, 8192 kB: skipped. Probing for SST SST25VF010.REMS, 128 kB: skipped. Probing for SST SST25VF016B, 2048 kB: skipped. Probing for SST SST25VF032B, 4096 kB: skipped. Probing for SST SST25VF064C, 8192 kB: skipped. Probing for SST SST25VF040.REMS, 512 kB: skipped. Probing for SST SST25VF040B, 512 kB: skipped. Probing for SST SST25LF040A.RES, 512 kB: skipped. Probing for SST SST25VF040B.REMS, 512 kB: skipped. Probing for SST SST25VF080B, 1024 kB: skipped. Probing for SST SST28SF040A, 512 kB: probe_82802ab: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST29EE010, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for SST SST29LE010, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for SST SST29EE020A, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST29LE020, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST39SF512, 64 kB: probe_jedec_common: id1 0xca, id2 0x2e, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST39SF010A, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for SST SST39SF020A, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST39SF040, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST39VF512, 64 kB: probe_jedec_common: id1 0xca, id2 0x2e, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST39VF010, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for SST SST39VF020, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST39VF040, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST39VF080, 1024 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SST SST49LF002A/B, 256 kB: skipped. Probing for SST SST49LF003A/B, 384 kB: skipped. Probing for SST SST49LF004A/B, 512 kB: skipped. Probing for SST SST49LF004C, 512 kB: skipped. Probing for SST SST49LF008A, 1024 kB: skipped. Probing for SST SST49LF008C, 1024 kB: skipped. Probing for SST SST49LF016C, 2048 kB: skipped. Probing for SST SST49LF020, 256 kB: skipped. Probing for SST SST49LF020A, 256 kB: skipped. Probing for SST SST49LF040, 512 kB: skipped. Probing for SST SST49LF040B, 512 kB: skipped. Probing for SST SST49LF080A, 1024 kB: skipped. Probing for SST SST49LF160C, 2048 kB: skipped. Probing for ST M25P05-A, 64 kB: skipped. Probing for ST M25P05.RES, 64 kB: skipped. Probing for ST M25P10-A, 128 kB: skipped. Probing for ST M25P10.RES, 128 kB: skipped. Probing for ST M25P20, 256 kB: skipped. Probing for ST M25P40, 512 kB: skipped. Probing for ST M25P40-old, 512 kB: skipped. Probing for ST M25P80, 1024 kB: skipped. Probing for ST M25P16, 2048 kB: skipped. Probing for ST M25P32, 4096 kB: skipped. Probing for ST M25P64, 8192 kB: skipped. Probing for ST M25P128, 16384 kB: skipped. Probing for ST M25PX16, 2048 kB: skipped. Probing for ST M25PX32, 4096 kB: skipped. Probing for ST M25PX64, 8192 kB: skipped. Probing for ST M29F002B, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M29F002T/NT, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M29F040B, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M29F400BB, 512 kB: probe_m29f400bt: id1 0xff, id2 0xff Probing for ST M29F400BT, 512 kB: probe_m29f400bt: id1 0xff, id2 0xff Probing for ST M29W010B, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for ST M29W040B, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M29W512B, 64 kB: probe_jedec_common: id1 0xca, id2 0x2e, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for ST M50FLW040A, 512 kB: skipped. Probing for ST M50FLW040B, 512 kB: skipped. Probing for ST M50FLW080A, 1024 kB: skipped. Probing for ST M50FLW080B, 1024 kB: skipped. Probing for ST M50FW002, 256 kB: skipped. Probing for ST M50FW016, 2048 kB: skipped. Probing for ST M50FW040, 512 kB: skipped. Probing for ST M50FW080, 1024 kB: skipped. Probing for ST M50LPW116, 2048 kB: skipped. Probing for SyncMOS/MoselVitelic {F,S,V}29C51001B, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for SyncMOS/MoselVitelic {F,S,V}29C51001T, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for SyncMOS/MoselVitelic {F,S,V}29C51002B, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SyncMOS/MoselVitelic {F,S,V}29C51002T, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SyncMOS/MoselVitelic {F,S,V}29C51004B, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SyncMOS/MoselVitelic {F,S,V}29C51004T, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SyncMOS/MoselVitelic {S,V}29C31004B, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for SyncMOS/MoselVitelic {S,V}29C31004T, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for TI TMS29F002RB, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for TI TMS29F002RT, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Winbond W25Q80, 1024 kB: skipped. Probing for Winbond W25Q16, 2048 kB: skipped. Probing for Winbond W25Q32, 4096 kB: skipped. Probing for Winbond W25Q64, 8192 kB: skipped. Probing for Winbond W25Q128, 16384 kB: skipped. Probing for Winbond W25x10, 128 kB: skipped. Probing for Winbond W25x20, 256 kB: skipped. Probing for Winbond W25x40, 512 kB: skipped. Probing for Winbond W25x80, 1024 kB: skipped. Probing for Winbond W25x16, 2048 kB: skipped. Probing for Winbond W25x32, 4096 kB: skipped. Probing for Winbond W25x64, 8192 kB: skipped. Probing for Winbond W29C010(M)/W29C011A/W29EE011/W29EE012, 128 kB: probe_jedec_common: id1 0x3b, id2 0xe9, id1 is normal flash content, id2 is normal flash content Probing for Winbond W29C020(C)/W29C022, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Winbond W29C040/P, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Winbond W29C010(M)/W29C011A/W29EE011/W29EE012, 128 kB: Probing disabled for Winbond W29EE011 because the probing sequence puts the AMIC A49LF040A in a funky state. Use 'flashrom -c W29EE011' if you have a board with this chip. Probing for Winbond W39L040, 512 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Winbond W39V040A, 512 kB: skipped. Probing for Winbond W39V040B, 512 kB: skipped. Probing for Winbond W39V040C, 512 kB: skipped. Probing for Winbond W39V040FA, 512 kB: skipped. Probing for Winbond W39V040FB, 512 kB: skipped. Probing for Winbond W39V040FC, 512 kB: skipped. Probing for Winbond W39V080A, 1024 kB: skipped. Probing for Winbond W49F002U/N, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Winbond W49F020, 256 kB: probe_jedec_common: id1 0xff, id2 0xff, id1 parity violation, id1 is normal flash content, id2 is normal flash content Probing for Winbond W49V002A, 256 kB: skipped. Probing for Winbond W49V002FA, 256 kB: skipped. Probing for Winbond W39V080FA, 1024 kB: skipped. Probing for Winbond W39V080FA (dual mode), 512 kB: skipped. Probing for AMIC unknown AMIC SPI chip, 0 kB: skipped. Probing for Atmel unknown Atmel SPI chip, 0 kB: skipped. Probing for Eon unknown Eon SPI chip, 0 kB: skipped. Probing for Macronix unknown Macronix SPI chip, 0 kB: skipped. Probing for PMC unknown PMC SPI chip, 0 kB: skipped. Probing for SST unknown SST SPI chip, 0 kB: skipped. Probing for ST unknown ST SPI chip, 0 kB: skipped. Probing for Sanyo unknown Sanyo SPI chip, 0 kB: skipped. Probing for Generic unknown SPI chip (RDID), 0 kB: skipped. Probing for Generic unknown SPI chip (REMS), 0 kB: skipped. No EEPROM/flash device found. Note: flashrom can never write if the flash chip isn't found automatically. Restoring PCI config space for 00:07:0 reg 0x4e

3 3

Re: [flashrom] [PATCH] be more refined regarding DMI chassis types
by Bernd Blaauw 26 Jul '11

26 Jul '11

Op 26-7-2011 1:22, Stefan Tauner schreef: > we had broken laptops in the past that were not detected as such because > their DMI chassis-type was either undefined/out-of-spec, or set to > 'other' or 'unknown'. Does Flashrom use a list of "known mobile hardware" (either chipset, processor or videocard) to recognise a machine as laptop? Intel seems to have a lot of 'M' stuff (ICH9M for example).

2 2

Re: [flashrom] [PATCH] be more refined regarding DMI chassis types
by Stefan Tauner 25 Jul '11

25 Jul '11

On Tue, 26 Jul 2011 01:22:01 +0200 Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> wrote: > + msg_pdbg("DMI chassis-type is not specific enough.\n"); that line is already gone locally (thanks idwer). > + switch (is_laptop) { > + case 1: > + msg_pdbg("Laptop detected via DMI.\n"); > + break; > + case 2: > + msg_pdbg("DMI chassis-type is not specific enough.\n"); > + break; > + } -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner

1 0

Re: [flashrom] [PATCH] be more refined regarding DMI chassis types
by Carl-Daniel Hailfinger 25 Jul '11

25 Jul '11

Am 04.06.2011 10:55 schrieb Stefan Tauner: > we had broken laptops in the past that were not detected as such because their DMI chassis-type was either undefined/out-of-spec, or set to 'other' or 'unknown'. > > this patch tries to mitigate this problem as follows: > - if the DMI chassis-type clearly identifies the system as laptop/notebook/mobile platform then nothing changes: the user gets the laptop warning without a hint to the force switch. > - if the DMI chassis-type is not specific enough, we warn the user similarly, but tell them the switch. > to reduce the number of false positives i have added a few new chassis types that we have encountered in the last months to the list. > > Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> > --- > dmi.c | 37 ++++++++++++++++++++++++++----------- > internal.c | 21 +++++++++++++++------ > 2 files changed, 41 insertions(+), 17 deletions(-) > > diff --git a/dmi.c b/dmi.c > index cda6656..5d37b76 100644 > --- a/dmi.c > +++ b/dmi.c > @@ -54,7 +54,13 @@ static const char *dmidecode_names[] = { > "baseboard-version", > }; > > -/* A full list of chassis types can be found in the System Management BIOS > +/* This list is used to identify supposed laptops. The is_laptop field has the > + * following meaning: > + * - 0: in all likelihood not a laptop > + * - 1: in all likelihood a laptop > + * - 2: chassis-type is not specific enough (these do not need to be listed > + * in the table, because it is the default anyway) > + * A full list of chassis types can be found in the System Management BIOS > * (SMBIOS) Reference Specification 2.7.0 section 7.4.1 "Chassis Types" at > * http://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.0.p… > * The types below are the most common ones. > @@ -64,14 +70,16 @@ static const struct { > unsigned char is_laptop; > const char *name; > } dmi_chassis_types[] = { > - {0x01, 0, "Other"}, > - {0x02, 0, "Unknown"}, > Why remove those lines? Use 2 for undecided cases. Removing these lines will make it harder later to integrate the DMI decoder (we currently rely on external dmidecode and that fails quite often due to dmidecode not being installed etc.). The DMI decoder integration patch was posted some time ago to the list, but it needs to be redone/cleaned up significantly before we can merge it. > {0x03, 0, "Desktop",}, > + {0x06, 0, "Mini Tower"}, > + {0x07, 0, "Tower"}, > {0x08, 1, "Portable"}, > {0x09, 1, "Laptop"}, > {0x0a, 1, "Notebook"}, > {0x0b, 1, "Hand Held"}, > {0x0e, 1, "Sub Notebook"}, > + {0x11, 0, "Main Server Chassis"}, > + {0x17, 0, "Rack Mount Chassis"}, > }; > > #define DMI_COMMAND_LEN_MAX 260 > @@ -152,16 +160,23 @@ void dmi_init(void) > } > > chassis_type = get_dmi_string("chassis-type"); > - if (chassis_type) { > - for (i = 0; i < ARRAY_SIZE(dmi_chassis_types); i++) { > - if (!strcasecmp(chassis_type, > - dmi_chassis_types[i].name) && > - dmi_chassis_types[i].is_laptop) { > - msg_pdbg("Laptop detected via DMI\n"); > - is_laptop = 1; > - } > + if (chassis_type == NULL) > + return; > + > is_laptop = 2; > + for (i = 0; i < ARRAY_SIZE(dmi_chassis_types); i++) { > + if (strcasecmp(chassis_type, dmi_chassis_types[i].name) == 0) { > + is_laptop = dmi_chassis_types[i].is_laptop; > break; > + if (is_laptop == 1) { > + msg_pdbg("Laptop detected via DMI.\n"); > + free(chassis_type); > + return; > + } else > + break; /* first match breaks loop */ > Can you kill the whole inner if statement? > } > } > + > + msg_pdbg("DMI chassis-type is not specific enough.\n"); > Please use this instead (my whitespace is broken, I know): switch (is_laptop) { case 1: msg_pdbg("Laptop detected via DMI.\n"); break; case 2: msg_pdbg("DMI chassis-type is not specific enough.\n"); break; } > + is_laptop = 2; > Kill the assignment above. > free(chassis_type); > } > > diff --git a/internal.c b/internal.c > index c9f62c1..bbcdc5b 100644 > --- a/internal.c > +++ b/internal.c > @@ -124,7 +124,7 @@ int register_superio(struct superio s) > > #endif > > -int is_laptop = 0; > +int is_laptop = -1; > This changes the logic. With this change, flashrom assumes that every machine is a laptop, and that will bite us everywhere dmidecode is unavailable. Please review your changes below in light of that. > int laptop_ok = 0; > > int internal_init(void) > @@ -222,11 +222,19 @@ int internal_init(void) > > /* Warn if a non-whitelisted laptop is detected. */ > if (is_laptop && !laptop_ok) { > - msg_perr("========================================================================\n" > - "WARNING! You seem to be running flashrom on an unsupported laptop.\n" > - "Laptops, notebooks and netbooks are difficult to support and we recommend\n" > - "to use the vendor flashing utility. The embedded controller (EC) in these\n" > - "machines often interacts badly with flashing.\n" > + msg_perr("========================================================================\n"); > + if (is_laptop == 1) { > + msg_perr("WARNING! You seem to be running flashrom on an unsupported laptop.\n"); > + } else { > + msg_perr("WARNING! You may be running flashrom on an unsupported laptop. We could\n" > + "not detect this for sure because your vendor has not setup the SMBIOS\n" > + "tables correctly. You can enforce execution by adding\n" > + "'-p internal:laptop=force_I_want_a_brick' to the command line, but\n" > + "please read the following warning if you are not sure.\n\n"); > + } > + msg_perr("Laptops, notebooks and netbooks are difficult to support and we\n" > + "recommend to use the vendor flashing utility. The embedded controller\n" > + "(EC) in these machines often interacts badly with flashing.\n" > "See http://www.flashrom.org/Laptops for details.\n\n" > "If flash is shared with the EC, erase is guaranteed to brick your laptop\n" > "and write may brick your laptop.\n" > @@ -234,6 +242,7 @@ int internal_init(void) > "failure and sudden poweroff.\n" > "You have been warned.\n" > "========================================================================\n"); > + > if (force_laptop) { > msg_perr("Proceeding anyway because user specified " > "laptop=force_I_want_a_brick\n"); > Regards, Carl-Daniel -- http://www.hailfinger.org/

2 3

[PATCH] Fix ICH FWH IDSEL setting
by Carl-Daniel Hailfinger 25 Jul '11

25 Jul '11

Fix ICH FWH IDSEL setting with the fwh_idsel= internal programmer parameter. The code took 32 bits of input and wrote them to an 48 bit register, duplicating some values. Document the fwh_idsel= parameter in the man page. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: flashrom-ich_fwh_idsel_programmer_param_docfix/flashrom.8 =================================================================== --- flashrom-ich_fwh_idsel_programmer_param_docfix/flashrom.8 (Revision 1380) +++ flashrom-ich_fwh_idsel_programmer_param_docfix/flashrom.8 (Arbeitskopie) @@ -298,6 +298,20 @@ .B it87spi programmer. .sp +If you have an Intel chipset with an ICH6 or later southbridge and if you want +to set specific IDSEL values for a non-default flash chip or an embedded +controller (EC), you can use the +.sp +.B " flashrom \-p internal:fwh_idsel=value" +.sp +syntax where value is the 48-bit hexadecimal raw value to be written in the +IDSEL registers of the Intel southbridge. The upper 32 bits use one hex digit +each per 512 kB range between 0xffc00000 and 0xffffffff, and the lower 16 bits +use one hex digit each per 1024 kB range between 0xff400000 and 0xff7fffff. +The rightmost hex digit corresponds with the lowest address range. All address +ranges have a corresponding sister range 4 MB below with identical IDSEL +settings. +.sp Using flashrom on laptops is dangerous and may easily make your hardware unusable (see also the .B BUGS Index: flashrom-ich_fwh_idsel_programmer_param_docfix/chipset_enable.c =================================================================== --- flashrom-ich_fwh_idsel_programmer_param_docfix/chipset_enable.c (Revision 1380) +++ flashrom-ich_fwh_idsel_programmer_param_docfix/chipset_enable.c (Arbeitskopie) @@ -301,7 +301,7 @@ static int enable_flash_ich_dc(struct pci_dev *dev, const char *name) { - uint32_t fwh_conf; + uint64_t fwh_conf; int i; char *idsel = NULL; int tmp; @@ -311,15 +311,18 @@ idsel = extract_programmer_param("fwh_idsel"); if (idsel && strlen(idsel)) { - fwh_conf = (uint32_t)strtoul(idsel, NULL, 0); - - /* FIXME: Need to undo this on shutdown. */ - msg_pinfo("\nSetting IDSEL=0x%x for top 16 MB", fwh_conf); - rpci_write_long(dev, 0xd0, fwh_conf); - rpci_write_word(dev, 0xd4, fwh_conf); + fwh_conf = pci_read_long(dev, 0xd0); + fwh_conf <<= 16; + fwh_conf |= pci_read_word(dev, 0xd4); + msg_pinfo("\nSetting IDSEL from 0x%012llx ", fwh_conf); + /* Base 16, nothing else makes sense. */ + fwh_conf = (uint64_t)strtoull(idsel, NULL, 16); + msg_pinfo("to 0x%012llx for top 16 MB", fwh_conf); + rpci_write_long(dev, 0xd0, (fwh_conf >> 16) & 0xffffffff); + rpci_write_word(dev, 0xd4, fwh_conf & 0xffff); /* FIXME: Decode settings are not changed. */ } else if (idsel) { - msg_perr("Error: idsel= specified, but no number given.\n"); + msg_perr("Error: fwh_idsel= specified, but no number given.\n"); free(idsel); /* FIXME: Return failure here once internal_init() starts * to care about the return value of the chipset enable. -- http://www.hailfinger.org/

2 5

[commit] r1389 - trunk
by repository service 25 Jul '11

25 Jul '11

Author: hailfinger Date: Tue Jul 26 00:44:09 2011 New Revision: 1389 URL: http://flashrom.org/trac/flashrom/changeset/1389 Log: Fix ICH FWH IDSEL setting with the fwh_idsel= internal programmer parameter. The code took 32 bits of input and wrote them to an 48 bit register, duplicating some values. Document the fwh_idsel= parameter in the man page. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at> Modified: trunk/chipset_enable.c trunk/flashrom.8 Modified: trunk/chipset_enable.c ============================================================================== --- trunk/chipset_enable.c Tue Jul 26 00:07:05 2011 (r1388) +++ trunk/chipset_enable.c Tue Jul 26 00:44:09 2011 (r1389) @@ -30,6 +30,8 @@ #include <stdlib.h> #include <string.h> #include <unistd.h> +#include <inttypes.h> +#include <errno.h> #include "flash.h" #include "programmer.h" @@ -311,15 +313,33 @@ idsel = extract_programmer_param("fwh_idsel"); if (idsel && strlen(idsel)) { - fwh_conf = (uint32_t)strtoul(idsel, NULL, 0); - - /* FIXME: Need to undo this on shutdown. */ - msg_pinfo("\nSetting IDSEL=0x%x for top 16 MB", fwh_conf); - rpci_write_long(dev, 0xd0, fwh_conf); - rpci_write_word(dev, 0xd4, fwh_conf); + uint64_t fwh_idsel_old; + uint64_t fwh_idsel; + errno = 0; + /* Base 16, nothing else makes sense. */ + fwh_idsel = (uint64_t)strtoull(idsel, NULL, 16); + if (errno) { + msg_perr("Error: fwh_idsel= specified, but value could " + "not be converted.\n"); + goto idsel_garbage_out; + } + if (fwh_idsel & 0xffff000000000000ULL) { + msg_perr("Error: fwh_idsel= specified, but value had " + "unusued bits set.\n"); + goto idsel_garbage_out; + } + fwh_idsel_old = pci_read_long(dev, 0xd0); + fwh_idsel_old <<= 16; + fwh_idsel_old |= pci_read_word(dev, 0xd4); + msg_pdbg("\nSetting IDSEL from 0x%012" PRIx64 " to " + "0x%012" PRIx64 " for top 16 MB.", fwh_idsel_old, + fwh_idsel); + rpci_write_long(dev, 0xd0, (fwh_idsel >> 16) & 0xffffffff); + rpci_write_word(dev, 0xd4, fwh_idsel & 0xffff); /* FIXME: Decode settings are not changed. */ } else if (idsel) { - msg_perr("Error: idsel= specified, but no number given.\n"); + msg_perr("Error: fwh_idsel= specified, but no value given.\n"); +idsel_garbage_out: free(idsel); /* FIXME: Return failure here once internal_init() starts * to care about the return value of the chipset enable. Modified: trunk/flashrom.8 ============================================================================== --- trunk/flashrom.8 Tue Jul 26 00:07:05 2011 (r1388) +++ trunk/flashrom.8 Tue Jul 26 00:44:09 2011 (r1389) @@ -299,6 +299,23 @@ flashrom doesn't detect an active IT87 LPC<->SPI bridge, please send a bug report so we can diagnose the problem. .sp +If you have an Intel chipset with an ICH6 or later southbridge and if you want +to set specific IDSEL values for a non-default flash chip or an embedded +controller (EC), you can use the +.sp +.B " flashrom \-p internal:fwh_idsel=value" +.sp +syntax where value is the 48-bit hexadecimal raw value to be written in the +IDSEL registers of the Intel southbridge. The upper 32 bits use one hex digit +each per 512 kB range between 0xffc00000 and 0xffffffff, and the lower 16 bits +use one hex digit each per 1024 kB range between 0xff400000 and 0xff7fffff. +The rightmost hex digit corresponds with the lowest address range. All address +ranges have a corresponding sister range 4 MB below with identical IDSEL +settings. The default value for ICH7 is given in the example below. +.sp +Example: +.B "flashrom \-p internal:fwh_idsel=0x001122334567" +.sp Using flashrom on laptops is dangerous and may easily make your hardware unusable (see also the .B BUGS

1 0

[PATCH] satamv.c requires PCI port I/O
by Andrew Morgan 25 Jul '11

25 Jul '11

satamv.c requires PCI port I/O which isn't currently available on anything other than x86/x86_64. Generate the same compiler error as other programmers eg. rayer_spi.c, which is where I copied the code from. Signed-off-by: Andrew Morgan <ziltro(a)ziltro.com> -- Andrew.

3 2

[commit] r1388 - trunk
by repository service 25 Jul '11

25 Jul '11

Author: hailfinger Date: Tue Jul 26 00:07:05 2011 New Revision: 1388 URL: http://flashrom.org/trac/flashrom/changeset/1388 Log: satamv and atahpt require PCI port I/O which isn't currently supported on any architecture except x86/x86_64. Generate the same compiler error as other programmer drivers. Signed-off-by: Andrew Morgan <ziltro(a)ziltro.com> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/atahpt.c trunk/satamv.c Modified: trunk/atahpt.c ============================================================================== --- trunk/atahpt.c Mon Jul 25 23:12:57 2011 (r1387) +++ trunk/atahpt.c Tue Jul 26 00:07:05 2011 (r1388) @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +#if defined(__i386__) || defined(__x86_64__) + #include <stdlib.h> #include <string.h> #include "flash.h" @@ -77,3 +79,7 @@ OUTL((uint32_t)addr, io_base_addr + BIOS_ROM_ADDR); return INB(io_base_addr + BIOS_ROM_DATA); } + +#else +#error PCI port I/O access is not supported on this architecture yet. +#endif Modified: trunk/satamv.c ============================================================================== --- trunk/satamv.c Mon Jul 25 23:12:57 2011 (r1387) +++ trunk/satamv.c Tue Jul 26 00:07:05 2011 (r1388) @@ -19,6 +19,7 @@ */ /* Datasheets are not public (yet?) */ +#if defined(__i386__) || defined(__x86_64__) #include <stdlib.h> #include "flash.h" @@ -182,3 +183,7 @@ { return satamv_indirect_chip_readb(addr); } + +#else +#error PCI port I/O access is not supported on this architecture yet. +#endif

1 0

[PATCH] flashrom: fix sparse warning: Using plain integer as NULL pointer
by Peter Hüwe 25 Jul '11

25 Jul '11

flashrom: fix sparse warning: Using plain integer as NULL pointer This patch fixes the "using plain integer as NULL pointer" warnings generated by running sparse on the flashrom source. Flashrom-Version: r1254 Signed-off-by: Peter Huewe <peterhuewe(a)gmx.de> --- cbtable.c | 2 +- chipset_enable.c | 2 +- cli_classic.c | 34 +++++++++++++++++----------------- physmap.c | 4 ++-- programmer.c | 2 +- serprog.c | 2 +- udelay.c | 8 ++++---- 7 files changed, 27 insertions(+), 27 deletions(-) diff --git a/cbtable.c b/cbtable.c index dbb2cff..f30a3ae 100644 --- a/cbtable.c +++ b/cbtable.c @@ -141,7 +141,7 @@ static struct lb_header *find_lb_table(void *base, unsigned long start, }; - return 0; + return NULL; } static void find_mainboard(struct lb_record *ptr, unsigned long addr) diff --git a/chipset_enable.c b/chipset_enable.c index 6d6008e..0896bce 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1173,7 +1173,7 @@ const struct penable chipset_enables[] = { int chipset_flash_enable(void) { - struct pci_dev *dev = 0; + struct pci_dev *dev = NULL; int ret = -2; /* Nothing! */ int i; diff --git a/cli_classic.c b/cli_classic.c index 1211989..88b70db 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -116,23 +116,23 @@ int cli_classic(int argc, char *argv[]) static const char optstring[] = "r:Rw:v:nVEfc:m:l:i:p:Lzh"; static const struct option long_options[] = { - {"read", 1, 0, 'r'}, - {"write", 1, 0, 'w'}, - {"erase", 0, 0, 'E'}, - {"verify", 1, 0, 'v'}, - {"noverify", 0, 0, 'n'}, - {"chip", 1, 0, 'c'}, - {"mainboard", 1, 0, 'm'}, - {"verbose", 0, 0, 'V'}, - {"force", 0, 0, 'f'}, - {"layout", 1, 0, 'l'}, - {"image", 1, 0, 'i'}, - {"list-supported", 0, 0, 'L'}, - {"list-supported-wiki", 0, 0, 'z'}, - {"programmer", 1, 0, 'p'}, - {"help", 0, 0, 'h'}, - {"version", 0, 0, 'R'}, - {0, 0, 0, 0} + {"read", 1, NULL, 'r'}, + {"write", 1, NULL, 'w'}, + {"erase", 0, NULL, 'E'}, + {"verify", 1, NULL, 'v'}, + {"noverify", 0, NULL, 'n'}, + {"chip", 1, NULL, 'c'}, + {"mainboard", 1, NULL, 'm'}, + {"verbose", 0, NULL, 'V'}, + {"force", 0, NULL, 'f'}, + {"layout", 1, NULL, 'l'}, + {"image", 1, NULL, 'i'}, + {"list-supported", 0, NULL, 'L'}, + {"list-supported-wiki", 0, NULL, 'z'}, + {"programmer", 1, NULL, 'p'}, + {"help", 0, NULL, 'h'}, + {"version", 0, NULL, 'R'}, + {NULL, 0, NULL, 0} }; char *filename = NULL; diff --git a/physmap.c b/physmap.c index 4641e8e..70156a6 100644 --- a/physmap.c +++ b/physmap.c @@ -180,7 +180,7 @@ static void *sys_physmap_rw_uncached(unsigned long phys_addr, size_t len) } } - virt_addr = mmap(0, len, PROT_WRITE | PROT_READ, MAP_SHARED, + virt_addr = mmap(NULL, len, PROT_WRITE | PROT_READ, MAP_SHARED, fd_mem, (off_t)phys_addr); return MAP_FAILED == virt_addr ? ERROR_PTR : virt_addr; } @@ -200,7 +200,7 @@ static void *sys_physmap_ro_cached(unsigned long phys_addr, size_t len) } } - virt_addr = mmap(0, len, PROT_READ, MAP_SHARED, + virt_addr = mmap(NULL, len, PROT_READ, MAP_SHARED, fd_mem_cached, (off_t)phys_addr); return MAP_FAILED == virt_addr ? ERROR_PTR : virt_addr; } diff --git a/programmer.c b/programmer.c index 0160867..5c1f963 100644 --- a/programmer.c +++ b/programmer.c @@ -30,7 +30,7 @@ int noop_shutdown(void) void *fallback_map(const char *descr, unsigned long phys_addr, size_t len) { /* FIXME: Should return phys_addr. */ - return 0; + return NULL; } /* No-op/fallback unmap() for programmers which don't need special handling */ diff --git a/serprog.c b/serprog.c index 2cdfea6..f869b07 100644 --- a/serprog.c +++ b/serprog.c @@ -541,7 +541,7 @@ static void sp_execute_opbuf_noflush(void) { if ((sp_max_write_n) && (sp_write_n_bytes)) sp_pass_writen(); - sp_stream_buffer_op(S_CMD_O_EXEC, 0, 0); + sp_stream_buffer_op(S_CMD_O_EXEC, 0, NULL); msg_pspew(MSGHEADER "Executed operation buffer of %d bytes\n", sp_opbuf_usage); sp_opbuf_usage = 0; diff --git a/udelay.c b/udelay.c index 153f510..feae827 100644 --- a/udelay.c +++ b/udelay.c @@ -45,11 +45,11 @@ static unsigned long measure_os_delay_resolution(void) struct timeval start, end; unsigned long counter = 0; - gettimeofday(&start, 0); + gettimeofday(&start, NULL); timeusec = 0; while (!timeusec && (++counter < 1000000000)) { - gettimeofday(&end, 0); + gettimeofday(&end, NULL); timeusec = 1000000 * (end.tv_sec - start.tv_sec) + (end.tv_usec - start.tv_usec); /* Protect against time going forward too much. */ @@ -68,9 +68,9 @@ static unsigned long measure_delay(int usecs) unsigned long timeusec; struct timeval start, end; - gettimeofday(&start, 0); + gettimeofday(&start, NULL); myusec_delay(usecs); - gettimeofday(&end, 0); + gettimeofday(&end, NULL); timeusec = 1000000 * (end.tv_sec - start.tv_sec) + (end.tv_usec - start.tv_usec); /* Protect against time going forward too much. */ -- 1.7.2.2

3 2

Re: [flashrom] [PATCH] Fix NULL pointer reference in board_flash_enable.
by Maciej Pijanka 25 Jul '11

25 Jul '11

On Fri, 12 Mar 2010, Michael Karcher wrote: > Was introduced in r926. Found by Henrik Kretzschmar <henne(a)nachtwindheim.de>. > > Signed-off-by: Michael Karcher <flashrom(a)mkarcher.dialup.fu-berlin.de> Imo looks sane and should be commited. Acked-by: Maciej Pijanka <maciej.pijanka(a)gmail.com> > --- > board_enable.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/board_enable.c b/board_enable.c > index aa463bc..0e89137 100644 > --- a/board_enable.c > +++ b/board_enable.c > @@ -1445,7 +1445,7 @@ int board_flash_enable(const char *vendor, const char *part) > if (!board) > board = board_match_pci_card_ids(); > > - if (board->status == NT) { > + if (board && board->status == NT) { > if (!force_boardenable) > { > printf("WARNING: Your mainboard is %s %s, but the mainboard-specific\n" > -- -- Maciej Pijanka I don't fear computers, I fear lack of them -- Isaac Asimov

2 1

← Newer
1
...
9
10
11
12
13
14
15
...
28
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

flashrom July 2011