Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58276 )
Change subject: platform.h: remove IS_LINUX and IS_MACOSX macro
......................................................................
Patch Set 2: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58276/comment/37ebff2f_cdc65f09
PS2, Line 7: macro
`macros`
https://review.coreboot.org/c/flashrom/+/58276/comment/099995a3_dc47cf36
PS2, Line 9: Replace the remaining uses by the plain macros.
Add an empty line to split paragraphs?
https://review.coreboot.org/c/flashrom/+/58276/comment/bf6631c5_78b0aad0
PS2, Line 11: easily
Missing a word here, `can easily *be* handled`?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58276
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I23ec8fdcff8202d10ddf5a7520432e5b26b01cd4
Gerrit-Change-Number: 58276
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 13 Oct 2021 14:09:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
