Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34025 )
Change subject: layout: Increase max rom layout size
......................................................................
Patch Set 3:
Patch Set 2:
Philipp told me that this resulted in a brick, I wonder
how? Doesn't flashrom bail out properly if the FMAP is
too big?
It does and there's no brick. Clarified commit message.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/34025
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I68084b08f7b35a162b5f2d3109d82a8b63c194ff
Gerrit-Change-Number: 34025
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Thu, 04 Jul 2019 06:42:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment