Attention is currently required from: Miklós Márton, Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59047 )
Change subject: Makefile: Rework NI-845x detection ......................................................................
Patch Set 11:
(2 comments)
Patchset:
PS11: Miklós can you have a look at this? We installed the library on a 64-bit Windows and everything worked fine (without the Program Files (x86) kludge). Is it worthwhile to maintain it?
File Makefile:
https://review.coreboot.org/c/flashrom/+/59047/comment/64f25d20_9cb43c65 PS11, Line 740: # hack to access env variable containing brackets... : PROGRAMFILES_X86DIR = $(shell env | sed -n "s/^PROGRAMFILES(X86)=//p") : : ifneq ($(PROGRAMFILES_X86DIR),) : ifneq ($(PROGRAMFILES_X86DIR), ${PROGRAMFILES}) : NI845X_LIBS += -L'$(PROGRAMFILES_X86DIR)\National Instruments\NI-845x\MS Visual C' : NI845X_INCLUDES += -I'$(PROGRAMFILES_X86DIR)\National Instruments\NI-845x\MS Visual C' : endif : endif I would like to maintain this unless Miklós agrees that it's not really needed (as this covers only 32-bit library on 64-bit Windows and 64-bit libraries seem to be available anyway).