Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46140 )
Change subject: s25f.c: import from cros flashrom ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/flashrom/+/46140/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/46140/2//COMMIT_MSG@9 PS2, Line 9: Imported
"Adapted" […]
Done
https://review.coreboot.org/c/flashrom/+/46140/5/Makefile File Makefile:
https://review.coreboot.org/c/flashrom/+/46140/5/Makefile@641 PS5, Line 641: s25f.o
add this to the meson build system as well
Done
https://review.coreboot.org/c/flashrom/+/46140/2/chipdrivers.h File chipdrivers.h:
https://review.coreboot.org/c/flashrom/+/46140/2/chipdrivers.h@24 PS2, Line 24: #include "writeprotect.h" /* for modifier_bits */
I hear you however I think it's worth separating out into another commit. […]
Done