Jack Olsen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44308 )
Change subject: flashchips: Add support for Boya Microelectronics BY25Q128AS
......................................................................
Patch Set 7:
(1 comment)
Patch Set 4: Code-Review-1
(2 comments)
Looks good to me, other than the Signed-off-by line
Done! Are you able to remove the code review down vote?
https://review.coreboot.org/c/flashrom/+/44308/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/44308/4//COMMIT_MSG@11
PS4, Line 11: Change-Id: I881ba86cfaa82e43c73360135d47c74d896cc191
Done
I have fixed this can you please remove the down vote? Or tell me what else I need to do?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/44308
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I881ba86cfaa82e43c73360135d47c74d896cc191
Gerrit-Change-Number: 44308
Gerrit-PatchSet: 7
Gerrit-Owner: Jack Olsen
omegasec@tutanota.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan
edward.ocallaghan@koparo.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 30 Oct 2020 03:14:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jack Olsen
omegasec@tutanota.com
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Gerrit-MessageType: comment