1 Feb
2020
1 Feb
'20
3:12 p.m.
Carl-Daniel Hailfinger has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38659 )
Change subject: Fix building with meson, again ......................................................................
Patch Set 1:
(1 comment)
Thanks for the fix. One cosmetic comment about ordering, though.
https://review.coreboot.org/c/flashrom/+/38659/1/meson_options.txt File meson_options.txt:
https://review.coreboot.org/c/flashrom/+/38659/1/meson_options.txt@36 PS1, Line 36: option('config_stlinkv3_spi', type : 'boolean', value : true, description : 'STMicroelectronics STLINK-V3') The rest of the entries is ordered alphabetically. Can you please push this change one line up?
--
To view, visit https://review.coreboot.org/c/flashrom/+/38659
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iea40da587729f3975a8901d3933e7567805242c5
Gerrit-Change-Number: 38659
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 01 Feb 2020 15:12:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment