Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44308 )
Change subject: flashchips: Add support for Boya Microelectronics BY25Q128AS ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patch Set 4:
(6 comments)
Patch Set 1: Code-Review+1
(7 comments)
Welcome!
Overall, looks good, but with some minor nits about formatting.
Thank you for your review, feedback and insights into the standards of this project. I have applied the changes you suggested (I hope, still figuring out some of Gerrit's finer points :). Anyhow let me know if I can do anything else.
I'm pleased to help 😊
https://review.coreboot.org/c/flashrom/+/44308/4/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/44308/4/flashchips.c@3477 PS4, Line 3477: spi_disable_blockprotect_at25fs040 Just to be sure, how have you tested this? I haven't messed with flash chip block protection much (and flashrom is rather dumb about it)