Attention is currently required from: Edward O'Callaghan, Piotr Halama, Peter Marheine.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73513 )
Change subject: flashchips: Add support for Boya BY25D80A ......................................................................
Patch Set 2:
(4 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/73513/comment/03b9c0f3_8b28646a PS2, Line 3533: . Why the dot? Same for the `model_id` leaving the `Y` out
https://review.coreboot.org/c/flashrom/+/73513/comment/04924545_24657104 PS2, Line 3546: {2 * 1024, 512 The datasheet says: `{4 * 1024, 256}` for the first eraser.
https://review.coreboot.org/c/flashrom/+/73513/comment/5966a0f4_55390cbb PS2, Line 3549: 16 * 1024, 64 The Datasheet says {32 * 1024, 32} for the `52` block eraser.
https://review.coreboot.org/c/flashrom/+/73513/comment/a5ebdd9f_5b6976f7 PS2, Line 3552: {32 * 1024, 32} The datasheet says `{64 * 1024. 16}` for the `D8` block eraser.