Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/69096 )
Change subject: cli_classic.c: Replace programmer_init() with libflashrom call ......................................................................
cli_classic.c: Replace programmer_init() with libflashrom call
Hoist more of the cli upon the libflashrom API surface.
TEST='./flashrom -p internal --flash-name' && './flashrom --flash-name'
Change-Id: Ie276308196da7b2cc47ad542ed184f6ccd360e4c Signed-off-by: Edward O'Callaghan quasisec@google.com --- M cli_classic.c 1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/96/69096/1
diff --git a/cli_classic.c b/cli_classic.c index b66094c..c495d7c 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -810,6 +810,7 @@ #endif break; case 'p': + /* TODO: rewrite to just extract out prog_name and prog_params. */ if (prog != NULL) { cli_classic_abort_usage("Error: --programmer specified " "more than once. You can separate " @@ -965,7 +966,7 @@ } }
- if (programmer_init(prog, pparam)) { + if (flashrom_programmer_init(NULL, prog->name, pparam)) { msg_perr("Error: Programmer initialization failed.\n"); ret = 1; goto out_shutdown;