Attention is currently required from: Antonio Vázquez Blanco, David Reguera Garcia (Dreg), Matti Finder, Miklós Márton, Nikolai Artemiev.
Sergii Dmytruk has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85539?usp=email )
Change subject: Extract SPI declarations to the correct header
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/85539/comment/93cdb036_fbdba7e1?usp... :
PS2, Line 7: Extract SPI declarations to the correct header
Nit: "extract" usually means creating something new in the process of move (header in this case), so I think "move" explains what happens better. I'd also mention at least target header because I had to look through the changes to understand what is being done.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/85539?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I794a71536a3b85fde39f83c802fa0f5dd8d428e0
Gerrit-Change-Number: 85539
Gerrit-PatchSet: 2
Gerrit-Owner: Antonio Vázquez Blanco
antoniovazquezblanco@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: David Reguera Garcia (Dreg)
regueragarciadavid@gmail.com
Gerrit-Reviewer: Matti Finder
matti.finder@gmail.com
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Antonio Vázquez Blanco
antoniovazquezblanco@gmail.com
Gerrit-Attention: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: David Reguera Garcia (Dreg)
regueragarciadavid@gmail.com
Gerrit-Attention: Matti Finder
matti.finder@gmail.com
Gerrit-Comment-Date: Mon, 16 Dec 2024 15:02:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No