22 Dec
2022
22 Dec
'22
9:35 a.m.
Attention is currently required from: Simon Buhrow, Thomas Heijligen, Aarya.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71173 )
Change subject: flashrom.c: Add new erase_by_layout and walk_bylayout implementations ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/71173/comment/2f0f79be_d5bac47f PS4, Line 1556: return 1; /* unimplemented. */ just replace this line.
https://review.coreboot.org/c/flashrom/+/71173/comment/2439d3ad_354aca18 PS4, Line 1721: return 1; /* unimplemented. */ just replace this line.
--
To view, visit https://review.coreboot.org/c/flashrom/+/71173
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id79ae943eb9d6a817da28381db477725834faaf6
Gerrit-Change-Number: 71173
Gerrit-PatchSet: 4
Gerrit-Owner: Aarya aarya.chaumal@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Aarya aarya.chaumal@gmail.com
Gerrit-Comment-Date: Thu, 22 Dec 2022 09:35:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment