Shiyu Sun has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46089 )
Change subject: realtek_mst_i2c_spi.c: Update write protection disable function ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/flashrom/+/46089/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/46089/4//COMMIT_MSG@9 PS4, Line 9: The write protection trigger has been updated by the vendor so update : here as well.
Please add a little more detail for external reviewers so that everyone understands the code well an […]
Done
https://review.coreboot.org/c/flashrom/+/46089/4/realtek_mst_i2c_spi.c File realtek_mst_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/46089/4/realtek_mst_i2c_spi.c@49 PS4, Line 49: HIGH
perhaps, 'HIGHBYTE' also leave out the `_WP_` part. […]
I updated to use `#define GPIO_CONFIG_ADDRESS 0x104F`. For low byte case, I know it can auto cast, but still write GPIO_CONFIG_ADDRESS & 0xFF to make it clear. Let's see if that looks good.