David Hendricks has submitted this change. ( https://review.coreboot.org/c/flashrom/+/54965 )
Change subject: Add support for Intel Emmitsburg PCH ......................................................................
Add support for Intel Emmitsburg PCH
This patch does the following: - Add PCIe ID for Intel Emmitsburg PCH - Based on ICH descriptor content, choose CHIPSET_C620_SERIES_LEWISBURG if ISL/PSL is 80.
TESTED=tried on a server with Intel Emmitsburg PCH, flash update was successful. This server, however, does not have flash chip installed, it instead has em100 emulator connected.
Change-Id: I2a1bb7467e693d1583aa885fa0e277075edd4a3e Signed-off-by: Jonathan Zhang jonzhang@fb.com Signed-off-by: David Hendricks ddaveh@amazon.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/54965 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Christian Walter christian.walter@9elements.com Reviewed-by: Johnny Lin Johnny_Lin@wiwynn.com Reviewed-by: Tim Chu Tim.Chu@quantatw.com --- M chipset_enable.c M ich_descriptors.c 2 files changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Christian Walter: Looks good to me, approved Johnny Lin: Looks good to me, but someone else must approve Tim Chu: Looks good to me, but someone else must approve
diff --git a/chipset_enable.c b/chipset_enable.c index cdd51ae..110d7a9 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -2073,6 +2073,7 @@ {0x8086, 0xa247, B_S, NT, "Intel", "C620 Series Chipset Supersku", enable_flash_c620}, {0x8086, 0xa248, B_S, NT, "Intel", "C620 Series Chipset Supersku", enable_flash_c620}, {0x8086, 0xa249, B_S, NT, "Intel", "C620 Series Chipset Supersku", enable_flash_c620}, + {0x8086, 0x1bca, B_S, NT, "Intel", "Emmitsburg Chipset SKU", enable_flash_c620}, {0x8086, 0xa2c4, B_S, NT, "Intel", "H270", enable_flash_pch100}, {0x8086, 0xa2c5, B_S, NT, "Intel", "Z270", enable_flash_pch100}, {0x8086, 0xa2c6, B_S, NT, "Intel", "Q270", enable_flash_pch100}, diff --git a/ich_descriptors.c b/ich_descriptors.c index aba7528..d56ade7 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -939,6 +939,8 @@ warn_peculiar_desc(content->ISL != 23, "Gemini Lake"); return CHIPSET_GEMINI_LAKE; } + if (content->ISL <= 80) + return CHIPSET_C620_SERIES_LEWISBURG; warn_peculiar_desc(content->ISL != 16, "Ibex Peak"); return CHIPSET_5_SERIES_IBEX_PEAK; } else if (upper->MDTBA == 0x00) {