Attention is currently required from: Nico Huber.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54862 )
Change subject: serprog.c: Use braces in both branches of conditional statement
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/54862/comment/3b3ae941_c2e4f9ad
PS1, Line 9: According to the style guide.
Make it a full sentence? […]
Done
File serprog.c:
https://review.coreboot.org/c/flashrom/+/54862/comment/fcb8532d_58e761fe
PS1, Line 876: } else {
`else` isn't necessary here. I don't really care, though.
oh I see, if branch goes to error anyway. maybe I will return to this later?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54862
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4fdccbd66f0351af98811bf7c2d8e15f0a99d852
Gerrit-Change-Number: 54862
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 24 May 2021 23:41:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment