Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66782 )
Change subject: tree/: Convert flashchip write func ptr to enumerate ......................................................................
Patch Set 11:
(2 comments)
File include/flash.h:
https://review.coreboot.org/c/flashrom/+/66782/comment/553fad0a_18c9c178 PS8, Line 229: chip_write_func
The functions are all inconsistent identifiers, I did best efforts not to be too confusing as a patc […]
Just to check, are we talking about the same thing: I was talking about the names of enums, not about the names of functions and the names of enum entries. So it would be 2 lines to change (hope I am not mistaken) one line with enum declaration `enum chip_write_func` -> `enum write_func` and then below in struct flashchip `enum chip_write_func write;` -> `enum write_func write;`
like `probe_func` in previous patch?
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/66782/comment/c12ef62f_4fbcbc43 PS11, Line 150: static const struct flashchip chip_8MiB = { If you could add one empty line between 149 and 150? Extern declaration is used by more than one struct, so it doesn't need to be glued to it.