Attention is currently required from: Felix Singer, Nico Huber, Edward O'Callaghan, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60272 )
Change subject: ichspi: Remove unneeded line breaks, add useful ones ......................................................................
Patch Set 4:
(6 comments)
Patchset:
PS4: Given that we now have a dedicated commit for line breaks, I went through the file and removed few more of those.
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/60272/comment/01511769_baae195e PS1, Line 930: REGREAD16(ICH7_REG_SPIS));
This too
Done
https://review.coreboot.org/c/flashrom/+/60272/comment/5463b2dc_c3ead33a PS1, Line 999: SSFC_DBC);
I would remove this line break.
Done
https://review.coreboot.org/c/flashrom/+/60272/comment/202b3c2a_a8b4272e PS1, Line 1052: REGREAD32(swseq_data.reg_ssfsc));
This too
Done
https://review.coreboot.org/c/flashrom/+/60272/comment/fe9857ba_9cd8eddd PS1, Line 1127: cmd);
This too
Done
https://review.coreboot.org/c/flashrom/+/60272/comment/f2806f5a_3e95053b PS1, Line 1402: "N
This too
Done