Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58276 )
Change subject: platform.h: remove IS_LINUX and IS_MACOSX macros
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58276/comment/0ad880d9_f4f59910
PS2, Line 9: Replace the remaining uses by the plain macros.
Done
Actually, this was meant for the first line. No big deal, though.
If you break the line after the period, why is that? Usually it's
only done to start a new paragraph or in listings. The former should
be separated by empty lines and the latter should have bullet points :)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58276
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I23ec8fdcff8202d10ddf5a7520432e5b26b01cd4
Gerrit-Change-Number: 58276
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 14 Oct 2021 12:38:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Gerrit-MessageType: comment