Attention is currently required from: Alexander Goncharov, Angel Pons, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine, Stefan Reinauer, Swift Geek (Sebastian Grzywna), Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75906?usp=email )
Change subject: doc: Add new Development guidelines ......................................................................
Patch Set 6:
(4 comments)
File doc/dev_guide/development_guide.rst:
https://review.coreboot.org/c/flashrom/+/75906/comment/da59936d_45acc7bf : PS5, Line 161: approproately
typo: appropriately
Done
https://review.coreboot.org/c/flashrom/+/75906/comment/cfa92148_48e072ff : PS5, Line 235: you
typo: your
Done
https://review.coreboot.org/c/flashrom/+/75906/comment/b718d54f_8474a520 : PS5, Line 235: -s
If the commit is already signed-off, will this add another signoff (probably not intended), or will […]
I am using this command all the time without thinking (muscle memory) and it does not add second line of the same sign-off. It adds sign-off line at the end of commit message, and then if it exists already than does nothing.
One caveat: if, after first time signing-off, you manually edit commit message to move sign-off line somewhere else, like in the middle of commit message (why would you even do it? :) ), then it adds the line one more time at the end. Because it always adds line at the end.
File doc/dev_guide/development_guidelines.rst:
https://review.coreboot.org/c/flashrom/+/75906/comment/5fae8f17_9990470d : PS2, Line 194: you can add Anastasia Klimchuk as a reviewer
Is anyone interested to put your name here too? ;)
The question stays valid, but this patch is not blocked on it, so I am marking as resolved.