Attention is currently required from: Nico Huber, Edward O'Callaghan.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62832 )
Change subject: Makefile: build shared usb code only when needed by programmer
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
While I can see the reasoning for this and it makes sense I have a supplementary argument to Nico's […]
This patch changes only the reason why the usb_device.c and usbdev.c are build. There are no changes from the compiler or linkers view. The functions in usb_device.c or usbdev.c are part of the programmer and just outsourced for reuse in other programmers. Therefore it should be build as part of the programmer and not as part of the dependency.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62832
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9a91c5801a573e7021686a183a1bd874122e35cc
Gerrit-Change-Number: 62832
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan
quasisec@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Mon, 11 Apr 2022 08:42:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment
