[flashrom-gerrit] [M] Change in flashrom[master]: ichspi.c: Read chip ID and use it to populate `flash->chip`

[Damien Zammit (Code Review)]

Attention is currently required from: Nico Huber, Edward O'Callaghan, Nikolai Artemiev.

Damien Zammit has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69195 )

Change subject: ichspi.c: Read chip ID and use it to populate `flash->chip`
......................................................................

Patch Set 16: Code-Review+1

(1 comment)

Patchset:

PS16: 
Tested on Lenovo W530 (8+4MB flash chips)
```
$ sudo ./flashrom -p internal --flash-name
flashrom v1.2-1130-g7902b2b5-dirty on Linux 5.19.9-1.el8.elrepo.x86_64 (x86_64)
flashrom is free software, get the source code at https://flashrom.org

Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns).
coreboot table found at 0x7ff62000.
Found chipset "Intel QM77".
Enabling flash write... SPI Configuration is locked down.
FREG0: Flash Descriptor region (0x00000000-0x00000fff) is read-write.
FREG1: BIOS region (0x00500000-0x00bfffff) is read-write.
FREG2: Management Engine region (0x00003000-0x004fffff) is read-write.
FREG3: Gigabit Ethernet region (0x00001000-0x00002fff) is read-write.
Enabling hardware sequencing due to multiple flash chips detected.
OK.
Multiple flash components detected, skipping flash identification.
Found Programmer flash chip "Opaque flash chip" (12288 kB, Programmer-specific) on internal.
vendor="Programmer" name="Opaque flash chip"
$
```