30 May
2022
30 May
'22
9:44 p.m.
Attention is currently required from: Nico Huber, Martin L Roth, Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62745 )
Change subject: test_build.sh: Allow WARNERROR to be overridden ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
I'm not sure I understand your question. […]
Yes this is also my understanding (as Martin explained): this patch gives a way to override "warnings as errors" option. Not repeating Makefile, but rather using Makefile's feature? Makefile has a feature to allow "warnings as errors" to be overridden, and the script is using this feature.
--
To view, visit https://review.coreboot.org/c/flashrom/+/62745
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226
Gerrit-Change-Number: 62745
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth gaumless@tutanota.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Martin L Roth gaumless@tutanota.com
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Mon, 30 May 2022 21:44:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Martin L Roth gaumless@tutanota.com
Gerrit-MessageType: comment