Hello Miklós Márton, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/43051
to look at the new patch set (#2).
Change subject: serial: Fix file read/write error handling for Windows ......................................................................
serial: Fix file read/write error handling for Windows
File read/write semantics are different between POSIX and Windows. In particular Windows file read/write functions return a boolean type to indicate success or failure, while the POSIX equivalents return a signed integer indicating number of bytes read if successful or -1 if not.
This attempts to correct some error handling paths for Windows and avoid invalid comparisons that were causing compilation issues.
Reported on https://github.com/flashrom/flashrom/issues/149
Change-Id: Ib179d51ede2dbd38f54f3641bfe90340a6a87e31 Signed-off-by: David Hendricks david.hendricks@gmail.com --- M serial.c 1 file changed, 22 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/51/43051/2