16 Jul
2019
16 Jul
'19
11:58 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34234 )
Change subject: flashchips: Add Macronix MX25L51245G ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/34234/2/flashchips.h File flashchips.h:
https://review.coreboot.org/c/flashrom/+/34234/2/flashchips.h@482 PS2, Line 482: #define MACRONIX_MX25L51245G 0x201A Sigh, now I discovered another issue, the same ID is used by MX66L51235F below.
And looking at its entry in flashchips.c, it seems compatible. If it has the same values everywhere, the two should get merged and we'd only have to change the .name to "MX66L51235F/MX25L51245G".
--
To view, visit https://review.coreboot.org/c/flashrom/+/34234
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I964e630197e33d69b199fdfb8816f18e3112bbb1
Gerrit-Change-Number: 34234
Gerrit-PatchSet: 2
Gerrit-Owner: Hemanth Guruva Reddy
Gerrit-Reviewer: Alan Green avg@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Hemanth Guruva Reddy
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Sean Nelson audiohacked@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jul 2019 11:58:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment