Attention is currently required from: Anastasia Klimchuk, Peter Marheine.
Matti Finder has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84934?usp=email )
Change subject: rpmc: add rpmc commands feature
......................................................................
Patch Set 7:
(2 comments)
File sfdp.c:
https://review.coreboot.org/c/flashrom/+/84934/comment/368b066d_639955b1?usp... :
PS6, Line 457: return 0;
We still need to free the buffers, so I think this should be […]
Had to also add free(tbuf) so that we don't create a memory leak.
https://review.coreboot.org/c/flashrom/+/84934/comment/43390e6d_346ff2be?usp... :
PS6, Line 482: return 1;
I think let's keep the previous line (`return ret`), since `goto cleanup_hdrs` is called a few times […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/84934?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I6ab3d0446e9fd674b20550fdbfaf499b8d4a9b38
Gerrit-Change-Number: 84934
Gerrit-PatchSet: 7
Gerrit-Owner: Matti Finder
matti.finder@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Wed, 06 Nov 2024 16:33:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org