Attention is currently required from: Felix Singer, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67091 )
Change subject: flashrom.c: Make 'chip_to_probe' a param to probe_flash()
......................................................................
Patch Set 12:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67091/comment/e7e1c33c_0aa7871d
PS4, Line 12: funtion
typo, funtion -> function
Done
https://review.coreboot.org/c/flashrom/+/67091/comment/fc213ae9_6353f8f8
PS4, Line 14:
You have probably tested this by probing something (anything at all)? Could you please add testing i […]
Done
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/67091/comment/799839c3_58554e49
PS4, Line 837: return 0;
Should this be `goto notfound` ? […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67091
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifcdace07ea2135d83dea92cfa5c6bec8d7ddf05d
Gerrit-Change-Number: 67091
Gerrit-PatchSet: 12
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 31 Oct 2022 23:17:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment