Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55932 )
Change subject: spi_master: Add shutdown function in spi_master struct
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Patchset:
PS1:
Oh and I also can see, for the masters without programmer entry, the entry does not even exist in pr […]
On a gut level, "it will never be needed".
Well, as you mentioned the programmer name, it seems possible that one might
want such a relation for cosmetical reasons (e.g. ui output). But I don't
think we'll ever need it for the flashing functionality.
File spi.c:
https://review.coreboot.org/c/flashrom/+/55932/comment/05cd1f87_954d30c3
PS3, Line 142: }
Technically not needed, but this should have another set of braces.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/55932
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2dc80dceca2f8204bcd0dad1f51753d7e79f1af5
Gerrit-Change-Number: 55932
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Sat, 10 Jul 2021 11:54:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment