Attention is currently required from: Nico Huber, Paul Menzel, Peter Marheine.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61194 )
Change subject: hwaccess: fix build on non-x86 targets
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS1:
I've now opted to put the x86 guards in the headers rather than in the files that include them bec […]
I've started working on an overhaul of the hwaccess code in CB:61275 and CB:61276. But this will need some time and testing due to the mess of #if. I'm fine with this patch as temporary solution.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/61194
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e
Gerrit-Change-Number: 61194
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Sat, 22 Jan 2022 22:50:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment