27 Jun
2023
27 Jun
'23
12:02 a.m.
Attention is currently required from: Brian Norris, Nikolai Artemiev.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75991?usp=email )
Change subject: flashrom: only unlock for write/erase operations ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I checked the unlock functions, it turns out one of them actually does unlock for reads (last bullet […]
Tricky, what about doing the `R|W` specialisation within the `unlock_flash_wp()` preamble? If the chip has `SPI_DISABLE_BLOCKPROTECT_SST26_GLOBAL_UNPROTECT` set `return 1` to let the fallback to the old `bp_func` mechanism for these special chips?
--
To view, visit https://review.coreboot.org/c/flashrom/+/75991?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5dc66474a0b7969b51b86ac9f5daa2c95ae968f1
Gerrit-Change-Number: 75991
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Brian Norris briannorris@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Brian Norris briannorris@chromium.org
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Tue, 27 Jun 2023 00:02:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Brian Norris briannorris@chromium.org
Comment-In-Reply-To: Nikolai Artemiev nartemiev@google.com
Gerrit-MessageType: comment