Attention is currently required from: Patrick Rudolph, Arthur Heymans.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63135 )
Change subject: linux_mtd: Allow to open parition by name
......................................................................
Patch Set 1:
(1 comment)
File linux_mtd.c:
https://review.coreboot.org/c/flashrom/+/63135/comment/3d3408b1_8c092e88
PS1, Line 464: extract_programmer_param("name");
Would it make sense to use this path when strtol path is not taken so that no new parameter is neede […]
I thought it's already mutually exclusive as extract_programmer_param("name"); is in the else branch.
I did not reuse the existing dev as a partition label might contain digits only. In that case you'd not know if the number is the MTD device or the label.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63135
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I566b9809950cbf47fbb01ae89305641c4e259f68
Gerrit-Change-Number: 63135
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 28 Mar 2022 10:56:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment