Attention is currently required from: Felix Singer, Michał Żygowski, Paul Menzel, Sergii Dmytruk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 )
Change subject: ite_ecfw: Implement support for flashing ITE ECs found on TUXEDO laptops ......................................................................
Patch Set 29:
(1 comment)
Patchset:
PS29:
Now I probe only for ITE Super I/Os. Just added more model IDs in the switch to catch the supported chips. Redesigning Super I/O code needs more thought and I won't pursue it right now. DMI checks have been replaced with PCI ID and SSID checks to not depend on any dmidecoder (which may fail depending on UEFI vs legacy).
Generally, I'd prefer to simply hook this driver up in the internal programmer. Then it would be easiest to use the board_enable infrastructure and we wouldn't have to re- invent it.
Alternatively, if you agree that the interface will change significantly in the future, we can also keep the local checks and add a FIXME comment that it actually belongs into the internal programmer. Most of the programmer drivers added lately do things wrong and I fear if we add more bad examples these issues will become worse.