Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54748 )
Change subject: dummyflasher.c: Fix data leak in params processing error paths ......................................................................
Patch Set 6:
(2 comments)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/54748/comment/76d2c2fc_b49c61fb PS1, Line 26: /* Remove the #define below if you don't want SPI flash chip emulation. */ : #define EMULATE_SPI_CHIP 1
What I was wondering, is if EMULATE_SPI_CHIP is undefined then some chunks of code won't be includ […]
I think the behavior can be achieved with respective command-line options. If it was a global option to exclude all SPI code from the build, I would understand it. But this local, unused flag just makes maintenance harder, IMHO.
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/54748/comment/f1977694_dc32c6cc PS5, Line 653: #if EMULATE_SPI_CHIP
thank you! I will rebased once CB:55265 and CB:55266 are submitted.
This change was ready to be submitted first, so I guess it's fair to let Angel rebase (also their patch is easier to re-review).