3 Aug
2019
3 Aug
'19
2:35 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34488 )
Change subject: flashchips: Split MT25Q from N25Q ......................................................................
Patch Set 1: -Code-Review
Sorry, run into the sorting trap. We try to enforce a sort order on .vendor, .name in `flashchips.c`, currently. I sup- pose "Micron" comes before "Micron/Numonyx/ST".
Alan, how about adding a simple check for this to the Make- file, that could be checked by Jenkins.
--
To view, visit https://review.coreboot.org/c/flashrom/+/34488
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9d79978544b19cf9acd5f3ea6196cf6f3b3435ef
Gerrit-Change-Number: 34488
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Creedon jcreedon@google.com
Gerrit-Reviewer: Alan Green avg@google.com
Gerrit-Reviewer: Jacob Creedon jcreedon@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan quasisec@chromium.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 03 Aug 2019 14:35:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment