27 May
2021
27 May
'21
10:42 a.m.
Attention is currently required from: Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54854 )
Change subject: dummyflasher.c: Replace atoi() with strtoul() ......................................................................
Patch Set 3:
(1 comment)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/54854/comment/a848741b_d7567fd3 PS3, Line 715: free(tmp); Sigh, this introduces a use-after-free bug... CB:46551 and CB:54909 fixed the same kind of thing.
This strtoul() pattern repeats itself a lot. Why isn't it a helper function?
--
To view, visit https://review.coreboot.org/c/flashrom/+/54854
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib9e66016a2f4ce2d13b833c261f900cab80916b7
Gerrit-Change-Number: 54854
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Thu, 27 May 2021 10:42:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment