Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Nikolai Artemiev, Joursoir.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64351 )
Change subject: cli_classic: fix memory leak
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/64351/comment/d9dc7f57_ff443c25
PS1, Line 1103: if (set_wp_region && wp_region)
The standard says: `If ptr is a null pointer, no action occurs.` […]
Given that `wp_region` is explicitly first-time initialised to NULL (in the same line as the declaration), I'd free it the same way the other pointers are freed:
free(wp_region);
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64351
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8520e302e9d63ed1215c5d9beb90a93fb52a91fe
Gerrit-Change-Number: 64351
Gerrit-PatchSet: 1
Gerrit-Owner: Joursoir
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Joursoir
chat@joursoir.net
Gerrit-Comment-Date: Mon, 16 May 2022 10:07:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Joursoir
chat@joursoir.net
Gerrit-MessageType: comment