Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44420 )
Change subject: Add support for Comet Lake-U/400-series PCH ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/flashrom/+/44420/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/44420/1//COMMIT_MSG@10 PS1, Line 10: to CHIPSET_300_SERIES_CANNON_POINT.
isn't that what I'm doing?
I mean, the code currently treats both of them the same, but there's different enum elements for 300 series and 400 series PCHs. I'm not sure if it would be simpler to assume they're the same until we find differences.
I don't really mind either approach. I wanted to know if there's a reason to have separate enum elements.
https://review.coreboot.org/c/flashrom/+/44420/1/chipset_enable.c File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/44420/1/chipset_enable.c@2015 PS1, Line 2015: {0x8086, 0x0284, B_S, DEP, "Intel", "Comet Lake U Premium", enable_flash_pch400},
I'm guessing you meant a different ID than the one I already added :)
Oops, sorry. Thank you.