27 Apr
2021
27 Apr
'21
1:47 a.m.
Attention is currently required from: Nico Huber. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52596 )
Change subject: mec1308.c: Untangle successful vs failed init paths ......................................................................
Patch Set 3:
(1 comment)
File mec1308.c:
https://review.coreboot.org/c/flashrom/+/52596/comment/2a6e5fe6_4c3680a1 PS1, Line 519: mec1308_init_exit
Yeah I was thinking about those label names a lot, I agree just saying this one is "exit" is not ide […]
This patch now has a sibling: https://review.coreboot.org/c/flashrom/+/52685 I used the same name for exit label.
--
To view, visit https://review.coreboot.org/c/flashrom/+/52596
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibf35335501e59636c544af124ad7a04a186790b4
Gerrit-Change-Number: 52596
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-CC: Victor Ding victording@google.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Tue, 27 Apr 2021 01:47:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment